Add missing clock required by RPiVid video decoder and make HDMI
pixel clock more reliable.
Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.
Ivan T. Ivanov (2):
clk: bcm: rpi: Add support HEVC clock
clk: bcm: rpi: Handle pixel clock in firmware
drivers/clk/bcm/clk-raspberrypi.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.26.2
On Tue, Apr 05, 2022 at 11:25:01AM +0300, Ivan T. Ivanov wrote:
> Add missing clock required by RPiVid video decoder and make HDMI
> pixel clock more reliable.
For both patches:
Acked-by: Maxime Ripard <[email protected]>
Thanks!
Maxime
The clk-bcm2835 handling of the pixel clock does not function
correctly when the HDMI power domain is disabled.
The firmware supports it correctly, so add it to the
firmware clock driver.
Cc: Dave Stevenson <[email protected]>
Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/clk/bcm/clk-raspberrypi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 2e2491d85835..530820d13104 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
[RPI_FIRMWARE_V3D_CLK_ID] = {
.export = true,
},
+ [RPI_FIRMWARE_PIXEL_CLK_ID] = {
+ .export = true,
+ },
[RPI_FIRMWARE_HEVC_CLK_ID] = {
.export = true,
},
--
2.26.2
Export clock required for RPiVid video decoder hardware.
Cc: Dom Cobley <[email protected]>
Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/clk/bcm/clk-raspberrypi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 9d09621549b9..2e2491d85835 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
[RPI_FIRMWARE_V3D_CLK_ID] = {
.export = true,
},
+ [RPI_FIRMWARE_HEVC_CLK_ID] = {
+ .export = true,
+ },
[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
.export = true,
},
--
2.26.2
On Tue, 5 Apr 2022 at 09:25, Ivan T. Ivanov <[email protected]> wrote:
>
> The clk-bcm2835 handling of the pixel clock does not function
> correctly when the HDMI power domain is disabled.
>
> The firmware supports it correctly, so add it to the
> firmware clock driver.
>
> Cc: Dave Stevenson <[email protected]>
> Signed-off-by: Ivan T. Ivanov <[email protected]>
Acked-by: Dave Stevenson <[email protected]>
> ---
> drivers/clk/bcm/clk-raspberrypi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
> index 2e2491d85835..530820d13104 100644
> --- a/drivers/clk/bcm/clk-raspberrypi.c
> +++ b/drivers/clk/bcm/clk-raspberrypi.c
> @@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
> [RPI_FIRMWARE_V3D_CLK_ID] = {
> .export = true,
> },
> + [RPI_FIRMWARE_PIXEL_CLK_ID] = {
> + .export = true,
> + },
> [RPI_FIRMWARE_HEVC_CLK_ID] = {
> .export = true,
> },
> --
> 2.26.2
>
Hi Michael, Stephen,
On 04-05 11:04, Maxime Ripard wrote:
> Date: Tue, 5 Apr 2022 11:04:31 +0200
> From: Maxime Ripard <[email protected]>
> To: "Ivan T. Ivanov" <[email protected]>
> Cc: Michael Turquette <[email protected]>, Stephen Boyd
> <[email protected]>, [email protected],
> [email protected]
> Subject: Re: [PATCH v2 0/2] clk: bcm: rpi: Add support for two more clocks
> Message-ID: <20220405090431.ktlybn62eueh7gqi@houat>
Tags: all clk linux me ring
>
> On Tue, Apr 05, 2022 at 11:25:01AM +0300, Ivan T. Ivanov wrote:
> > Add missing clock required by RPiVid video decoder and make HDMI
> > pixel clock more reliable.
>
> For both patches:
> Acked-by: Maxime Ripard <[email protected]>
>
Any chance that this is merged in foreseeable future?
Do you have any comments or objections?
Thanks,
Ivan
Hi Ivan,
Am 15.04.22 um 09:48 schrieb Ivan T. Ivanov:
> Hi Michael, Stephen,
>
> On 04-05 11:04, Maxime Ripard wrote:
>> Date: Tue, 5 Apr 2022 11:04:31 +0200
>> From: Maxime Ripard <[email protected]>
>> To: "Ivan T. Ivanov" <[email protected]>
>> Cc: Michael Turquette <[email protected]>, Stephen Boyd
>> <[email protected]>, [email protected],
>> [email protected]
>> Subject: Re: [PATCH v2 0/2] clk: bcm: rpi: Add support for two more clocks
>> Message-ID: <20220405090431.ktlybn62eueh7gqi@houat>
> Tags: all clk linux me ring
>> On Tue, Apr 05, 2022 at 11:25:01AM +0300, Ivan T. Ivanov wrote:
>>> Add missing clock required by RPiVid video decoder and make HDMI
>>> pixel clock more reliable.
>> For both patches:
>> Acked-by: Maxime Ripard <[email protected]>
>>
> Any chance that this is merged in foreseeable future?
> Do you have any comments or objections?
could you please send a new version with all tags and consider the whole
audience based on this patch [1]?
Thanks
[1] -
https://lore.kernel.org/linux-arm-kernel/[email protected]/T/
>
> Thanks,
> Ivan
>
>