2022-01-26 20:45:15

by Miaohe Lin

Subject: [PATCH] mm/highmem: remove unnecessary done label

Remove unnecessary done label to simplify the code.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/highmem.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/highmem.c b/mm/highmem.c
index 762679050c9a..0cc0c4da7ed9 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -736,11 +736,11 @@ void *page_address(const struct page *page)
list_for_each_entry(pam, &pas->lh, list) {
if (pam->page == page) {
ret = pam->virtual;
- goto done;
+ break;
}
}
}
-done:
+
spin_unlock_irqrestore(&pas->lock, flags);
return ret;
}
@@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual)
list_for_each_entry(pam, &pas->lh, list) {
if (pam->page == page) {
list_del(&pam->list);
- spin_unlock_irqrestore(&pas->lock, flags);
- goto done;
+ break;
}
}
spin_unlock_irqrestore(&pas->lock, flags);
}
-done:
+
return;
}

--
2.23.0

2022-01-26 20:55:22

by Muchun Song

Subject: Re: [PATCH] mm/highmem: remove unnecessary done label

On Wed, Jan 26, 2022 at 5:26 PM Miaohe Lin <[email protected]> wrote:
>
> Remove unnecessary done label to simplify the code.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

2022-01-26 21:02:45

by David Hildenbrand

Subject: Re: [PATCH] mm/highmem: remove unnecessary done label

On 26.01.22 10:25, Miaohe Lin wrote:
> Remove unnecessary done label to simplify the code.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/highmem.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 762679050c9a..0cc0c4da7ed9 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -736,11 +736,11 @@ void *page_address(const struct page *page)
> list_for_each_entry(pam, &pas->lh, list) {
> if (pam->page == page) {
> ret = pam->virtual;
> - goto done;
> + break;
> }
> }
> }
> -done:
> +
> spin_unlock_irqrestore(&pas->lock, flags);
> return ret;
> }
> @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual)
> list_for_each_entry(pam, &pas->lh, list) {
> if (pam->page == page) {
> list_del(&pam->list);
> - spin_unlock_irqrestore(&pas->lock, flags);
> - goto done;
> + break;
> }
> }
> spin_unlock_irqrestore(&pas->lock, flags);
> }
> -done:
> +
> return;
> }
>

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2022-01-26 22:30:52

by David Rientjes

Subject: Re: [PATCH] mm/highmem: remove unnecessary done label

On Wed, 26 Jan 2022, Miaohe Lin wrote:

> Remove unnecessary done label to simplify the code.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: David Rientjes <[email protected]>