This message contains a list of some regressions from 2.6.23 reported since
2.6.24-rc1 was released, for which there are no fixes in the mainline I know
of. ?If any of them have been fixed already, please let me know.
If you know of any other unresolved regressions from 2.6.23, please let me know
either and I'll add them to the list. ?Also, please let me know if any of the
entries below are invalid.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
Today 157 25 12
2008-01-12 150 28 14
2008-01-05 139 28 15
2008-01-01 139 38 23
2007-12-21 118 21 13
2007-12-18 115 29 15
2007-12-12 106 31 17
2007-12-08 98 29 19
2007-12-01 85 29 18
2007-11-24 75 25 21
2007-11-19 68 26 21
2007-11-17 65 25 20
Unresolved regressions
----------------------
Subject : EHCI causes system to resume instantly from S4
Submitter : Maxim Levitsky <[email protected]>
Date : 2007-10-28 14:56
References : http://lkml.org/lkml/2007/10/27/66
http://bugzilla.kernel.org/show_bug.cgi?id=9258
Handled-By : "Rafael J. Wysocki" <[email protected]>
David Brownell <[email protected]>
Alan Stern <[email protected]>
Workaround : http://bugzilla.kernel.org/show_bug.cgi?id=9258#c30
Subject : SError: { DevExch } occuring and causing disruption
Submitter : Avuton Olrich <[email protected]>
Date : 2007-11-15 22:39
References : http://bugzilla.kernel.org/show_bug.cgi?id=9393
Handled-By : Tejun Heo <[email protected]>
Mark Lord <[email protected]>
Subject : BUG: bad unlock balance detected!
Submitter : Krzysztof Oledzki <[email protected]>
Date : 2007-12-11 03:17
References : http://bugzilla.kernel.org/show_bug.cgi?id=9542
Handled-By : Andrew Morton <[email protected]>
Herbert Xu <[email protected]>
Subject : swapping in 2.6.24-rc5-git3
Submitter : Lukas Hejtmanek <[email protected]>
Date : 2007-12-17 14:04
References : http://lkml.org/lkml/2007/12/17/98
http://bugzilla.kernel.org/show_bug.cgi?id=9592
Handled-By : Jan Kara <[email protected]>
Subject : Problems on booting
Submitter : "werner" <[email protected]>
Date : 2007-12-22 14:29
References : http://lkml.org/lkml/2007/12/22/110
http://bugzilla.kernel.org/show_bug.cgi?id=9621
Subject : ACPI or radeon: spontaneous reboot regression
Submitter : Matt Mackall <[email protected]>
Date : 2007-12-22 16:09
References : http://lkml.org/lkml/2007/12/22/139
http://bugzilla.kernel.org/show_bug.cgi?id=9624
Handled-By : Len Brown <[email protected]>
Subject : lockdep warning with LTP dio test (v2.6.24-rc6-125-g5356f66)
Submitter : Erez Zadok <[email protected]>
Date : 2007-12-24 18:02
References : http://lkml.org/lkml/2007/12/24/107
http://bugzilla.kernel.org/show_bug.cgi?id=9670
Subject : kexec buffer error
Submitter : Randy Dunlap <[email protected]>
Date : 2008-01-04 22:54
References : http://lkml.org/lkml/2008/1/4/255
http://bugzilla.kernel.org/show_bug.cgi?id=9693
Subject : 2.6.24-rc7 -- WARNING: at kernel/lockdep.c:2662 check_flags()
Submitter : "Miles Lane" <[email protected]>
Date : 2008-01-07 04:34
References : http://lkml.org/lkml/2008/1/6/313
http://bugzilla.kernel.org/show_bug.cgi?id=9737
Handled-By : Ingo Molnar <[email protected]>
Subject : [BUG] 2.6.24-rc5: 'sysctl table check failed' when turning on printer
Submitter : Frans Pop <[email protected]>
Date : 2007-12-16 21:19
References : http://lkml.org/lkml/2007/12/16/121
http://lkml.org/lkml/2008/1/6/228
http://bugzilla.kernel.org/show_bug.cgi?id=9749
Handled-By : "Eric W. Biederman" <[email protected]>
Subject : crash in kmem_cache_init
Submitter : Olaf Hering <[email protected]>
Date : 2008-01-15 16:09
References : http://lkml.org/lkml/2008/1/15/180
http://bugzilla.kernel.org/show_bug.cgi?id=9755
Handled-By : Christoph Lameter <[email protected]>
Subject : sky2 patch in 2.6.24-rc7-git6 breaks POST - commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac
Submitter : "Ioan Ionita" <[email protected]>
Date : 2008-01-15 12:01
References : http://lkml.org/lkml/2008/1/15/98
http://bugzilla.kernel.org/show_bug.cgi?id=9756
Handled-By : Stephen Hemminger <[email protected]>
Regressionn with patches
------------------------
Subject : [2.6.24-rc6] pdflush still stuck in D state regression
Submitter : "Tvrtko A. Ursulin" <[email protected]>
Date : 2007-11-02 09:54
References : http://bugzilla.kernel.org/show_bug.cgi?id=9291
Handled-By : Dave Kleikamp <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=14219&action=view
Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
Submitter : Roland Dreier <[email protected]>
Date : 2007-11-08 14:55
References : http://lkml.org/lkml/2007/11/8/255
http://bugzilla.kernel.org/show_bug.cgi?id=9332
Handled-By : Takashi Iwai <[email protected]>
Ingo Molnar <[email protected]>
Patch : http://lkml.org/lkml/2007/11/16/66
Subject : jiffies counter leaps in 2.6.24-rc3
Submitter : Stefano Brivio <[email protected]>
Date : 2007-11-29 08:36
References : http://lkml.org/lkml/2007/11/24/53
http://bugzilla.kernel.org/show_bug.cgi?id=9475
Handled-By : Ingo Molnar <[email protected]>
Patch : http://lkml.org/lkml/2007/12/7/132
Subject : 2.6.24-rc4 hwmon it87 probe fails
Submitter : Mike Houston <[email protected]>
Date : 2007-12-06 17:10
References : http://lkml.org/lkml/2007/12/4/466
http://bugzilla.kernel.org/show_bug.cgi?id=9514
Handled-By : Shaohua Li <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=14267&action=view
Subject : RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)
Submitter : Krzysztof Oledzki <[email protected]>
Date : 2007-12-11 03:20
References : http://bugzilla.kernel.org/show_bug.cgi?id=9543
Handled-By : Andrew Morton <[email protected]>
Herbert Xu <[email protected]>
Jay Vosburgh <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=9543#c6
Subject : PATA_HPT37X embezzles two ports
Submitter : "Bjoern Olausson" <[email protected]>
Date : 2007-12-12 11:05
References : http://lkml.org/lkml/2007/12/12/161
http://bugzilla.kernel.org/show_bug.cgi?id=9551
Handled-By : Alan Cox <[email protected]>
Patch : http://lkml.org/lkml/2007/1/4/161
Subject : wake on lan fails with sky2 module
Submitter : cpo <[email protected]>
Date : 2008-01-09 13:05
References : http://bugzilla.kernel.org/show_bug.cgi?id=9721
http://marc.info/?t=119992349300001&r=1&w=4
Handled-By : Stephen Hemminger <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=14455&action=view
Subject : psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1
Submitter : "Vegard Nossum" <[email protected]>
Date : 2007-11-14 21:26
References : http://lkml.org/lkml/2007/11/14/363
http://bugzilla.kernel.org/show_bug.cgi?id=9727
Handled-By : Dmitry Torokhov <[email protected]>
Patch : http://lkml.org/lkml/2008/1/16/151
Subject : regression: sysctl_check changes in 2.6.24 are O(n) resulting in slow creation of 10000 network interfaces
Submitter : Benjamin LaHaise <[email protected]>
Date : 2008-01-06 23:03
References : http://lkml.org/lkml/2008/1/6/248
http://bugzilla.kernel.org/show_bug.cgi?id=9736
Handled-By : "Eric W. Biederman" <[email protected]>
Patch : http://lkml.org/lkml/2008/1/7/60
Subject : Oops on boot from laptop mode writing to /proc/acpi/processor/CPU0/throttling
Submitter : Simon Huggins <[email protected]>
Date : 2008-01-14 11:19
References : http://bugzilla.kernel.org/show_bug.cgi?id=9747
Handled-By : Alexey Starikovskiy <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=14456&action=view
Subject : fs/hfs/btree.c: new NULL dereference
Submitter : Adrian Bunk <[email protected]>
Date : 2008-01-14 13:17
References : http://bugzilla.kernel.org/show_bug.cgi?id=9748
Handled-By : Eric Sandeen <[email protected]>
Patch : http://lkml.org/lkml/2008/1/14/365
Subject : [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang
Submitter : Frans Pop <[email protected]>
Date : 2008-01-15 06:25
References : http://lkml.org/lkml/2008/1/15/4
http://bugzilla.kernel.org/show_bug.cgi?id=9757
Handled-By : David Miller <[email protected]>
Patch : http://lkml.org/lkml/2008/1/16/2
Subject : radeonfb and Xpress 200m 5955
Submitter : Alex <[email protected]>
Date : 2008-01-16 01:33
References : http://bugzilla.kernel.org/show_bug.cgi?id=9762
Handled-By : Geert Uytterhoeven <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=14481&action=view
For details, please follow the links given in references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.23,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=9243
Please let me know if there are any Bugzilla entries that should be added to
the list in there.
Thanks,
Rafael
On Fri, 18 Jan 2008 00:35:41 +0100
"Rafael J. Wysocki" <[email protected]> wrote:
> This message contains a list of some regressions from 2.6.23 reported since
> 2.6.24-rc1 was released, for which there are no fixes in the mainline I know
> of. __If any of them have been fixed already, please let me know.
>
> If you know of any other unresolved regressions from 2.6.23, please let me know
> either and I'll add them to the list. __Also, please let me know if any of the
> entries below are invalid.
>
> Listed regressions statistics:
>
> Date Total Pending Unresolved
> ----------------------------------------
> Today 157 25 12
There are thirteen regressions for which we have patches but they aren't
merged. That seems rather high.
(cc's added).
Guys, can we get things wrapped up here please?
>
> Subject : [2.6.24-rc6] pdflush still stuck in D state regression
> Submitter : "Tvrtko A. Ursulin" <[email protected]>
> Date : 2007-11-02 09:54
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9291
> Handled-By : Dave Kleikamp <[email protected]>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=14219&action=view
>
>
> Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> Submitter : Roland Dreier <[email protected]>
> Date : 2007-11-08 14:55
> References : http://lkml.org/lkml/2007/11/8/255
> http://bugzilla.kernel.org/show_bug.cgi?id=9332
> Handled-By : Takashi Iwai <[email protected]>
> Ingo Molnar <[email protected]>
> Patch : http://lkml.org/lkml/2007/11/16/66
>
>
> Subject : jiffies counter leaps in 2.6.24-rc3
> Submitter : Stefano Brivio <[email protected]>
> Date : 2007-11-29 08:36
> References : http://lkml.org/lkml/2007/11/24/53
> http://bugzilla.kernel.org/show_bug.cgi?id=9475
> Handled-By : Ingo Molnar <[email protected]>
> Patch : http://lkml.org/lkml/2007/12/7/132
>
>
> Subject : 2.6.24-rc4 hwmon it87 probe fails
> Submitter : Mike Houston <[email protected]>
> Date : 2007-12-06 17:10
> References : http://lkml.org/lkml/2007/12/4/466
> http://bugzilla.kernel.org/show_bug.cgi?id=9514
> Handled-By : Shaohua Li <[email protected]>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=14267&action=view
>
>
> Subject : RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)
> Submitter : Krzysztof Oledzki <[email protected]>
> Date : 2007-12-11 03:20
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9543
> Handled-By : Andrew Morton <[email protected]>
> Herbert Xu <[email protected]>
> Jay Vosburgh <[email protected]>
> Patch : http://bugzilla.kernel.org/show_bug.cgi?id=9543#c6
>
>
> Subject : PATA_HPT37X embezzles two ports
> Submitter : "Bjoern Olausson" <[email protected]>
> Date : 2007-12-12 11:05
> References : http://lkml.org/lkml/2007/12/12/161
> http://bugzilla.kernel.org/show_bug.cgi?id=9551
> Handled-By : Alan Cox <[email protected]>
> Patch : http://lkml.org/lkml/2007/1/4/161
>
>
> Subject : wake on lan fails with sky2 module
> Submitter : cpo <[email protected]>
> Date : 2008-01-09 13:05
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9721
> http://marc.info/?t=119992349300001&r=1&w=4
> Handled-By : Stephen Hemminger <[email protected]>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=14455&action=view
>
>
> Subject : psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1
> Submitter : "Vegard Nossum" <[email protected]>
> Date : 2007-11-14 21:26
> References : http://lkml.org/lkml/2007/11/14/363
> http://bugzilla.kernel.org/show_bug.cgi?id=9727
> Handled-By : Dmitry Torokhov <[email protected]>
> Patch : http://lkml.org/lkml/2008/1/16/151
>
Looks like Dmitry has just sent this in to Linus.
>
> Subject : regression: sysctl_check changes in 2.6.24 are O(n) resulting in slow creation of 10000 network interfaces
> Submitter : Benjamin LaHaise <[email protected]>
> Date : 2008-01-06 23:03
> References : http://lkml.org/lkml/2008/1/6/248
> http://bugzilla.kernel.org/show_bug.cgi?id=9736
> Handled-By : "Eric W. Biederman" <[email protected]>
> Patch : http://lkml.org/lkml/2008/1/7/60
>
>
> Subject : Oops on boot from laptop mode writing to /proc/acpi/processor/CPU0/throttling
> Submitter : Simon Huggins <[email protected]>
> Date : 2008-01-14 11:19
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9747
> Handled-By : Alexey Starikovskiy <[email protected]>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=14456&action=view
>
>
> Subject : fs/hfs/btree.c: new NULL dereference
> Submitter : Adrian Bunk <[email protected]>
> Date : 2008-01-14 13:17
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9748
> Handled-By : Eric Sandeen <[email protected]>
> Patch : http://lkml.org/lkml/2008/1/14/365
I sent this fix to Linus a few minutes ago.
>
> Subject : [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang
> Submitter : Frans Pop <[email protected]>
> Date : 2008-01-15 06:25
> References : http://lkml.org/lkml/2008/1/15/4
> http://bugzilla.kernel.org/show_bug.cgi?id=9757
> Handled-By : David Miller <[email protected]>
> Patch : http://lkml.org/lkml/2008/1/16/2
>
I think Dave just sent this one.
>
> Subject : radeonfb and Xpress 200m 5955
> Submitter : Alex <[email protected]>
> Date : 2008-01-16 01:33
> References : http://bugzilla.kernel.org/show_bug.cgi?id=9762
> Handled-By : Geert Uytterhoeven <[email protected]>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=14481&action=view
>
I just sent this one.
> > Subject : PATA_HPT37X embezzles two ports
> > Submitter : "Bjoern Olausson" <[email protected]>
> > Date : 2007-12-12 11:05
> > References : http://lkml.org/lkml/2007/12/12/161
> > http://bugzilla.kernel.org/show_bug.cgi?id=9551
> > Handled-By : Alan Cox <[email protected]>
> > Patch : http://lkml.org/lkml/2007/1/4/161
I thought that had been merged. I'll chase it up tomorrow
On Thu, 17 Jan 2008, Andrew Morton wrote:
>
> There are thirteen regressions for which we have patches but they aren't
> merged. That seems rather high.
I think a number of them have been merged, or the thing that caused them
reverted. For example.
> > Subject : [2.6.24-rc6] pdflush still stuck in D state regression
> > Submitter : "Tvrtko A. Ursulin" <[email protected]>
> > Date : 2007-11-02 09:54
> > References : http://bugzilla.kernel.org/show_bug.cgi?id=9291
> > Handled-By : Dave Kleikamp <[email protected]>
> > Patch : http://bugzilla.kernel.org/attachment.cgi?id=14219&action=view
Isn't this the same write-back-related thing, reverted by
c23f72cae9523d29ff94eec8f30ccbdaf234b20e?
> > Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> > Submitter : Roland Dreier <[email protected]>
> > Date : 2007-11-08 14:55
> > References : http://lkml.org/lkml/2007/11/8/255
> > http://bugzilla.kernel.org/show_bug.cgi?id=9332
> > Handled-By : Takashi Iwai <[email protected]>
> > Ingo Molnar <[email protected]>
> > Patch : http://lkml.org/lkml/2007/11/16/66
This patch went in, but was reverted because it caused more problems than
it fixed. And what it "fixed" was somewhat dubious anyway.
> > Subject : jiffies counter leaps in 2.6.24-rc3
> > Submitter : Stefano Brivio <[email protected]>
> > Date : 2007-11-29 08:36
> > References : http://lkml.org/lkml/2007/11/24/53
> > http://bugzilla.kernel.org/show_bug.cgi?id=9475
> > Handled-By : Ingo Molnar <[email protected]>
> > Patch : http://lkml.org/lkml/2007/12/7/132
I think this is just the printk timestamp, no? And I think Ingo fixed it
differently.
> > Subject : PATA_HPT37X embezzles two ports
> > Submitter : "Bjoern Olausson" <[email protected]>
> > Date : 2007-12-12 11:05
> > References : http://lkml.org/lkml/2007/12/12/161
> > http://bugzilla.kernel.org/show_bug.cgi?id=9551
> > Handled-By : Alan Cox <[email protected]>
> > Patch : http://lkml.org/lkml/2007/1/4/161
Fixed by commit 73946f9fc5be1433f1e182d11303188390ff242f, afaik.
Linus
* Linus Torvalds <[email protected]> wrote:
> > > Subject : jiffies counter leaps in 2.6.24-rc3
> > > Submitter : Stefano Brivio <[email protected]>
> > > Date : 2007-11-29 08:36
> > > References : http://lkml.org/lkml/2007/11/24/53
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9475
> > > Handled-By : Ingo Molnar <[email protected]>
> > > Patch : http://lkml.org/lkml/2007/12/7/132
>
> I think this is just the printk timestamp, no? And I think Ingo fixed
> it differently.
yes. Stefano said the b43 driver is OK. The full fix is queued up for
2.6.25. (it involved changing printk.c, etc., which didnt seem warranted
- especially since the use of sched_clock() by printk was already quite
incorrect.)
Ingo
On Thu, 2008-01-17 at 16:18 -0800, Linus Torvalds wrote:
>
> On Thu, 17 Jan 2008, Andrew Morton wrote:
> >
> > There are thirteen regressions for which we have patches but they aren't
> > merged. That seems rather high.
>
> I think a number of them have been merged, or the thing that caused them
> reverted. For example.
>
> > > Subject : [2.6.24-rc6] pdflush still stuck in D state regression
> > > Submitter : "Tvrtko A. Ursulin" <[email protected]>
> > > Date : 2007-11-02 09:54
> > > References : http://bugzilla.kernel.org/show_bug.cgi?id=9291
> > > Handled-By : Dave Kleikamp <[email protected]>
> > > Patch : http://bugzilla.kernel.org/attachment.cgi?id=14219&action=view
>
> Isn't this the same write-back-related thing, reverted by
> c23f72cae9523d29ff94eec8f30ccbdaf234b20e?
The bug originally described a problem on reiserfs, which I believe is
fixed. A second problem was found on jfs, which probably should have
resulted in a new bug being opened. The jfs patch is not in mainline
yet. There are 3 jfs bug fixes ready for mainline in:
git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6.git
for-linus
Alternately, you could pull just
29a424f28390752a4ca2349633aaacc6be494db5 from that tree. (Can you do
this without a tag?) It is the first unmerged patch in the tree.
Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center
On Friday, 18 of January 2008, Linus Torvalds wrote:
>
> On Thu, 17 Jan 2008, Andrew Morton wrote:
> >
> > There are thirteen regressions for which we have patches but they aren't
> > merged. That seems rather high.
>
> I think a number of them have been merged, or the thing that caused them
> reverted. For example.
>
> > > Subject : [2.6.24-rc6] pdflush still stuck in D state regression
> > > Submitter : "Tvrtko A. Ursulin" <[email protected]>
> > > Date : 2007-11-02 09:54
> > > References : http://bugzilla.kernel.org/show_bug.cgi?id=9291
> > > Handled-By : Dave Kleikamp <[email protected]>
> > > Patch : http://bugzilla.kernel.org/attachment.cgi?id=14219&action=view
>
> Isn't this the same write-back-related thing, reverted by
> c23f72cae9523d29ff94eec8f30ccbdaf234b20e?
This patch is certainly different. It's against JFS only and that one was
generic (and from a different author, btw).
> > > Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> > > Submitter : Roland Dreier <[email protected]>
> > > Date : 2007-11-08 14:55
> > > References : http://lkml.org/lkml/2007/11/8/255
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9332
> > > Handled-By : Takashi Iwai <[email protected]>
> > > Ingo Molnar <[email protected]>
> > > Patch : http://lkml.org/lkml/2007/11/16/66
>
> This patch went in, but was reverted because it caused more problems than
> it fixed. And what it "fixed" was somewhat dubious anyway.
It was reported to break suspend on one box, but Takashi wants it in, AFAICS,
as quite some time has been invested into figuring out what's going wrong in
that case.
> > > Subject : jiffies counter leaps in 2.6.24-rc3
> > > Submitter : Stefano Brivio <[email protected]>
> > > Date : 2007-11-29 08:36
> > > References : http://lkml.org/lkml/2007/11/24/53
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9475
> > > Handled-By : Ingo Molnar <[email protected]>
> > > Patch : http://lkml.org/lkml/2007/12/7/132
>
> I think this is just the printk timestamp, no? And I think Ingo fixed it
> differently.
Explained by Ingo.
> > > Subject : PATA_HPT37X embezzles two ports
> > > Submitter : "Bjoern Olausson" <[email protected]>
> > > Date : 2007-12-12 11:05
> > > References : http://lkml.org/lkml/2007/12/12/161
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9551
> > > Handled-By : Alan Cox <[email protected]>
> > > Patch : http://lkml.org/lkml/2007/1/4/161
>
> Fixed by commit 73946f9fc5be1433f1e182d11303188390ff242f, afaik.
Well, I'm not sure. the commit is from November 5 and the patch is from
January 4. Also, the mscreg change is missing from the commit.
Greetings,
Rafael
* Rafael J. Wysocki <[email protected]> wrote:
> > > > Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> > > > Submitter : Roland Dreier <[email protected]>
> > > > Date : 2007-11-08 14:55
> > > > References : http://lkml.org/lkml/2007/11/8/255
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=9332
> > > > Handled-By : Takashi Iwai <[email protected]>
> > > > Ingo Molnar <[email protected]>
> > > > Patch : http://lkml.org/lkml/2007/11/16/66
> >
> > This patch went in, but was reverted because it caused more problems than
> > it fixed. And what it "fixed" was somewhat dubious anyway.
>
> It was reported to break suspend on one box, but Takashi wants it in,
> AFAICS, as quite some time has been invested into figuring out what's
> going wrong in that case.
since this is about a weird, not fully understood hardware interfacing
and timing problem, and because my original fix was not really a
regression fix (but it indeed _caused_ a real regression in a previously
working setup), i'd lean towards just reverting my patch in .24 and
going with Takashi's fixes in .25. I.e. the current -git status quo.
Ingo
On Friday, 18 of January 2008, Ingo Molnar wrote:
>
> * Rafael J. Wysocki <[email protected]> wrote:
>
> > > > > Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> > > > > Submitter : Roland Dreier <[email protected]>
> > > > > Date : 2007-11-08 14:55
> > > > > References : http://lkml.org/lkml/2007/11/8/255
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=9332
> > > > > Handled-By : Takashi Iwai <[email protected]>
> > > > > Ingo Molnar <[email protected]>
> > > > > Patch : http://lkml.org/lkml/2007/11/16/66
> > >
> > > This patch went in, but was reverted because it caused more problems than
> > > it fixed. And what it "fixed" was somewhat dubious anyway.
> >
> > It was reported to break suspend on one box, but Takashi wants it in,
> > AFAICS, as quite some time has been invested into figuring out what's
> > going wrong in that case.
>
> since this is about a weird, not fully understood hardware interfacing
> and timing problem, and because my original fix was not really a
> regression fix (but it indeed _caused_ a real regression in a previously
> working setup), i'd lean towards just reverting my patch in .24 and
> going with Takashi's fixes in .25. I.e. the current -git status quo.
Agreed.
Rafael
At Fri, 18 Jan 2008 15:10:08 +0100,
Rafael J. Wysocki wrote:
>
> On Friday, 18 of January 2008, Linus Torvalds wrote:
> >
> > On Thu, 17 Jan 2008, Andrew Morton wrote:
> > >
> > > > Subject : snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
> > > > Submitter : Roland Dreier <[email protected]>
> > > > Date : 2007-11-08 14:55
> > > > References : http://lkml.org/lkml/2007/11/8/255
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=9332
> > > > Handled-By : Takashi Iwai <[email protected]>
> > > > Ingo Molnar <[email protected]>
> > > > Patch : http://lkml.org/lkml/2007/11/16/66
> >
> > This patch went in, but was reverted because it caused more problems than
> > it fixed. And what it "fixed" was somewhat dubious anyway.
>
> It was reported to break suspend on one box, but Takashi wants it in, AFAICS,
> as quite some time has been invested into figuring out what's going wrong in
> that case.
Hm, I thought Ingo's patch fixed that case on the contrary...
Anyway, this patch is still on alsa.git, planned for 2.6.25, but with
additional workarounds for known problematic codecs and a bit more
robust timeout checks.
Takashi
x86 randconfig testing found the following build failure:
arch/x86/lguest/boot.c: In function 'lazy_hcall':
arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode'
arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function)
which i bisected down to this very fresh commit:
commit 84f7466ee20cc094aa38617abfa2f3834871f054
Author: Rusty Russell <[email protected]>
Date: Sat Jan 19 07:02:29 2008 +1100
Selecting LGUEST should turn on Guest support, as in 2.6.23.
which allows the following .config variation:
# CONFIG_PARAVIRT_GUEST is not set
CONFIG_LGUEST_GUEST=y
please revert that commit, or apply the fix below.
btw., i didnt even notice that patch because it is not visible on lkml,
etc.
NOTE: i found this problem this very minute so the patch below has not
been tested through yet (it does build and boot with the attached
config), but it seems obvious (to me).
Ingo
------------------->
Subject: x86: lguest fix
From: Ingo Molnar <[email protected]>
this commit:
commit 84f7466ee20cc094aa38617abfa2f3834871f054
Author: Rusty Russell <[email protected]>
Date: Sat Jan 19 07:02:29 2008 +1100
Selecting LGUEST should turn on Guest support, as in 2.6.23.
caused build failures due to allowing LGUEST to be selected without
paravirt support.
Signed-off-by: Ingo Molnar <[email protected]>
---
drivers/lguest/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/lguest/Kconfig
===================================================================
--- linux.orig/drivers/lguest/Kconfig
+++ linux/drivers/lguest/Kconfig
@@ -1,6 +1,6 @@
config LGUEST
tristate "Linux hypervisor example code"
- depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
+ depends on X86_32 && EXPERIMENTAL && PARAVIRT_GUEST && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
select HVC_DRIVER
select LGUEST_GUEST
---help---
On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote:
> x86 randconfig testing found the following build failure:
>
> arch/x86/lguest/boot.c: In function 'lazy_hcall':
> arch/x86/lguest/boot.c:151: error: implicit declaration of function
> 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error:
> 'PARAVIRT_LAZY_NONE' undeclared (first use in this function)
>
> which i bisected down to this very fresh commit:
>
> commit 84f7466ee20cc094aa38617abfa2f3834871f054
> Author: Rusty Russell <[email protected]>
> Date: Sat Jan 19 07:02:29 2008 +1100
>
> Selecting LGUEST should turn on Guest support, as in 2.6.23.
>
> which allows the following .config variation:
>
> # CONFIG_PARAVIRT_GUEST is not set
> CONFIG_LGUEST_GUEST=y
This looks like a "randconfig" bug, to be honest.
CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within "if PARAVIRT_GUEST" (include
is in arch/x86/Kconfig).
Rusty.
On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote:
> On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote:
> > x86 randconfig testing found the following build failure:
> >
> > arch/x86/lguest/boot.c: In function 'lazy_hcall':
> > arch/x86/lguest/boot.c:151: error: implicit declaration of function
> > 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error:
> > 'PARAVIRT_LAZY_NONE' undeclared (first use in this function)
> >
> > which i bisected down to this very fresh commit:
> >
> > commit 84f7466ee20cc094aa38617abfa2f3834871f054
> > Author: Rusty Russell <[email protected]>
> > Date: Sat Jan 19 07:02:29 2008 +1100
> >
> > Selecting LGUEST should turn on Guest support, as in 2.6.23.
> >
> > which allows the following .config variation:
> >
> > # CONFIG_PARAVIRT_GUEST is not set
> > CONFIG_LGUEST_GUEST=y
>
> This looks like a "randconfig" bug, to be honest.
>
> CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within "if PARAVIRT_GUEST" (include
> is in arch/x86/Kconfig).
According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic),
one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig.
And CONFIG_LGUEST (which selects CONFIG_LGUEST_GUEST) is in
drivers/lguest/Kconfig which gets included from drivers/kvm/Kconfig (sic)
which in turn gets included from drivers/Kconfig which in turn is not
within the "if PARAVIRT_GUEST".
Rusty, don't blame randconfig for finding bugs in this mess you
created...
> Rusty.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Sunday 20 January 2008 10:49:45 Adrian Bunk wrote:
> On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote:
> > On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote:
> > > # CONFIG_PARAVIRT_GUEST is not set
> > > CONFIG_LGUEST_GUEST=y
> >
> > This looks like a "randconfig" bug, to be honest.
>
> According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic),
> one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig.
>
> Rusty, don't blame randconfig for finding bugs in this mess you
> created...
My apologies, it is my mess. The one in drivers/lguest/Kconfig is the old
(bogus) one: looks like I lost the removal part in a patch merge back in
September.
I've tested this patch. It correctly handles Ingo's config (removes lguest
guest support). Both lguest and lguest guest support can be turned on
independently, and it still compiles.
How embarrassing,
Rusty.
---
Remove bogus duplicate CONFIG_LGUEST_GUEST entry.
It was moved to arch/x86/lguest/Kconfig, but I lost the deletion part in a
patch suffle. My confused one-liner "fix" to turn it on is also reverted:
84f7466ee20cc094aa38617abfa2f3834871f054
Signed-off-by: Rusty Russell <[email protected]>
diff -r 3db2cadc1a30 drivers/lguest/Kconfig
--- a/drivers/lguest/Kconfig Sun Jan 20 11:25:15 2008 +1100
+++ b/drivers/lguest/Kconfig Sun Jan 20 11:47:57 2008 +1100
@@ -2,7 +2,6 @@ config LGUEST
tristate "Linux hypervisor example code"
depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
select HVC_DRIVER
- select LGUEST_GUEST
---help---
This is a very simple module which allows you to run
multiple instances of the same Linux kernel, using the
@@ -11,9 +10,3 @@ config LGUEST
not "rustyvisor". See Documentation/lguest/lguest.txt.
If unsure, say N. If curious, say M. If masochistic, say Y.
-
-config LGUEST_GUEST
- bool
- help
- The guest needs code built-in, even if the host has lguest
- support as a module.