2008-02-28 01:06:55

by Harvey Harrison

Subject: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings

Fixes the following, repeated at every callsite, vortex->fixed_res is always
passed in this argument, the change to unsigned int won't change anything.

sound/pci/au88x0/au88x0_core.c:2047:54: warning: incorrect type in argument 2 (different signedness)
sound/pci/au88x0/au88x0_core.c:2047:54: expected int *resmap
sound/pci/au88x0/au88x0_core.c:2047:54: got unsigned int *<noident>

Signed-off-by: Harvey Harrison <[email protected]>
---
sound/pci/au88x0/au88x0.h | 4 ++--
sound/pci/au88x0/au88x0_core.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/au88x0/au88x0.h b/sound/pci/au88x0/au88x0.h
index 4aad35b..31e6899 100644
--- a/sound/pci/au88x0/au88x0.h
+++ b/sound/pci/au88x0/au88x0.h
@@ -242,8 +242,8 @@ static int vortex_alsafmt_aspfmt(int alsafmt);
static void vortex_connect_default(vortex_t * vortex, int en);
static int vortex_adb_allocroute(vortex_t * vortex, int dma, int nr_ch,
int dir, int type);
-static char vortex_adb_checkinout(vortex_t * vortex, int resmap[], int out,
- int restype);
+static char vortex_adb_checkinout(vortex_t * vortex, unsigned int resmap[],
+ int out, int restype);
#ifndef CHIP_AU8810
static int vortex_wt_allocroute(vortex_t * vortex, int dma, int nr_ch);
static void vortex_wt_connect(vortex_t * vortex, int en);
diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
index 333c62d..0ee8202 100644
--- a/sound/pci/au88x0/au88x0_core.c
+++ b/sound/pci/au88x0/au88x0_core.c
@@ -2000,7 +2000,7 @@ static int resnum[VORTEX_RESOURCE_LAST] =
restype: Indicates type of resource to be checked in or out.
*/
static char
-vortex_adb_checkinout(vortex_t * vortex, int resmap[], int out, int restype)
+vortex_adb_checkinout(vortex_t * vortex, unsigned int resmap[], int out, int restype)
{
int i, qty = resnum[restype], resinuse = 0;

--
1.5.4.3.342.g99e8

2008-02-28 11:11:18

by Takashi Iwai

Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings

> Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings

The patch overflow? ;-)

At Wed, 27 Feb 2008 17:06:43 -0800,
Harvey Harrison wrote:
>
> Fixes the following, repeated at every callsite, vortex->fixed_res is always
> passed in this argument, the change to unsigned int won't change anything.
>
> sound/pci/au88x0/au88x0_core.c:2047:54: warning: incorrect type in argument 2 (different signedness)
> sound/pci/au88x0/au88x0_core.c:2047:54: expected int *resmap
> sound/pci/au88x0/au88x0_core.c:2047:54: got unsigned int *<noident>

I thought this warning is rather a compiler issue. We had this with
some gcc version but it was suppressed as default in the end.

Fine to fix in the code as it's obviously correct, though.


thanks,

Takashi