2008-06-04 16:59:00

by David Woodhouse

[permalink] [raw]
Subject: Re: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to be copied to

On Mon, 2008-05-19 at 17:53 +0800, Bryan Wu wrote:
>
> >
> > I just noticed that write_sr contains a duplicated spi_write.
> > Bryan sends out a new patch.
> >
>
>
> No problem, it is my fault. I should review the patch carefully.

Was there a new patch coming?

--
dwmw2


2008-06-04 17:20:18

by Hennerich, Michael

[permalink] [raw]
Subject: RE: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to becopied to

David,

Bryan sent an incremental update patch, some time ago.
See below ...

Regards,
Michael

From: Michael Hennerich <[email protected]>

remove duplicate code.

Signed-off-by: Michael Hennerich <[email protected]>
Signed-off-by: Bryan Wu <[email protected]>
---
drivers/mtd/devices/m25p80.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index b10649b..7f89b54 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -122,8 +122,6 @@ static int write_sr(struct m25p *flash, u8 val)
flash->command[0] = OPCODE_WRSR;
flash->command[1] = val;

- spi_write(flash->spi, flash->command, 2);
-
return spi_write(flash->spi, flash->command, 2); }

--
1.5.5

>-----Original Message-----
>From: David Woodhouse [mailto:[email protected]]
>Sent: Mittwoch, 4. Juni 2008 18:59
>To: Bryan Wu
>Cc: Hennerich, Michael; [email protected]; linux-
>[email protected]; [email protected]
>Subject: Re: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to
>becopied to
>
>On Mon, 2008-05-19 at 17:53 +0800, Bryan Wu wrote:
>>
>> >
>> > I just noticed that write_sr contains a duplicated spi_write.
>> > Bryan sends out a new patch.
>> >
>>
>>
>> No problem, it is my fault. I should review the patch carefully.
>
>Was there a new patch coming?
>
>--
>dwmw2