2008-08-12 21:25:09

by Marcin Ślusarz

[permalink] [raw]
Subject: [PATCH] suspend: fix section mismatch warning - register_nosave_region

WARNING: vmlinux.o(.text+0xe684): Section mismatch in reference from the function register_nosave_region() to the function .init.text:__register_nosave_region()
The function register_nosave_region() references
the function __init __register_nosave_region().
This is often because register_nosave_region lacks a __init
annotation or the annotation of __register_nosave_region is wrong.

register_nosave_region calls __init function and is called only from __init functions

Signed-off-by: Marcin Slusarz <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Len Brown <[email protected]>
---
include/linux/suspend.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index c634350..2ce8207 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -217,11 +217,11 @@ struct platform_hibernation_ops {
#ifdef CONFIG_HIBERNATION
/* kernel/power/snapshot.c */
extern void __register_nosave_region(unsigned long b, unsigned long e, int km);
-static inline void register_nosave_region(unsigned long b, unsigned long e)
+static inline void __init register_nosave_region(unsigned long b, unsigned long e)
{
__register_nosave_region(b, e, 0);
}
-static inline void register_nosave_region_late(unsigned long b, unsigned long e)
+static inline void __init register_nosave_region_late(unsigned long b, unsigned long e)
{
__register_nosave_region(b, e, 1);
}
--
1.5.4.5


2008-08-12 21:46:40

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] suspend: fix section mismatch warning - register_nosave_region

On Tuesday, 12 of August 2008, Marcin Slusarz wrote:
> WARNING: vmlinux.o(.text+0xe684): Section mismatch in reference from the function register_nosave_region() to the function .init.text:__register_nosave_region()
> The function register_nosave_region() references
> the function __init __register_nosave_region().
> This is often because register_nosave_region lacks a __init
> annotation or the annotation of __register_nosave_region is wrong.
>
> register_nosave_region calls __init function and is called only from __init functions
>
> Signed-off-by: Marcin Slusarz <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Len Brown <[email protected]>

Acked-by: Rafael J. Wysocki <[email protected]>

> ---
> include/linux/suspend.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index c634350..2ce8207 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -217,11 +217,11 @@ struct platform_hibernation_ops {
> #ifdef CONFIG_HIBERNATION
> /* kernel/power/snapshot.c */
> extern void __register_nosave_region(unsigned long b, unsigned long e, int km);
> -static inline void register_nosave_region(unsigned long b, unsigned long e)
> +static inline void __init register_nosave_region(unsigned long b, unsigned long e)
> {
> __register_nosave_region(b, e, 0);
> }
> -static inline void register_nosave_region_late(unsigned long b, unsigned long e)
> +static inline void __init register_nosave_region_late(unsigned long b, unsigned long e)
> {
> __register_nosave_region(b, e, 1);
> }

2008-08-13 07:48:00

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] suspend: fix section mismatch warning - register_nosave_region

On Tue 2008-08-12 23:23:06, Marcin Slusarz wrote:
> WARNING: vmlinux.o(.text+0xe684): Section mismatch in reference from the function register_nosave_region() to the function .init.text:__register_nosave_region()
> The function register_nosave_region() references
> the function __init __register_nosave_region().
> This is often because register_nosave_region lacks a __init
> annotation or the annotation of __register_nosave_region is wrong.
>
> register_nosave_region calls __init function and is called only from __init functions
>
> Signed-off-by: Marcin Slusarz <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>

Acked-by: Pavel Machek <[email protected]>
> Cc: Len Brown <[email protected]>

You probably want to send it to akpm and/or Andi Kleen: Len is on
holidays.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html