2008-08-18 20:38:20

by Harvey Harrison

[permalink] [raw]
Subject: [PATCH 1/2] byteorder: add new headers for make headers-install

Signed-off-by: Harvey Harrison <[email protected]>
---
Andrew, two fixes before the arches start moving over.

include/linux/Kbuild | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 7d97067..0ffee42 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -179,6 +179,7 @@ unifdef-y += audit.h
unifdef-y += auto_fs.h
unifdef-y += auxvec.h
unifdef-y += binfmts.h
+unifdef-y += byteorder.h
unifdef-y += capability.h
unifdef-y += capi.h
unifdef-y += cciss_ioctl.h
@@ -335,6 +336,7 @@ unifdef-y += soundcard.h
unifdef-y += stat.h
unifdef-y += stddef.h
unifdef-y += string.h
+unifdef-y += swab.h
unifdef-y += synclink.h
unifdef-y += sysctl.h
unifdef-y += tcp.h
--
1.6.0.274.g8aacc


2008-08-20 14:11:17

by David Woodhouse

[permalink] [raw]
Subject: Re: [PATCH 1/2] byteorder: add new headers for make headers-install

On Mon, 2008-08-18 at 13:38 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> Andrew, two fixes before the arches start moving over.

We don't expose cpu_to_le32() et al., do we? Only __cpu_to_le32() and
similar? Which exported headers use these -- and are they actually using
the __ versions? If not, they're not going to work anyway, are they?

--
David Woodhouse Open Source Technology Centre
[email protected] Intel Corporation


2008-08-20 17:13:27

by Harvey Harrison

[permalink] [raw]
Subject: Re: [PATCH 1/2] byteorder: add new headers for make headers-install

On Wed, 2008-08-20 at 15:10 +0100, David Woodhouse wrote:
> On Mon, 2008-08-18 at 13:38 -0700, Harvey Harrison wrote:
> > Signed-off-by: Harvey Harrison <[email protected]>
> > ---
> > Andrew, two fixes before the arches start moving over.
>
> We don't expose cpu_to_le32() et al., do we? Only __cpu_to_le32() and
> similar? Which exported headers use these -- and are they actually using
> the __ versions? If not, they're not going to work anyway, are they?
>

Correct, the cpu_to_le32(), etc are wrapped in #ifdef KERNEL, but this adds
the export for the two new headers that will replace the byteorder/*.h
implementation.

Once each arch has moved over, include/linux/byteorder/* will go away.

Cheers,

Harvey