Subject: [PATCH] AC97: Print AC97 flags in proc file to make debug it easier

While debugging some code paths in AC97 codec patches and its suspend
and resume functions, getting to know the flags has proved useful to
follow those code paths.

Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
---
sound/pci/ac97/ac97_proc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
index 060ea59..73b17d5 100644
--- a/sound/pci/ac97/ac97_proc.c
+++ b/sound/pci/ac97/ac97_proc.c
@@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n",
ac97->subsystem_device);

+ snd_iprintf(buffer, "Flags: %x\n", ac97->flags);
+
if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) {
val = snd_ac97_read(ac97, AC97_INT_PAGING);
snd_ac97_update_bits(ac97, AC97_INT_PAGING,
--
1.6.0.6


2009-01-29 08:07:26

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] AC97: Print AC97 flags in proc file to make debug it easier

At Wed, 28 Jan 2009 15:39:22 -0200,
Thadeu Lima de Souza Cascardo wrote:
>
> While debugging some code paths in AC97 codec patches and its suspend
> and resume functions, getting to know the flags has proved useful to
> follow those code paths.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>

Applied. Thanks.


Takashi

> ---
> sound/pci/ac97/ac97_proc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
> index 060ea59..73b17d5 100644
> --- a/sound/pci/ac97/ac97_proc.c
> +++ b/sound/pci/ac97/ac97_proc.c
> @@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
> snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n",
> ac97->subsystem_device);
>
> + snd_iprintf(buffer, "Flags: %x\n", ac97->flags);
> +
> if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) {
> val = snd_ac97_read(ac97, AC97_INT_PAGING);
> snd_ac97_update_bits(ac97, AC97_INT_PAGING,
> --
> 1.6.0.6
>