On Tue, Jan 23, 2024 at 06:40:19PM -0600, Elizabeth Figura wrote:
> == Patches ==
>
> This is the first part of a 32-patch series. The series comprises 17 patches
> which contain the actual implementation, 13 which provide self-tests, 1 to
> update the MAINTAINERS file, and 1 to add API documentation.
32 patches? I only see 9 here, why not submit them all?
> The intended semantics of the patches are broadly intended to match those of the
> corresponding Windows functions. Since I do not expect familiarity with Windows
> syscalls, however, and especially not with some of the more subtle or
> unspecified behaviour that they provide, the documentation patch included in the
> series also describes the intended behaviour in detail, and can be used as a
> specification for the rest of the series.
>
> The entire series can be retrieved or browsed here:
>
> https://repo.or.cz/linux/zf.git/shortlog/refs/heads/ntsync4
No one is going to dig elsewhere for kernel changes, sorry. Please
submit them in email for review, that's the only way we can look at them
and comment.
thanks,
greg k-h
On Tuesday, 23 January 2024 18:59:35 CST Greg Kroah-Hartman wrote:
> On Tue, Jan 23, 2024 at 06:40:19PM -0600, Elizabeth Figura wrote:
> > == Patches ==
> >
> > This is the first part of a 32-patch series. The series comprises 17 patches
> > which contain the actual implementation, 13 which provide self-tests, 1 to
> > update the MAINTAINERS file, and 1 to add API documentation.
>
> 32 patches? I only see 9 here, why not submit them all?
Because Documentation/process/submitting-patches.rst makes a point of asking people not to submit large patch series (and it matches the expectation of other projects I've worked with—that patches would be submitted and reviewed a few at a time). I suppose I've misunderstood that advice, though.
I'll resend with the entire series. Sorry for the noise.
On Tue, Jan 23, 2024 at 07:37:01PM -0600, Elizabeth Figura wrote:
> On Tuesday, 23 January 2024 18:59:35 CST Greg Kroah-Hartman wrote:
> > On Tue, Jan 23, 2024 at 06:40:19PM -0600, Elizabeth Figura wrote:
> > > == Patches ==
> > >
> > > This is the first part of a 32-patch series. The series comprises 17 patches
> > > which contain the actual implementation, 13 which provide self-tests, 1 to
> > > update the MAINTAINERS file, and 1 to add API documentation.
> >
> > 32 patches? I only see 9 here, why not submit them all?
>
> Because Documentation/process/submitting-patches.rst makes a point of asking people not to submit large patch series (and it matches the expectation of other projects I've worked with—that patches would be submitted and reviewed a few at a time). I suppose I've misunderstood that advice, though.
32 patches isn't all that "large", we can handle that easily :)
100+ patches is large, I guess it all depends, so I can understand the
confusion. You need to send us enough for us to be able to understand
and review the code, this was a bit short for that.
> I'll resend with the entire series. Sorry for the noise.
Ptches are NOT noise, we want to see them!
thanks,
greg k-h