On Thu, 2009-04-09 at 10:05 -0700, Kay Sievers wrote:
> On Thu, Apr 9, 2009 at 09:57, Andrew Patterson <[email protected]> wrote:
> > On Thu, 2009-04-09 at 07:19 -0700, Kay Sievers wrote:
>
> >> I would need to see the output of:
> >> /sbin/udevadm info --attribute-walk --path=/block/<disk-name>
>
> > looking at device '/block/cciss!c0d0':
> > KERNEL=="cciss!c0d0"
> > SUBSYSTEM=="block"
> > DRIVER==""
> > ATTR{range}=="16"
> > ATTR{ext_range}=="16"
> > ATTR{removable}=="0"
> > ATTR{ro}=="0"
> > ATTR{size}=="286611840"
> > ATTR{capability}=="10"
>
> The block device needs a parent, please assign the cciss bus device.
> It's the driverfs_dev in the genhd struct.
>
This is already done in cciss_add_disk():
disk->fops = &cciss_fops;
disk->private_data = &h->drv[drv_index];
disk->driverfs_dev = &h->drv[drv_index].dev;
I think my problem is I was assigning cciss_bus_type to the controller,
not the block device. I have fixed that.
> Please provide the output again, it will get much larger then.
>
> Also, please disable CONFIG_SYSFS_DEPRECATED* in your kernel config.
>
Done.
# /sbin/udevadm info --attribute-walk "--path=/block/cciss!c0d0"
Udevinfo starts with the device specified by the devpath and then
walks up the chain of parent devices. It prints for every device
found, all possible attributes in the udev rules key format.
A rule to match, can be composed by the attributes of the device
and the attributes from one single parent device.
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0/c0d0/block/cciss!c0d0':
KERNEL=="cciss!c0d0"
SUBSYSTEM=="block"
DRIVER==""
ATTR{range}=="16"
ATTR{ext_range}=="16"
ATTR{removable}=="0"
ATTR{ro}=="0"
ATTR{size}=="286611840"
ATTR{capability}=="10"
ATTR{stat}==" 29 37 2112 52 0 0
0 0 0 52 52"
looking at parent device
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0/c0d0':
KERNELS=="c0d0"
SUBSYSTEMS=="cciss"
DRIVERS==""
ATTRS{unique_id}=="600508B1001044424654324558350012"
ATTRS{model}=="LOGICAL VOLUME "
ATTRS{vendor}=="HP "
ATTRS{rev}=="5.20"
looking at parent device
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0':
KERNELS=="cciss0"
SUBSYSTEMS==""
DRIVERS==""
looking at parent device
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0':
KERNELS=="0000:8b:00.0"
SUBSYSTEMS=="pci"
DRIVERS=="cciss"
ATTRS{vendor}=="0x103c"
ATTRS{device}=="0x3230"
ATTRS{subsystem_vendor}=="0x103c"
ATTRS{subsystem_device}=="0x3223"
ATTRS{class}=="0x010400"
ATTRS{irq}=="67"
ATTRS{local_cpus}=="ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff"
ATTRS{local_cpulist}=="0-511"
ATTRS{modalias}=="pci:v0000103Cd00003230sv0000103Csd00003223bc01sc04i00"
ATTRS{numa_node}=="-1"
ATTRS{broken_parity_status}=="0"
ATTRS{msi_bus}==""
looking at parent device
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0':
KERNELS=="0000:51:04.0"
SUBSYSTEMS=="pci"
DRIVERS=="pcieport-driver"
ATTRS{vendor}=="0x111d"
ATTRS{device}=="0x801c"
ATTRS{subsystem_vendor}=="0x0000"
ATTRS{subsystem_device}=="0x0000"
ATTRS{class}=="0x060400"
ATTRS{irq}=="53"
ATTRS{local_cpus}=="ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff"
ATTRS{local_cpulist}=="0-511"
ATTRS{modalias}=="pci:v0000111Dd0000801Csv00000000sd00000000bc06sc04i00"
ATTRS{numa_node}=="-1"
ATTRS{broken_parity_status}=="0"
ATTRS{msi_bus}=="1"
looking at parent device
'/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0':
KERNELS=="0000:50:00.0"
SUBSYSTEMS=="pci"
DRIVERS=="pcieport-driver"
ATTRS{vendor}=="0x111d"
ATTRS{device}=="0x801c"
ATTRS{subsystem_vendor}=="0x0000"
ATTRS{subsystem_device}=="0x0000"
ATTRS{class}=="0x060400"
ATTRS{irq}=="0"
ATTRS{local_cpus}=="ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff"
ATTRS{local_cpulist}=="0-511"
ATTRS{modalias}=="pci:v0000111Dd0000801Csv00000000sd00000000bc06sc04i00"
ATTRS{numa_node}=="-1"
ATTRS{broken_parity_status}=="0"
ATTRS{msi_bus}=="1"
looking at parent device '/devices/pci0000:4f/0000:4f:00.0':
KERNELS=="0000:4f:00.0"
SUBSYSTEMS=="pci"
DRIVERS=="pcieport-driver"
ATTRS{vendor}=="0x103c"
ATTRS{device}=="0x403b"
ATTRS{subsystem_vendor}=="0x0000"
ATTRS{subsystem_device}=="0x0000"
ATTRS{class}=="0x060400"
ATTRS{irq}=="51"
ATTRS{local_cpus}=="ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff"
ATTRS{local_cpulist}=="0-511"
ATTRS{modalias}=="pci:v0000103Cd0000403Bsv00000000sd00000000bc06sc04i00"
ATTRS{numa_node}=="-1"
ATTRS{broken_parity_status}=="0"
ATTRS{msi_bus}=="1"
looking at parent device '/devices/pci0000:4f':
KERNELS=="pci0000:4f"
SUBSYSTEMS==""
DRIVERS==""
> Thanks,
> Kay
Thanks for looking at this.
Andrew
On Thu, Apr 9, 2009 at 11:07, Andrew Patterson <[email protected]> wrote:
> On Thu, 2009-04-09 at 10:05 -0700, Kay Sievers wrote:
>> The block device needs a parent, please assign the cciss bus device.
>> It's the driverfs_dev in the genhd struct.
>>
>
> This is already done in cciss_add_disk():
>
> disk->fops = &cciss_fops;
> disk->private_data = &h->drv[drv_index];
> disk->driverfs_dev = &h->drv[drv_index].dev;
>
> I think my problem is I was assigning cciss_bus_type to the controller,
> not the block device. I have fixed that.
> # /sbin/udevadm info --attribute-walk "--path=/block/cciss!c0d0"
> looking at parent device
> '/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0':
> KERNELS=="cciss0"
> SUBSYSTEMS==""
This device also needs the cciss bus_type assigned, so the subsystem
becomes cciss, and it also shows up in /sys/bus/cciss/devices/.
Other than that, the sysfs hierarchy looks fine.
Thanks,
Kay