LinuxLists.cc - [PATCH] arm64: meson: ship only the necessary clock controllers

2020-10-20 10:04:12

Subject: [PATCH] arm64: meson: ship only the necessary clock controllers

There now the menu entries for the amlogic clock controllers.
Do not select these when ARM64 is enabled so it possible to ship only the
required.

Signed-off-by: Jerome Brunet <[email protected]>
---
arch/arm64/Kconfig.platforms | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index cd58f8495c45..b22d1bdd6eb6 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -154,9 +154,6 @@ config ARCH_MESON
bool "Amlogic Platforms"
select PINCTRL
select PINCTRL_MESON
- select COMMON_CLK_GXBB
- select COMMON_CLK_AXG
- select COMMON_CLK_G12A
select MESON_IRQ_GPIO
help
This enables support for the arm64 based Amlogic SoCs
--
2.25.4

2020-10-20 13:16:55

by Neil Armstrong

[permalink] [raw]

Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers

On 20/10/2020 09:50, Jerome Brunet wrote:
> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
> arch/arm64/Kconfig.platforms | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
> bool "Amlogic Platforms"
> select PINCTRL
> select PINCTRL_MESON
> - select COMMON_CLK_GXBB
> - select COMMON_CLK_AXG
> - select COMMON_CLK_G12A
> select MESON_IRQ_GPIO
> help
> This enables support for the arm64 based Amlogic SoCs
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-10-21 06:27:56

by Jerome Brunet

[permalink] [raw]

Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers

On Tue 20 Oct 2020 at 17:03, Kevin Hilman <[email protected]> wrote:

> Jerome Brunet <[email protected]> writes:
>
>> There now the menu entries for the amlogic clock controllers.
>> Do not select these when ARM64 is enabled so it possible to ship only the
>> required.
>>
>> Signed-off-by: Jerome Brunet <[email protected]>
>> ---
>> arch/arm64/Kconfig.platforms | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index cd58f8495c45..b22d1bdd6eb6 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -154,9 +154,6 @@ config ARCH_MESON
>> bool "Amlogic Platforms"
>> select PINCTRL
>> select PINCTRL_MESON
>> - select COMMON_CLK_GXBB
>> - select COMMON_CLK_AXG
>> - select COMMON_CLK_G12A
>
> This patch alone will break boot when using the default, upstream
> defconfig because these options will all now be disabled and we'll have
> no clock providers.
>
> I think you also need a default value (e.g. `default y`) in
> drivers/clk/meson/Kconfig for each of these entries to keep the same
> defaults. But these defaults could be overridden by SoC-specific
> defconfigs leading to more flexibilty.
>
> So, assuming you queue up a drivers/clk patch to go in when this
> lands...

Indeed.
Please wait till the clock PR lands during the merge window, you'll see
that it is already taken care of.

I was not expecting you to look at it so soon ;)

>
> Acked-by: Kevin Hilman <[email protected]>

2020-10-21 08:14:03

by Kevin Hilman

[permalink] [raw]

Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers

Jerome Brunet <[email protected]> writes:

> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
> arch/arm64/Kconfig.platforms | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
> bool "Amlogic Platforms"
> select PINCTRL
> select PINCTRL_MESON
> - select COMMON_CLK_GXBB
> - select COMMON_CLK_AXG
> - select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream
defconfig because these options will all now be disabled and we'll have
no clock providers.

I think you also need a default value (e.g. `default y`) in
drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults. But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this
lands...

Acked-by: Kevin Hilman <[email protected]>

2020-11-09 23:25:42

by Kevin Hilman

[permalink] [raw]

Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers

On Tue, 20 Oct 2020 09:50:34 +0200, Jerome Brunet wrote:
> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.

Applied, thanks!

[1/1] arm64: meson: ship only the necessary clock controllers
(no commit info)

Best regards,
--
Kevin Hilman <[email protected]>

2020-11-20 19:15:05

by Kevin Hilman

[permalink] [raw]