2009-09-18 17:04:49

by Peter Zijlstra

Subject: Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree_plugin.h

On Fri, 2009-09-18 at 10:03 -0700, Daniel Walker wrote:

> > > ERROR: code indent should use tabs where possible
> > > #149: FILE: kernel/rcutree_plugin.h:120:
> > > +^I ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$
> > >
> > >
> > > One funny indent in the line above.. If your intending for Ingo to take
> > > this he might just fix it on apply ..
> >
> > Daniel, seriously, get a new hobby.
>
>
> I don't get why your so annoyed ..

If we thought a checkpatch bot was a good idea, we'd have asked the list
admins for one.

2009-09-18 17:08:21

by Daniel Walker

Subject: Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree_plugin.h

On Fri, 2009-09-18 at 19:04 +0200, Peter Zijlstra wrote:
> On Fri, 2009-09-18 at 10:03 -0700, Daniel Walker wrote:
>
> > > > ERROR: code indent should use tabs where possible
> > > > #149: FILE: kernel/rcutree_plugin.h:120:
> > > > +^I ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$
> > > >
> > > >
> > > > One funny indent in the line above.. If your intending for Ingo to take
> > > > this he might just fix it on apply ..
> > >
> > > Daniel, seriously, get a new hobby.
> >
> >
> > I don't get why your so annoyed ..
>
> If we thought a checkpatch bot was a good idea, we'd have asked the list
> admins for one.


Who is "we" in the sentence above?

Daniel