2010-02-20 11:53:11

by Graham M Howe

Subject: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<[email protected]>

---
drivers/staging/comedi/drivers/ni_670x.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index fc5f90f..352b917 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
{
printk("comedi%d: ni_670x: remove\n", dev->minor);

- if (dev->subdevices[0].range_table_list)
- kfree(dev->subdevices[0].range_table_list);

if (dev->private && devpriv->mite)
mite_unsetup(devpriv->mite);
--
1.6.3.3

2010-02-26 00:13:42

by Greg KH

Subject: Re: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<[email protected]>

The subject doesn't match what the patch did :(

On Sat, Feb 20, 2010 at 11:53:01AM +0000, Graham M Howe wrote:
> ---
> drivers/staging/comedi/drivers/ni_670x.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
> index fc5f90f..352b917 100644
> --- a/drivers/staging/comedi/drivers/ni_670x.c
> +++ b/drivers/staging/comedi/drivers/ni_670x.c
> @@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
> {
> printk("comedi%d: ni_670x: remove\n", dev->minor);
>
> - if (dev->subdevices[0].range_table_list)
> - kfree(dev->subdevices[0].range_table_list);

You can't just not free the memory :(

greg k-h