2010-08-06 00:07:52

by Axel Lin

Subject: [PATCH 1/2 RESEND] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()

We already check count value before calling i2c_smbus_read_byte_data(),
no need to check it again.

Signed-off-by: Axel Lin <[email protected]>
Acked-by: Mark Brown <[email protected]>
---
This resend adds regulator: prefix in the subject line.

drivers/regulator/lp3971.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index d4d9822..3bb82b6 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
if (count != 1)
return -EIO;
ret = i2c_smbus_read_byte_data(i2c, reg);
- if (ret < 0 || count != 1)
+ if (ret < 0)
return -EIO;

*dest = ret;
--
1.5.4.3

2010-08-09 08:23:37

by Liam Girdwood

Subject: Re: [PATCH 1/2 RESEND] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()

On Fri, 2010-08-06 at 08:09 +0800, Axel Lin wrote:
> We already check count value before calling i2c_smbus_read_byte_data(),
> no need to check it again.
>
> Signed-off-by: Axel Lin <[email protected]>
> Acked-by: Mark Brown <[email protected]>
> ---
> This resend adds regulator: prefix in the subject line.
>
> drivers/regulator/lp3971.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
> index d4d9822..3bb82b6 100644
> --- a/drivers/regulator/lp3971.c
> +++ b/drivers/regulator/lp3971.c
> @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
> if (count != 1)
> return -EIO;
> ret = i2c_smbus_read_byte_data(i2c, reg);
> - if (ret < 0 || count != 1)
> + if (ret < 0)
> return -EIO;
>
> *dest = ret;

Applied 1/2 only as 2/2 is the same patch.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-08-09 08:59:39

by Axel Lin

Subject: Re: [PATCH 1/2 RESEND] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()

2010/8/9 Liam Girdwood <[email protected]>:
> On Fri, 2010-08-06 at 08:09 +0800, Axel Lin wrote:
>> We already check count value before calling i2c_smbus_read_byte_data(),
>> no need to check it again.
>>
>> Signed-off-by: Axel Lin <[email protected]>
>> Acked-by: Mark Brown <[email protected]>
>> ---
>> This resend adds regulator: prefix in the subject line.
>>
>> ?drivers/regulator/lp3971.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
>> index d4d9822..3bb82b6 100644
>> --- a/drivers/regulator/lp3971.c
>> +++ b/drivers/regulator/lp3971.c
>> @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
>> ? ? ? if (count != 1)
>> ? ? ? ? ? ? ? return -EIO;
>> ? ? ? ret = i2c_smbus_read_byte_data(i2c, reg);
>> - ? ? if (ret < 0 || count != 1)
>> + ? ? if (ret < 0)
>> ? ? ? ? ? ? ? return -EIO;
>>
>> ? ? ? *dest = ret;
>
> Applied 1/2 only as 2/2 is the same patch.
Ooops. My bad. I copied the same patch for patch 1/2 and 1/2.
I'll resend it now.
patch tiltle: [PATCH RESEND again] regulator: lp3971 - remove
unnecessary ret value checking in lp3971_i2c_write()

Regards,
Axel