2010-11-04 17:29:23

by Randy Dunlap

Subject: [PATCH] leds-net5501: taints kernel, add license

From: Randy Dunlap <[email protected]>

Add MODULE_LICENSE() that matches file comments so that kernel
is not tainted.

leds_net5501: module license 'unspecified' taints kernel.

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/leds/leds-net5501.c | 2 ++
1 file changed, 2 insertions(+)

Alessandro, why does this module not have a module_exit() function?
I.e., why can it not be unloaded?


--- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
+++ lnx-2637-rc1/drivers/leds/leds-net5501.c
@@ -92,3 +92,5 @@ unmap:
}

arch_initcall(soekris_init);
+
+MODULE_LICENSE("GPL");

2010-11-05 13:53:49

by Richard Purdie

Subject: Re: [PATCH] leds-net5501: taints kernel, add license

On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
>
> leds_net5501: module license 'unspecified' taints kernel.
>
> Signed-off-by: Randy Dunlap <[email protected]>

Acked-by: Richard Purdie <[email protected]>

> ---
> drivers/leds/leds-net5501.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>
>
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
> }
>
> arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
>

2010-11-05 21:34:57

by Alessandro Zummo

Subject: Re: [PATCH] leds-net5501: taints kernel, add license

On Thu, 4 Nov 2010 10:28:00 -0700
Randy Dunlap <[email protected]> wrote:

> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>

I believe there's no particular reason.
Bjarke Istrup Pedersen is taking care of this code (CCd).

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it