LinuxLists.cc - [PATCH 1/4] lockdep: fix common misspellings

2011-03-18 13:40:53

Subject: [PATCH 1/4] lockdep: fix common misspellings

They were generated by 'codespell' and then manually reviewed.

Signed-off-by: Lucas De Marchi <[email protected]>
---
kernel/lockdep.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 0d2058d..53a6895 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2309,7 +2309,7 @@ void trace_hardirqs_on_caller(unsigned long ip)
if (unlikely(curr->hardirqs_enabled)) {
/*
* Neither irq nor preemption are disabled here
- * so this is racy by nature but loosing one hit
+ * so this is racy by nature but losing one hit
* in a stat is not a big deal.
*/
__debug_atomic_inc(redundant_hardirqs_on);
@@ -2620,7 +2620,7 @@ static int mark_lock(struct task_struct *curr, struct held_lock *this,
if (!graph_lock())
return 0;
/*
- * Make sure we didnt race:
+ * Make sure we didn't race:
*/
if (unlikely(hlock_class(this)->usage_mask & new_mask)) {
graph_unlock();
--
1.7.4.1

2011-03-18 13:41:03

by Lucas De Marchi

[permalink] [raw]

Subject: [PATCH 3/4] sched: fix common misspellings

They were generated by 'codespell' and then manually reviewed.

Signed-off-by: Lucas De Marchi <[email protected]>
---
include/linux/sched.h | 2 +-
kernel/sched.c | 6 +++---
kernel/sched_autogroup.c | 2 +-
kernel/sched_fair.c | 2 +-
kernel/sched_rt.c | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index c15936f..9bd74f5 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -853,7 +853,7 @@ extern int __weak arch_sd_sibiling_asym_packing(void);

/*
* Optimise SD flags for power savings:
- * SD_BALANCE_NEWIDLE helps agressive task consolidation and power savings.
+ * SD_BALANCE_NEWIDLE helps aggressive task consolidation and power savings.
* Keep default SD flags if sched_{smt,mc}_power_saving=0
*/

diff --git a/kernel/sched.c b/kernel/sched.c
index 58d66ea..e53f7bd 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2310,7 +2310,7 @@ unsigned long wait_task_inactive(struct task_struct *p, long match_state)
* Cause a process which is running on another CPU to enter
* kernel-mode, without any delay. (to get signals handled.)
*
- * NOTE: this function doesnt have to take the runqueue lock,
+ * NOTE: this function doesn't have to take the runqueue lock,
* because all it wants to ensure is that the remote task enters
* the kernel. If the IPI races and the task has been migrated
* to another CPU then no harm is done and the purpose has been
@@ -4991,7 +4991,7 @@ recheck:
*/
raw_spin_lock_irqsave(&p->pi_lock, flags);
/*
- * To be able to change p->policy safely, the apropriate
+ * To be able to change p->policy safely, the appropriate
* runqueue lock must be held.
*/
rq = __task_rq_lock(p);
@@ -5695,7 +5695,7 @@ void show_state_filter(unsigned long state_filter)
do_each_thread(g, p) {
/*
* reset the NMI-timeout, listing all files on a slow
- * console might take alot of time:
+ * console might take a lot of time:
*/
touch_nmi_watchdog();
if (!state_filter || (p->state & state_filter))
diff --git a/kernel/sched_autogroup.c b/kernel/sched_autogroup.c
index 5946ac5..429242f 100644
--- a/kernel/sched_autogroup.c
+++ b/kernel/sched_autogroup.c
@@ -179,7 +179,7 @@ void sched_autogroup_create_attach(struct task_struct *p)
struct autogroup *ag = autogroup_create();

autogroup_move_group(p, ag);
- /* drop extra refrence added by autogroup_create() */
+ /* drop extra reference added by autogroup_create() */
autogroup_kref_put(ag);
}
EXPORT_SYMBOL(sched_autogroup_create_attach);
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 3f7ec9e..3cb7f07 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -3061,7 +3061,7 @@ static inline void calculate_imbalance(struct sd_lb_stats *sds, int this_cpu,

/*
* if *imbalance is less than the average load per runnable task
- * there is no gaurantee that any tasks will be moved so we'll have
+ * there is no guarantee that any tasks will be moved so we'll have
* a think about bumping its value to force at least one task to be
* moved
*/
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index db308cb..e7cebdc 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -1378,7 +1378,7 @@ retry:
task = pick_next_pushable_task(rq);
if (task_cpu(next_task) == rq->cpu && task == next_task) {
/*
- * If we get here, the task hasnt moved at all, but
+ * If we get here, the task hasn't moved at all, but
* it has failed to push. We will not try again,
* since the other cpus will pull from us when they
* are ready.
@@ -1488,7 +1488,7 @@ static int pull_rt_task(struct rq *this_rq)
/*
* We continue with the search, just in
* case there's an even higher prio task
- * in another runqueue. (low likelyhood
+ * in another runqueue. (low likelihood
* but possible)
*/
}
--
1.7.4.1

2011-03-18 13:41:11

by Lucas De Marchi

[permalink] [raw]

Subject: [PATCH 4/4] tracing: Fix common misspellings

They were generated by 'codespell' and then manually reviewed.

Signed-off-by: Lucas De Marchi <[email protected]>
---
include/linux/tracehook.h | 4 ++--
kernel/trace/ftrace.c | 4 ++--
kernel/trace/ring_buffer.c | 4 ++--
kernel/trace/trace.c | 6 +++---
kernel/trace/trace_clock.c | 2 +-
kernel/trace/trace_entries.h | 2 +-
kernel/trace/trace_functions_graph.c | 2 +-
kernel/trace/trace_irqsoff.c | 2 +-
kernel/trace/trace_kprobe.c | 2 +-
9 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
index 3a2e66d..ebcfa4e 100644
--- a/include/linux/tracehook.h
+++ b/include/linux/tracehook.h
@@ -169,7 +169,7 @@ static inline int tracehook_unsafe_exec(struct task_struct *task)
* tracehook_tracer_task - return the task that is tracing the given task
* @tsk: task to consider
*
- * Returns NULL if noone is tracing @task, or the &struct task_struct
+ * Returns NULL if no one is tracing @task, or the &struct task_struct
* pointer to its tracer.
*
* Must called under rcu_read_lock(). The pointer returned might be kept
@@ -448,7 +448,7 @@ static inline int tracehook_force_sigpending(void)
*
* Return zero to check for a real pending signal normally.
* Return -1 after releasing the siglock to repeat the check.
- * Return a signal number to induce an artifical signal delivery,
+ * Return a signal number to induce an artificial signal delivery,
* setting *@info and *@return_ka to specify its details and behavior.
*
* The @return_ka->sa_handler value controls the disposition of the
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 888b611..2321781 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1268,7 +1268,7 @@ static int ftrace_update_code(struct module *mod)
p->flags = 0L;

/*
- * Do the initial record convertion from mcount jump
+ * Do the initial record conversion from mcount jump
* to the NOP instructions.
*/
if (!ftrace_code_disable(mod, p)) {
@@ -3426,7 +3426,7 @@ graph_init_task(struct task_struct *t, struct ftrace_ret_stack *ret_stack)
atomic_set(&t->tracing_graph_pause, 0);
atomic_set(&t->trace_overrun, 0);
t->ftrace_timestamp = 0;
- /* make curr_ret_stack visable before we add the ret_stack */
+ /* make curr_ret_stack visible before we add the ret_stack */
smp_wmb();
t->ret_stack = ret_stack;
}
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index db7b439..bba050c 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1478,7 +1478,7 @@ static inline unsigned long rb_page_entries(struct buffer_page *bpage)
return local_read(&bpage->entries) & RB_WRITE_MASK;
}

-/* Size is determined by what has been commited */
+/* Size is determined by what has been committed */
static inline unsigned rb_page_size(struct buffer_page *bpage)
{
return rb_page_commit(bpage);
@@ -2932,7 +2932,7 @@ rb_get_reader_page(struct ring_buffer_per_cpu *cpu_buffer)
/*
* cpu_buffer->pages just needs to point to the buffer, it
* has no specific buffer page to point to. Lets move it out
- * of our way so we don't accidently swap it.
+ * of our way so we don't accidentally swap it.
*/
cpu_buffer->pages = reader->list.prev;

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 9541c27..e1731b9 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -382,15 +382,15 @@ __setup("trace_buf_size=", set_buf_size);

static int __init set_tracing_thresh(char *str)
{
- unsigned long threshhold;
+ unsigned long threshold;
int ret;

if (!str)
return 0;
- ret = strict_strtoul(str, 0, &threshhold);
+ ret = strict_strtoul(str, 0, &threshold);
if (ret < 0)
return 0;
- tracing_thresh = threshhold * 1000;
+ tracing_thresh = threshold * 1000;
return 1;
}
__setup("tracing_thresh=", set_tracing_thresh);
diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c
index 685a67d..6302747 100644
--- a/kernel/trace/trace_clock.c
+++ b/kernel/trace/trace_clock.c
@@ -46,7 +46,7 @@ u64 notrace trace_clock_local(void)
}

/*
- * trace_clock(): 'inbetween' trace clock. Not completely serialized,
+ * trace_clock(): 'between' trace clock. Not completely serialized,
* but not completely incorrect when crossing CPUs either.
*
* This is based on cpu_clock(), which will allow at most ~1 jiffy of
diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h
index 1516cb3..e32744c 100644
--- a/kernel/trace/trace_entries.h
+++ b/kernel/trace/trace_entries.h
@@ -27,7 +27,7 @@
* in the structure.
*
* * for structures within structures, the format of the internal
- * structure is layed out. This allows the internal structure
+ * structure is laid out. This allows the internal structure
* to be deciphered for the format file. Although these macros
* may become out of sync with the internal structure, they
* will create a compile error if it happens. Since the
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 76b0598..962cdb2 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -905,7 +905,7 @@ print_graph_prologue(struct trace_iterator *iter, struct trace_seq *s,
*
* returns 1 if
* - we are inside irq code
- * - we just extered irq code
+ * - we just entered irq code
*
* retunns 0 if
* - funcgraph-interrupts option is set
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
index 92b6e1e..a4969b4 100644
--- a/kernel/trace/trace_irqsoff.c
+++ b/kernel/trace/trace_irqsoff.c
@@ -80,7 +80,7 @@ static struct tracer_flags tracer_flags = {
* skip the latency if the sequence has changed - some other section
* did a maximum and could disturb our measurement with serial console
* printouts, etc. Truly coinciding maximum latencies should be rare
- * and what happens together happens separately as well, so this doesnt
+ * and what happens together happens separately as well, so this doesn't
* decrease the validity of the maximum found:
*/
static __cacheline_aligned_in_smp unsigned long max_sequence;
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 8435b43..35d55a3 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -1839,7 +1839,7 @@ static void unregister_probe_event(struct trace_probe *tp)
kfree(tp->call.print_fmt);
}

-/* Make a debugfs interface for controling probe points */
+/* Make a debugfs interface for controlling probe points */
static __init int init_kprobe_trace(void)
{
struct dentry *d_tracer;
--
1.7.4.1

2011-03-18 13:41:24

by Lucas De Marchi

[permalink] [raw]

Subject: [PATCH 2/4] perf: fix common misspellings

They were generated by 'codespell' and then manually reviewed.

Signed-off-by: Lucas De Marchi <[email protected]>
---
arch/mips/kernel/perf_event_mipsxx.c | 2 +-
arch/powerpc/kernel/perf_event.c | 2 +-
arch/sparc/kernel/perf_event.c | 2 +-
arch/x86/kernel/cpu/perf_event.c | 2 +-
arch/x86/kernel/cpu/perf_event_p4.c | 8 ++++----
include/linux/perf_event.h | 2 +-
tools/perf/util/string.c | 2 +-
7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_event_mipsxx.c
index d9a7db7..75266ff 100644
--- a/arch/mips/kernel/perf_event_mipsxx.c
+++ b/arch/mips/kernel/perf_event_mipsxx.c
@@ -721,7 +721,7 @@ static void mipsxx_pmu_start(void)

/*
* MIPS performance counters can be per-TC. The control registers can
- * not be directly accessed accross CPUs. Hence if we want to do global
+ * not be directly accessed across CPUs. Hence if we want to do global
* control, we need cross CPU calls. on_each_cpu() can help us, but we
* can not make sure this function is called with interrupts enabled. So
* here we pause local counters and then grab a rwlock and leave the
diff --git a/arch/powerpc/kernel/perf_event.c b/arch/powerpc/kernel/perf_event.c
index 97e0ae4..c4063b7 100644
--- a/arch/powerpc/kernel/perf_event.c
+++ b/arch/powerpc/kernel/perf_event.c
@@ -759,7 +759,7 @@ static int power_pmu_add(struct perf_event *event, int ef_flags)

/*
* If group events scheduling transaction was started,
- * skip the schedulability test here, it will be peformed
+ * skip the schedulability test here, it will be performed
* at commit time(->commit_txn) as a whole
*/
if (cpuhw->group_flag & PERF_EVENT_TXN)
diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c
index 7605786..ee8426e 100644
--- a/arch/sparc/kernel/perf_event.c
+++ b/arch/sparc/kernel/perf_event.c
@@ -1027,7 +1027,7 @@ static int sparc_pmu_add(struct perf_event *event, int ef_flags)

/*
* If group events scheduling transaction was started,
- * skip the schedulability test here, it will be peformed
+ * skip the schedulability test here, it will be performed
* at commit time(->commit_txn) as a whole
*/
if (cpuc->group_flag & PERF_EVENT_TXN)
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
index e8dbe17..e3ba177 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -1109,7 +1109,7 @@ static int x86_pmu_add(struct perf_event *event, int flags)

/*
* If group events scheduling transaction was started,
- * skip the schedulability test here, it will be peformed
+ * skip the schedulability test here, it will be performed
* at commit time (->commit_txn) as a whole
*/
if (cpuc->group_flag & PERF_EVENT_TXN)
diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
index 3769ac8..0811f5e 100644
--- a/arch/x86/kernel/cpu/perf_event_p4.c
+++ b/arch/x86/kernel/cpu/perf_event_p4.c
@@ -1,5 +1,5 @@
/*
- * Netburst Perfomance Events (P4, old Xeon)
+ * Netburst Performance Events (P4, old Xeon)
*
* Copyright (C) 2010 Parallels, Inc., Cyrill Gorcunov <[email protected]>
* Copyright (C) 2010 Intel Corporation, Lin Ming <[email protected]>
@@ -679,7 +679,7 @@ static int p4_validate_raw_event(struct perf_event *event)
*/

/*
- * if an event is shared accross the logical threads
+ * if an event is shared across the logical threads
* the user needs special permissions to be able to use it
*/
if (p4_ht_active() && p4_event_bind_map[v].shared) {
@@ -790,13 +790,13 @@ static void p4_pmu_disable_pebs(void)
*
* It's still allowed that two threads setup same cache
* events so we can't simply clear metrics until we knew
- * noone is depending on us, so we need kind of counter
+ * no one is depending on us, so we need kind of counter
* for "ReplayEvent" users.
*
* What is more complex -- RAW events, if user (for some
* reason) will pass some cache event metric with improper
* event opcode -- it's fine from hardware point of view
- * but completely nonsence from "meaning" of such action.
+ * but completely nonsense from "meaning" of such action.
*
* So at moment let leave metrics turned on forever -- it's
* ok for now but need to be revisited!
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index f495c01..390eb2f 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -662,7 +662,7 @@ struct pmu {
int (*commit_txn) (struct pmu *pmu); /* optional */
/*
* Will cancel the transaction, assumes ->del() is called
- * for each successfull ->add() during the transaction.
+ * for each successful ->add() during the transaction.
*/
void (*cancel_txn) (struct pmu *pmu); /* optional */
};
diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c
index 8fc0bd3..b9a985d 100644
--- a/tools/perf/util/string.c
+++ b/tools/perf/util/string.c
@@ -85,7 +85,7 @@ out:

/*
* Helper function for splitting a string into an argv-like array.
- * originaly copied from lib/argv_split.c
+ * originally copied from lib/argv_split.c
*/
static const char *skip_sep(const char *cp)
{
--
1.7.4.1

2011-03-22 10:37:50

by Ingo Molnar

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

* Lucas De Marchi <[email protected]> wrote:

> They were generated by 'codespell' and then manually reviewed.
>
> Signed-off-by: Lucas De Marchi <[email protected]>
> ---
> arch/mips/kernel/perf_event_mipsxx.c | 2 +-
> arch/powerpc/kernel/perf_event.c | 2 +-
> arch/sparc/kernel/perf_event.c | 2 +-
> arch/x86/kernel/cpu/perf_event.c | 2 +-
> arch/x86/kernel/cpu/perf_event_p4.c | 8 ++++----
> include/linux/perf_event.h | 2 +-
> tools/perf/util/string.c | 2 +-
> 7 files changed, 10 insertions(+), 10 deletions(-)

Hm, half of these do not apply anymore.

Since they are auto-generated, mind sending one large spelling fixes patch to
Linus (for the whole kernel), at the end of the merge window, instead of these
zillions of small commits which just clutter the patchflow? That makes it a
heck of a lot easier to verify and handle for everyone involved.

Thanks,

Ingo

2011-03-22 11:28:14

by Lucas De Marchi

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

Hi Ingo,

[ CC'ing Randy Dunlap and Jason Wessel ]

On Tue, Mar 22, 2011 at 07:37, Ingo Molnar <[email protected]> wrote:
>
> * Lucas De Marchi <[email protected]> wrote:
>
>> They were generated by 'codespell' and then manually reviewed.
>>
>> Signed-off-by: Lucas De Marchi <[email protected]>
>> ---
>> ?arch/mips/kernel/perf_event_mipsxx.c | ? ?2 +-
>> ?arch/powerpc/kernel/perf_event.c ? ? | ? ?2 +-
>> ?arch/sparc/kernel/perf_event.c ? ? ? | ? ?2 +-
>> ?arch/x86/kernel/cpu/perf_event.c ? ? | ? ?2 +-
>> ?arch/x86/kernel/cpu/perf_event_p4.c ?| ? ?8 ++++----
>> ?include/linux/perf_event.h ? ? ? ? ? | ? ?2 +-
>> ?tools/perf/util/string.c ? ? ? ? ? ? | ? ?2 +-
>> ?7 files changed, 10 insertions(+), 10 deletions(-)
>
> Hm, half of these do not apply anymore.
>
> Since they are auto-generated, mind sending one large spelling fixes patch to
> Linus (for the whole kernel), at the end of the merge window, instead of these
> zillions of small commits which just clutter the patchflow? That makes it a
> heck of a lot easier to verify and handle for everyone involved.

I agree with you, but last time I tried a large patch for fixing this
I've been told to split the patches for each maintainer
(http://kerneltrap.org/mailarchive/linux-kernel/2010/9/7/4616618). As
you noticed it's a pain to apply them and it's even more for splitting
in a per maintainer basis since it touches a lot of files.

Randy, Jason: as you see maybe the split approach was not a good one.

I'am all for applying this once, as Ingo said.

regards,

Lucas De Marchi

2011-03-22 11:44:26

by Ingo Molnar

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

* Lucas De Marchi <[email protected]> wrote:

> Hi Ingo,
>
> [ CC'ing Randy Dunlap and Jason Wessel ]
>
> On Tue, Mar 22, 2011 at 07:37, Ingo Molnar <[email protected]> wrote:
> >
> > * Lucas De Marchi <[email protected]> wrote:
> >
> >> They were generated by 'codespell' and then manually reviewed.
> >>
> >> Signed-off-by: Lucas De Marchi <[email protected]>
> >> ---
> >> ?arch/mips/kernel/perf_event_mipsxx.c | ? ?2 +-
> >> ?arch/powerpc/kernel/perf_event.c ? ? | ? ?2 +-
> >> ?arch/sparc/kernel/perf_event.c ? ? ? | ? ?2 +-
> >> ?arch/x86/kernel/cpu/perf_event.c ? ? | ? ?2 +-
> >> ?arch/x86/kernel/cpu/perf_event_p4.c ?| ? ?8 ++++----
> >> ?include/linux/perf_event.h ? ? ? ? ? | ? ?2 +-
> >> ?tools/perf/util/string.c ? ? ? ? ? ? | ? ?2 +-
> >> ?7 files changed, 10 insertions(+), 10 deletions(-)
> >
> > Hm, half of these do not apply anymore.
> >
> > Since they are auto-generated, mind sending one large spelling fixes patch to
> > Linus (for the whole kernel), at the end of the merge window, instead of these
> > zillions of small commits which just clutter the patchflow? That makes it a
> > heck of a lot easier to verify and handle for everyone involved.
>
> I agree with you, but last time I tried a large patch for fixing this
> I've been told to split the patches for each maintainer
> (http://kerneltrap.org/mailarchive/linux-kernel/2010/9/7/4616618). As
> you noticed it's a pain to apply them and it's even more for splitting
> in a per maintainer basis since it touches a lot of files.
>
> Randy, Jason: as you see maybe the split approach was not a good one.
>
> I'am all for applying this once, as Ingo said.

Well, ultimately it's up to Linus (i've Cc:-ed him).

For such pure spelling fixes i think what matters most is the timing, so that
it impacts outstanding trees in the smallest possible way. For that the best
timing would right before -rc1 - i.e. this week - as that is the moment when
the outstanding queues are the shortest.

Could you send the diffstat of the big, combined patch - how large is it total?

Thanks,

Ingo

2011-03-22 12:07:57

by Lucas De Marchi

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

2011-03-22 12:34:12

by Ingo Molnar

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

* Lucas De Marchi <[email protected]> wrote:

> 2530 files changed, 4988 insertions(+), 4988 deletions(-)

Hm, i definitely think we do not want hundreds of commits per cycle to have a
'split up' patchset for these spelling fixes.

A once per cycle patch to fix such things would be the most optimal model IMHO
- and hopefully with time the patches will be getting (much) smaller :-)

Anyway, it's all up to Linus whether he'll take a big patch.

Thanks,

Ingo

2011-03-22 12:39:58

by Lucas De Marchi

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

On Tue, Mar 22, 2011 at 9:33 AM, Ingo Molnar <[email protected]> wrote:
>
> * Lucas De Marchi <[email protected]> wrote:
>
>> ?2530 files changed, 4988 insertions(+), 4988 deletions(-)
>
> Hm, i definitely think we do not want hundreds of commits per cycle to have a
> 'split up' patchset for these spelling fixes.
>
> A once per cycle patch to fix such things would be the most optimal model IMHO
> - and hopefully with time the patches will be getting (much) smaller :-)

I don't think a patchset per cycle is needed. Or at least some cycles
could be skipped.

Maybe this check could be added to checkpatch.

Lucas De Marchi

2011-03-22 16:39:46

by Linus Torvalds

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

On Tue, Mar 22, 2011 at 5:33 AM, Ingo Molnar <[email protected]> wrote:
>
> * Lucas De Marchi <[email protected]> wrote:
>
>> ?2530 files changed, 4988 insertions(+), 4988 deletions(-)
>
> Hm, i definitely think we do not want hundreds of commits per cycle to have a
> 'split up' patchset for these spelling fixes.
>
> A once per cycle patch to fix such things would be the most optimal model IMHO
> - and hopefully with time the patches will be getting (much) smaller :-)
>
> Anyway, it's all up to Linus whether he'll take a big patch.

I can take a big patch, but not during the merge window when there are
outstanding pull reqeuests etc. But possibly soon after -rc1, if it
gets some review and I feel comfortable that the patch is clearly only
spelling in comments (or whatever the exact rules are for codespell)

Linus

2011-03-22 16:48:28

by Lucas De Marchi

[permalink] [raw]

Subject: Re: [PATCH 2/4] perf: fix common misspellings

On Tue, Mar 22, 2011 at 1:31 PM, Linus Torvalds
<[email protected]> wrote:
>> Anyway, it's all up to Linus whether he'll take a big patch.
>
> I can take a big patch, but not during the merge window when there are
> outstanding pull reqeuests etc. But possibly soon after -rc1, if it
> gets some review and I feel comfortable that the patch is clearly only
> spelling in comments (or whatever the exact rules are for codespell)

I care most about misspellings in user visible strings like docs and
printks, but there is no such distinction. In real code though changes
are usually not done (var names and the like).

Lucas De Marchi