2012-06-19 11:15:33

by Axel Lin

Subject: regulator: tps6586x: What is the meaning of TPS6586X_SLEW_RATE_SET setting?

Hi Mike,
While looking at the datasheet (tps65860 and tps65862),
I don't understand why we have TPS6586X_SLEW_RATE_SET (0x08) in the code.

According to the datasheet, BIT3 of SM1SL/SM0SL is not used:

SM1SL [Addr 0x25]
SM0SL [Addr 0x28]
BIT[2:0] SM0/SM1 SUPPLY RAMP RATE
BIT[7:3] NOT USED

So why we need to check the "unused bit" in tps6586x_regulator_set_slew_rate()?

if (!(setting->slew_rate & TPS6586X_SLEW_RATE_SET))
return 0;

Regards,
Axel

2012-06-20 08:04:52

by Danny Huang

Subject: RE: regulator: tps6586x: What is the meaning of TPS6586X_SLEW_RATE_SET setting?

Hi Axel,

The TPS6586X_SLEW_RATE_SET is not related with hardware register.
It was used to make sure that the slew rate won't be changed by accident.

Thanks,
Danny

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Tuesday, June 19, 2012 19:15
To: [email protected]
Cc: Mike Rapoport; Danny Huang; Liam Girdwood; Mark Brown
Subject: regulator: tps6586x: What is the meaning of TPS6586X_SLEW_RATE_SET setting?

Hi Mike,
While looking at the datasheet (tps65860 and tps65862),
I don't understand why we have TPS6586X_SLEW_RATE_SET (0x08) in the code.

According to the datasheet, BIT3 of SM1SL/SM0SL is not used:

SM1SL [Addr 0x25]
SM0SL [Addr 0x28]
BIT[2:0] SM0/SM1 SUPPLY RAMP RATE
BIT[7:3] NOT USED

So why we need to check the "unused bit" in tps6586x_regulator_set_slew_rate()?

if (!(setting->slew_rate & TPS6586X_SLEW_RATE_SET))
return 0;

Regards,
Axel

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?