2012-10-22 15:56:17

by Denis Kirjanov

Subject: [PATCH] check the kzalloc return value

Signed-off-by: Denis Kirjanov <[email protected]>
---
drivers/edac/edac_mc_sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index ed0bc07..55ce016 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -1128,7 +1128,8 @@ int __init edac_mc_sysfs_init(void)
}

mci_pdev = kzalloc(sizeof(*mci_pdev), GFP_KERNEL);
-
+ if (!mci_pdev)
+ return -ENOMEM;
mci_pdev->bus = edac_subsys;
mci_pdev->type = &mc_attr_type;
device_initialize(mci_pdev);
--
1.7.9.5

2012-10-23 15:42:32

by Borislav Petkov

Subject: Re: [PATCH] check the kzalloc return value

On Mon, Oct 22, 2012 at 07:56:04PM +0400, Denis Kirjanov wrote:
>

Needs a commit message.

> Signed-off-by: Denis Kirjanov <[email protected]>
> ---
> drivers/edac/edac_mc_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> index ed0bc07..55ce016 100644
> --- a/drivers/edac/edac_mc_sysfs.c
> +++ b/drivers/edac/edac_mc_sysfs.c
> @@ -1128,7 +1128,8 @@ int __init edac_mc_sysfs_init(void)
> }
>
> mci_pdev = kzalloc(sizeof(*mci_pdev), GFP_KERNEL);
> -
> + if (!mci_pdev)
> + return -ENOMEM;

This either needs to do

edac_put_sysfs_subsys();

on the error-out path.

> mci_pdev->bus = edac_subsys;
> mci_pdev->type = &mc_attr_type;
> device_initialize(mci_pdev);

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

2012-10-23 15:47:43

by Denis Kirjanov

Subject: Re: [PATCH] check the kzalloc return value

I'll resubmit a new patch.

Thanks!

On 10/23/12, Borislav Petkov <[email protected]> wrote:
> On Mon, Oct 22, 2012 at 07:56:04PM +0400, Denis Kirjanov wrote:
>>
>
> Needs a commit message.
>
>> Signed-off-by: Denis Kirjanov <[email protected]>
>> ---
>> drivers/edac/edac_mc_sysfs.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
>> index ed0bc07..55ce016 100644
>> --- a/drivers/edac/edac_mc_sysfs.c
>> +++ b/drivers/edac/edac_mc_sysfs.c
>> @@ -1128,7 +1128,8 @@ int __init edac_mc_sysfs_init(void)
>> }
>>
>> mci_pdev = kzalloc(sizeof(*mci_pdev), GFP_KERNEL);
>> -
>> + if (!mci_pdev)
>> + return -ENOMEM;
>
> This either needs to do
>
> edac_put_sysfs_subsys();
>
> on the error-out path.
>
>> mci_pdev->bus = edac_subsys;
>> mci_pdev->type = &mc_attr_type;
>> device_initialize(mci_pdev);
>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> Advanced Micro Devices GmbH
> Einsteinring 24, 85609 Dornach
> GM: Alberto Bozzo
> Reg: Dornach, Landkreis Muenchen
> HRB Nr. 43632 WEEE Registernr: 129 19551
>


--
Regards,
Denis