2013-03-04 06:52:07

by Silviu-Mihai Popescu

Subject: [PATCH v2] CAIF: fix sparse warning for caif_usb

This fixes the following sparse warning:
net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <[email protected]>
---
net/caif/caif_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index 3ebc8cb..1c6ded9 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
layr->up->ctrlcmd(layr->up, ctrl, layr->id);
}

-struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
- u8 braddr[ETH_ALEN])
+static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
+ u8 braddr[ETH_ALEN])
{
struct cfusbl *this = kmalloc(sizeof(struct cfusbl), GFP_ATOMIC);

--
1.7.9.5

2013-03-04 07:00:54

by David Miller

Subject: Re: [PATCH v2] CAIF: fix sparse warning for caif_usb

From: Silviu-Mihai Popescu <[email protected]>
Date: Mon, 4 Mar 2013 08:52:00 +0200

> This fixes the following sparse warning:
> net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
> declared. Should it be static?
>
> Signed-off-by: Silviu-Mihai Popescu <[email protected]>
> ---
> net/caif/caif_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
> index 3ebc8cb..1c6ded9 100644
> --- a/net/caif/caif_usb.c
> +++ b/net/caif/caif_usb.c
> @@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
> layr->up->ctrlcmd(layr->up, ctrl, layr->id);
> }
>
> -struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
> - u8 braddr[ETH_ALEN])
> +static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
> + u8 braddr[ETH_ALEN])

Nope, that indentation isn't correct, is should be:

static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
u8 braddr[ETH_ALEN])

Read my email, I said that the first character on the second line
must line up with the first column after the openning parenthesis
of the first line.