2013-05-18 02:49:30

by jonghwan Choi

Subject: [PATCH 3.9-stable] NTB: reset tx_index on link toggle

From: Jon Mason <[email protected]>

This patch looks like it should be in the 3.9-stable tree, should we apply
it?

------------------

From: "Jon Mason <[email protected]>"

commit 90f9e934647e652a69396e18c779215a493271cf upstream

If the NTB link toggles, the driver could stop receiving due to the
tx_index not being set to 0 on the transmitting size on a link-up event.
This is due to the driver expecting the incoming data to start at the
beginning of the receive buffer and not at a random place.

Cc: <[email protected]> # 3.9.x: ad3e2751: ntb: off by one
Cc: <[email protected]> # 3.9.x: cc0f868d: NTB: fix pointer math
Cc: <[email protected]> # 3.9.x: 113fc505: NTB: Handle 64bit BAR
Cc: <[email protected]> # 3.9.x: b77b2637: NTB: Link toggle memory
Signed-off-by: Jon Mason <[email protected]>
Signed-off-by: Jonghwan Choi <[email protected]>
---
drivers/ntb/ntb_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index f5a424d..0828124 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -505,6 +505,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,

qp->rx_pkts = 0;
qp->tx_pkts = 0;
+ qp->tx_index = 0;
}

static void ntb_free_mw(struct ntb_transport *nt, int num_mw)
@@ -819,7 +820,6 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
qp->tx_mw = qp->rx_info + 1;
qp->tx_max_frame = min(transport_mtu, tx_size);
qp->tx_max_entry = tx_size / qp->tx_max_frame;
- qp->tx_index = 0;

if (nt->debugfs_dir) {
char debugfs_name[4];
--
1.8.1.2

2013-05-18 14:48:19

by Jon Mason

Subject: Re: [PATCH 3.9-stable] NTB: reset tx_index on link toggle

On Sat, May 18, 2013 at 11:47:17AM +0900, Jonghwan Choi wrote:
> From: Jon Mason <[email protected]>
>
> This patch looks like it should be in the 3.9-stable tree, should we apply
> it?

Yes, thanks.

>
> ------------------
>
> From: "Jon Mason <[email protected]>"
>
> commit 90f9e934647e652a69396e18c779215a493271cf upstream
>
> If the NTB link toggles, the driver could stop receiving due to the
> tx_index not being set to 0 on the transmitting size on a link-up event.
> This is due to the driver expecting the incoming data to start at the
> beginning of the receive buffer and not at a random place.
>
> Cc: <[email protected]> # 3.9.x: ad3e2751: ntb: off by one
> Cc: <[email protected]> # 3.9.x: cc0f868d: NTB: fix pointer math
> Cc: <[email protected]> # 3.9.x: 113fc505: NTB: Handle 64bit BAR
> Cc: <[email protected]> # 3.9.x: b77b2637: NTB: Link toggle memory
> Signed-off-by: Jon Mason <[email protected]>
> Signed-off-by: Jonghwan Choi <[email protected]>
> ---
> drivers/ntb/ntb_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index f5a424d..0828124 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -505,6 +505,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,
>
> qp->rx_pkts = 0;
> qp->tx_pkts = 0;
> + qp->tx_index = 0;
> }
>
> static void ntb_free_mw(struct ntb_transport *nt, int num_mw)
> @@ -819,7 +820,6 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
> qp->tx_mw = qp->rx_info + 1;
> qp->tx_max_frame = min(transport_mtu, tx_size);
> qp->tx_max_entry = tx_size / qp->tx_max_frame;
> - qp->tx_index = 0;
>
> if (nt->debugfs_dir) {
> char debugfs_name[4];
> --
> 1.8.1.2
>