2013-05-30 07:08:17

by Li Guang

Subject: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

orderly_poweroff is expecting a bool parameter, so
use 'ture' instead '1'

Signed-off-by: liguang <[email protected]>
---
arch/powerpc/platforms/pseries/ras.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c4dfccd..79b9502 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -83,7 +83,7 @@ static void handle_system_shutdown(char event_modifier)
switch (event_modifier) {
case EPOW_SHUTDOWN_NORMAL:
pr_emerg("Firmware initiated power off");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;

case EPOW_SHUTDOWN_ON_UPS:
@@ -95,13 +95,13 @@ static void handle_system_shutdown(char event_modifier)
pr_emerg("Loss of system critical functions reported by "
"firmware");
pr_emerg("Check RTAS error log for details");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;

case EPOW_SHUTDOWN_AMBIENT_TEMPERATURE_TOO_HIGH:
pr_emerg("Ambient temperature too high reported by firmware");
pr_emerg("Check RTAS error log for details");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;

default:
@@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)

case EPOW_SYSTEM_HALT:
pr_emerg("Firmware initiated power off");
- orderly_poweroff(1);
+ orderly_poweroff(ture);
break;

case EPOW_MAIN_ENCLOSURE:
--
1.7.2.5

2013-05-30 07:14:33

by Joe Perches

Subject: Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
> orderly_poweroff is expecting a bool parameter, so
> use 'ture' instead '1'
[]
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
[]
> @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
>
> case EPOW_SYSTEM_HALT:
> pr_emerg("Firmware initiated power off");
> - orderly_poweroff(1);
> + orderly_poweroff(ture);
> break;

Compile your patches _before_ submitting them please.

"true" not "ture" here and in the commit message.

2013-05-30 07:20:52

by Li Guang

Subject: Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

在 2013-05-30四的 00:14 -0700，Joe Perches写道：
> On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
> > orderly_poweroff is expecting a bool parameter, so
> > use 'ture' instead '1'
> []
> > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> []
> > @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
> >
> > case EPOW_SYSTEM_HALT:
> > pr_emerg("Firmware initiated power off");
> > - orderly_poweroff(1);
> > + orderly_poweroff(ture);
> > break;
>
> Compile your patches _before_ submitting them please.
>
> "true" not "ture" here and in the commit message.
>

right, thanks!