2013-06-27 19:48:00

by Naresh Bhat

Subject: [PATCH] ACPI/fan: Initialize acpi_state variable

From: Naresh Bhat <[email protected]>

CC drivers/acpi/fan.o
drivers/acpi/fan.c: In function ‘fan_get_cur_state’:
drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized]
---
drivers/acpi/fan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index f815da8..f961435 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
{
struct acpi_device *device = cdev->devdata;
int result;
- int acpi_state;
+ int acpi_state = ACPI_STATE_D0;

if (!device)
return -EINVAL;
--
1.7.9.5

2013-07-01 12:01:49

by Naresh Bhat

Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable

Hi Rafeal,

I appreciate if you give any feedback on the provided patch.

Thanks
-Naresh Bhat

On 28 June 2013 01:17, <[email protected]> wrote:
> From: Naresh Bhat <[email protected]>
>
> CC drivers/acpi/fan.o
> drivers/acpi/fan.c: In function ?fan_get_cur_state?:
> drivers/acpi/fan.c:96:9: warning: ?acpi_state? may be used uninitialized in this function [-Wuninitialized]
> ---
> drivers/acpi/fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> index f815da8..f961435 100644
> --- a/drivers/acpi/fan.c
> +++ b/drivers/acpi/fan.c
> @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
> {
> struct acpi_device *device = cdev->devdata;
> int result;
> - int acpi_state;
> + int acpi_state = ACPI_STATE_D0;
>
> if (!device)
> return -EINVAL;
> --
> 1.7.9.5
>

2013-07-01 13:49:57

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable

On Monday, July 01, 2013 05:31:46 PM Naresh Bhat wrote:
> Hi Rafeal,
>
> I appreciate if you give any feedback on the provided patch.

The patch is OK, but please add your sign-off.

Thanks,
Rafael


> On 28 June 2013 01:17, <[email protected]> wrote:
> > From: Naresh Bhat <[email protected]>
> >
> > CC drivers/acpi/fan.o
> > drivers/acpi/fan.c: In function ‘fan_get_cur_state’:
> > drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized]
> > ---
> > drivers/acpi/fan.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> > index f815da8..f961435 100644
> > --- a/drivers/acpi/fan.c
> > +++ b/drivers/acpi/fan.c
> > @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
> > {
> > struct acpi_device *device = cdev->devdata;
> > int result;
> > - int acpi_state;
> > + int acpi_state = ACPI_STATE_D0;
> >
> > if (!device)
> > return -EINVAL;
> > --
> > 1.7.9.5
> >
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2013-07-01 14:25:43

by Naresh Bhat

Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable

Opps sorry about that. I have added my sign-off and send the patch.

Thanks
Naresh Bhat

On 1 July 2013 19:29, Rafael J. Wysocki <[email protected]> wrote:
> On Monday, July 01, 2013 05:31:46 PM Naresh Bhat wrote:
>> Hi Rafeal,
>>
>> I appreciate if you give any feedback on the provided patch.
>
> The patch is OK, but please add your sign-off.
>
> Thanks,
> Rafael
>
>
>> On 28 June 2013 01:17, <[email protected]> wrote:
>> > From: Naresh Bhat <[email protected]>
>> >
>> > CC drivers/acpi/fan.o
>> > drivers/acpi/fan.c: In function ?fan_get_cur_state?:
>> > drivers/acpi/fan.c:96:9: warning: ?acpi_state? may be used uninitialized in this function [-Wuninitialized]
>> > ---
>> > drivers/acpi/fan.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
>> > index f815da8..f961435 100644
>> > --- a/drivers/acpi/fan.c
>> > +++ b/drivers/acpi/fan.c
>> > @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
>> > {
>> > struct acpi_device *device = cdev->devdata;
>> > int result;
>> > - int acpi_state;
>> > + int acpi_state = ACPI_STATE_D0;
>> >
>> > if (!device)
>> > return -EINVAL;
>> > --
>> > 1.7.9.5
>> >
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.