2013-07-11 06:23:28

by Valentina Manea

Subject: [PATCH] x86/pci: fix checkpatch.pl indentation warnings

This patch fixes warnings generated by checkpatch.pl
regarding indentation.

Signed-off-by: Valentina Manea <[email protected]>
---
arch/x86/pci/mrst.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
index 6eb18c4..cd0a373 100644
--- a/arch/x86/pci/mrst.c
+++ b/arch/x86/pci/mrst.c
@@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev)
{
/* PCI fixups are effectively decided compile time. If we have a dual
SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
- if (!pci_soc_mode)
- return;
+ if (!pci_soc_mode)
+ return;
/* true pci devices in lincroft should allow type 1 access, the rest
* are langwell fake pci devices.
*/
--
1.7.10.4

2013-07-12 10:26:46

by Ingo Molnar

Subject: Re: [PATCH] x86/pci: fix checkpatch.pl indentation warnings

* Valentina Manea <[email protected]> wrote:

> This patch fixes warnings generated by checkpatch.pl
> regarding indentation.
>
> Signed-off-by: Valentina Manea <[email protected]>
> ---
> arch/x86/pci/mrst.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
> index 6eb18c4..cd0a373 100644
> --- a/arch/x86/pci/mrst.c
> +++ b/arch/x86/pci/mrst.c
> @@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev)
> {
> /* PCI fixups are effectively decided compile time. If we have a dual
> SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
> - if (!pci_soc_mode)
> - return;
> + if (!pci_soc_mode)
> + return;
> /* true pci devices in lincroft should allow type 1 access, the rest
> * are langwell fake pci devices.
> */

If you do whitespace cleanups then please also fix all the other problems
in that file, right now mrst.c has more than just one:

total: 3 errors, 7 warnings, 3 checks, 303 lines checked

plus the area you patched has some wierd comment formatting as well. For
multi-line comments we use:

/*
* Comment .....
* ...... goes here.
*/

as specified in Documentation/CodingStyle.

Thanks,

Ingo