2013-09-18 15:18:18

by Richard Guy Briggs

Subject: [PATCH] audit: remove newline accidentally added during session id helper refactor

A newline was accidentally added during session ID helper refactorization in
commit 4d3fb709. This needlessly uses up buffer space, messes up syslog
formatting and makes userspace processing less efficient. Remove it.

Signed-off-by: Richard Guy Briggs <[email protected]>
---
kernel/audit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 3d17670..ac16540 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
u32 sessionid = audit_get_sessionid(current);
uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));

- audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
+ audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
}

void audit_log_key(struct audit_buffer *ab, char *key)
--
1.7.1

2013-09-20 16:08:55

by Eric Paris

Subject: Re: [PATCH] audit: remove newline accidentally added during session id helper refactor

On Wed, 2013-09-18 at 11:17 -0400, Richard Guy Briggs wrote:
> A newline was accidentally added during session ID helper refactorization in
> commit 4d3fb709. This needlessly uses up buffer space, messes up syslog
> formatting and makes userspace processing less efficient. Remove it.
>
> Signed-off-by: Richard Guy Briggs <[email protected]>

Acked-by: Eric Paris <[email protected]>

> ---
> kernel/audit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 3d17670..ac16540 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
> u32 sessionid = audit_get_sessionid(current);
> uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));
>
> - audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
> + audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
> }
>
> void audit_log_key(struct audit_buffer *ab, char *key)