2013-10-09 15:13:50

by Manish Badarkhe

Subject: [PATCH] cpufreq: fix false return check from "regulator_set_voltage"

Currently, code checks false return value from "regulator_set_voltage"
to show failure message. Modify the code to check proper return
value from "regulator_set_voltage".

Signed-off-by: Manish Badarkhe <[email protected]>
---
Based on master branch of linux-mainline.

:100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c
drivers/cpufreq/exynos-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 0fac344..1537f32 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -141,7 +141,7 @@ post_notify:
if ((freqs.new < freqs.old) ||
((freqs.new > freqs.old) && safe_arm_volt)) {
/* down the voltage after frequency change */
- regulator_set_voltage(arm_regulator, arm_volt,
+ ret = regulator_set_voltage(arm_regulator, arm_volt,
arm_volt);
if (ret) {
pr_err("%s: failed to set cpu voltage to %d\n",
--
1.7.10.4

2013-10-12 03:21:25

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: fix false return check from "regulator_set_voltage"

On 09/10/2013, Manish Badarkhe <[email protected]> wrote:
> Currently, code checks false return value from "regulator_set_voltage"
> to show failure message. Modify the code to check proper return
> value from "regulator_set_voltage".
>
> Signed-off-by: Manish Badarkhe <[email protected]>
> ---
> Based on master branch of linux-mainline.
>
> :100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c
> drivers/cpufreq/exynos-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c
> b/drivers/cpufreq/exynos-cpufreq.c
> index 0fac344..1537f32 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -141,7 +141,7 @@ post_notify:
> if ((freqs.new < freqs.old) ||
> ((freqs.new > freqs.old) && safe_arm_volt)) {
> /* down the voltage after frequency change */
> - regulator_set_voltage(arm_regulator, arm_volt,
> + ret = regulator_set_voltage(arm_regulator, arm_volt,
> arm_volt);
> if (ret) {
> pr_err("%s: failed to set cpu voltage to %d\n",

Acked-by: Viresh Kumar <[email protected]>