Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
removed the usage of mach/gpio.h file, but we need to include
plat/gpio-cfg.h to avoid following build error.
Fixes following build error.
drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
Signed-off-by: Tushar Behera <[email protected]>
---
Changes for V2:
* Updated commit message
Bryan,
I should have been more explicit regarding this patch. This patch fixes
build error on linux-next after the above patch was merged.
Tested at next-20131224.
drivers/leds/leds-s3c24xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 76483fb..87cf215 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -21,6 +21,7 @@
#include <mach/hardware.h>
#include <mach/regs-gpio.h>
+#include <plat/gpio-cfg.h>
#include <linux/platform_data/leds-s3c24xx.h>
/* our context */
--
1.7.9.5
On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <[email protected]> wrote:
> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
> removed the usage of mach/gpio.h file, but we need to include
> plat/gpio-cfg.h to avoid following build error.
>
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function ?s3c24xx_led_probe?:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function ?s3c_gpio_setpull? [-Werror=implicit-function-declaration]
>
I think this patch should go with Linus's patchset.
-Bryan
> Signed-off-by: Tushar Behera <[email protected]>
> ---
> Changes for V2:
> * Updated commit message
>
> Bryan,
>
> I should have been more explicit regarding this patch. This patch fixes
> build error on linux-next after the above patch was merged.
>
> Tested at next-20131224.
>
> drivers/leds/leds-s3c24xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index 76483fb..87cf215 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -21,6 +21,7 @@
>
> #include <mach/hardware.h>
> #include <mach/regs-gpio.h>
> +#include <plat/gpio-cfg.h>
> #include <linux/platform_data/leds-s3c24xx.h>
>
> /* our context */
> --
> 1.7.9.5
>
On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <[email protected]> wrote:
> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <[email protected]> wrote:
>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>> removed the usage of mach/gpio.h file, but we need to include
>> plat/gpio-cfg.h to avoid following build error.
>>
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ?s3c24xx_led_probe?:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ?s3c_gpio_setpull? [-Werror=implicit-function-declaration]
>>
>
> I think this patch should go with Linus's patchset.
Patch applied to the GPIO tree. I added your ACK Bryan since
that seems to be implied above ...
Yours,
Linus Walleij
On Tue, Jan 7, 2014 at 9:41 AM, Linus Walleij <[email protected]> wrote:
> On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <[email protected]> wrote:
>> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <[email protected]> wrote:
>>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>>> removed the usage of mach/gpio.h file, but we need to include
>>> plat/gpio-cfg.h to avoid following build error.
>>>
>>> Fixes following build error.
>>> drivers/leds/leds-s3c24xx.c: In function ?s3c24xx_led_probe?:
>>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>>> function ?s3c_gpio_setpull? [-Werror=implicit-function-declaration]
>>>
>>
>> I think this patch should go with Linus's patchset.
>
> Patch applied to the GPIO tree. I added your ACK Bryan since
> that seems to be implied above ...
>
Sure, thanks.
-Bryan