2014-02-11 18:34:18

by Rob Herring

Subject: [PATCH v2] cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU

From: Rob Herring <[email protected]>

The addition of THERMAL and THERMAL_CPU selections causes a kconfig
warning on highbank platforms:

warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has
unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK &&
REGULATOR && OF && THERMAL && CPU_THERMAL)

The cpufreq-cpu0 driver does not require thermal zone support to
function as highbank does not need these, so drop selecting of THERMAL
and CPU_THERMAL.

Reported-by: Olof Johansson <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Viresh Kumar <[email protected]>
Cc: [email protected]
Signed-off-by: Rob Herring <[email protected]>
---
v2:
- just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig
option

Dropping REGULATOR doesn't build w/o some empty regulator functions, so
that's 3.15 material.

Rob

drivers/cpufreq/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 4b029c0..d100926 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE

config GENERIC_CPUFREQ_CPU0
tristate "Generic CPU0 cpufreq driver"
- depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
+ depends on HAVE_CLK && REGULATOR && OF
select PM_OPP
help
This adds a generic cpufreq driver for CPU0 frequency management.
--
1.8.3.2

2014-02-12 04:41:21

by Viresh Kumar

Subject: Re: [PATCH v2] cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU

On 12 February 2014 00:03, Rob Herring <[email protected]> wrote:
> From: Rob Herring <[email protected]>
>
> The addition of THERMAL and THERMAL_CPU selections causes a kconfig
> warning on highbank platforms:
>
> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has
> unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK &&
> REGULATOR && OF && THERMAL && CPU_THERMAL)
>
> The cpufreq-cpu0 driver does not require thermal zone support to
> function as highbank does not need these, so drop selecting of THERMAL
> and CPU_THERMAL.
>
> Reported-by: Olof Johansson <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Viresh Kumar <[email protected]>
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
> ---
> v2:
> - just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig
> option
>
> Dropping REGULATOR doesn't build w/o some empty regulator functions, so
> that's 3.15 material.
>
> Rob
>
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 4b029c0..d100926 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
>
> config GENERIC_CPUFREQ_CPU0
> tristate "Generic CPU0 cpufreq driver"
> - depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
> + depends on HAVE_CLK && REGULATOR && OF
> select PM_OPP
> help
> This adds a generic cpufreq driver for CPU0 frequency management.

Acked-by: Viresh Kumar <[email protected]>