From: Claudiu Beznea <[email protected]>
Hi,
Series adds runtime PM support for the ravb driver. This is a continuation
of [1].
There are 4 more preparation patches (patches 1-4) and patch 5
adds runtime PM support.
Patches in this series were part of [2].
Changes since [2]:
- patch 1/5 is new
- use pm_runtime_get_noresume() and pm_runtime_active() in patches
3/5, 4/5
- fixed higlighted typos in patch 4/5
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
Claudiu Beznea (5):
net: ravb: Get rid of temporary variable irq
net: ravb: Keep the reverse order of operations in ravb_close()
net: ravb: Return cached statistics if the interface is down
net: ravb: Do not apply RX checksum settings to hardware if the
interface is down
net: ravb: Add runtime PM support
drivers/net/ethernet/renesas/ravb_main.c | 118 ++++++++++++++++++-----
1 file changed, 94 insertions(+), 24 deletions(-)
--
2.39.2
From: Claudiu Beznea <[email protected]>
The 4th argument of ravb_setup_irq() is used to save the IRQ number that
will be further used by the driver code. Not all ravb_setup_irqs() calls
need to save the IRQ number. The previous code used to pass a dummy
variable as the 4th argument in case the IRQ is not needed for further
usage. That is not necessary as the code from ravb_setup_irq() can detect
by itself if the IRQ needs to be saved. Thus, get rid of the code that is
not needed.
Reported-by: Sergey Shtylyov <[email protected]>
Signed-off-by: Claudiu Beznea <[email protected]>
---
Changes since [2]:
- this patch in new
[2] https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/renesas/ravb_main.c | 27 +++++++++++++-----------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 9521cd054274..e235342e0827 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2611,17 +2611,20 @@ static int ravb_setup_irq(struct ravb_private *priv, const char *irq_name,
if (!dev_name)
return -ENOMEM;
- *irq = platform_get_irq_byname(pdev, irq_name);
+ error = platform_get_irq_byname(pdev, irq_name);
flags = 0;
} else {
dev_name = ndev->name;
- *irq = platform_get_irq(pdev, 0);
+ error = platform_get_irq(pdev, 0);
flags = IRQF_SHARED;
}
- if (*irq < 0)
- return *irq;
+ if (error < 0)
+ return error;
- error = devm_request_irq(dev, *irq, handler, flags, dev_name, ndev);
+ if (irq)
+ *irq = error;
+
+ error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
if (error)
netdev_err(ndev, "cannot request IRQ %s\n", dev_name);
@@ -2633,7 +2636,7 @@ static int ravb_setup_irqs(struct ravb_private *priv)
const struct ravb_hw_info *info = priv->info;
struct net_device *ndev = priv->ndev;
const char *irq_name, *emac_irq_name;
- int error, irq;
+ int error;
if (!info->multi_irqs)
return ravb_setup_irq(priv, NULL, NULL, &ndev->irq, ravb_interrupt);
@@ -2656,28 +2659,28 @@ static int ravb_setup_irqs(struct ravb_private *priv)
return error;
if (info->err_mgmt_irqs) {
- error = ravb_setup_irq(priv, "err_a", "err_a", &irq, ravb_multi_interrupt);
+ error = ravb_setup_irq(priv, "err_a", "err_a", NULL, ravb_multi_interrupt);
if (error)
return error;
- error = ravb_setup_irq(priv, "mgmt_a", "mgmt_a", &irq, ravb_multi_interrupt);
+ error = ravb_setup_irq(priv, "mgmt_a", "mgmt_a", NULL, ravb_multi_interrupt);
if (error)
return error;
}
- error = ravb_setup_irq(priv, "ch0", "ch0:rx_be", &irq, ravb_be_interrupt);
+ error = ravb_setup_irq(priv, "ch0", "ch0:rx_be", NULL, ravb_be_interrupt);
if (error)
return error;
- error = ravb_setup_irq(priv, "ch1", "ch1:rx_nc", &irq, ravb_nc_interrupt);
+ error = ravb_setup_irq(priv, "ch1", "ch1:rx_nc", NULL, ravb_nc_interrupt);
if (error)
return error;
- error = ravb_setup_irq(priv, "ch18", "ch18:tx_be", &irq, ravb_be_interrupt);
+ error = ravb_setup_irq(priv, "ch18", "ch18:tx_be", NULL, ravb_be_interrupt);
if (error)
return error;
- return ravb_setup_irq(priv, "ch19", "ch19:tx_nc", &irq, ravb_nc_interrupt);
+ return ravb_setup_irq(priv, "ch19", "ch19:tx_nc", NULL, ravb_nc_interrupt);
}
static int ravb_probe(struct platform_device *pdev)
--
2.39.2
From: Claudiu Beznea <[email protected]>
Keep the reverse order of operations in ravb_close() when compared with
ravb_open(). This is the recommended configuration sequence.
Signed-off-by: Claudiu Beznea <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
---
Changes since [2]:
- none
Changes in v3 of [2]:
- fixed typos in patch description
- collected tags
Changes in v2 of [2]:
- none; this patch is new
[2] https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/renesas/ravb_main.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index e235342e0827..0f38e127ad45 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2228,6 +2228,14 @@ static int ravb_close(struct net_device *ndev)
ravb_write(ndev, 0, RIC2);
ravb_write(ndev, 0, TIC);
+ /* PHY disconnect */
+ if (ndev->phydev) {
+ phy_stop(ndev->phydev);
+ phy_disconnect(ndev->phydev);
+ if (of_phy_is_fixed_link(np))
+ of_phy_deregister_fixed_link(np);
+ }
+
/* Stop PTP Clock driver */
if (info->gptp || info->ccc_gac)
ravb_ptp_stop(ndev);
@@ -2246,14 +2254,6 @@ static int ravb_close(struct net_device *ndev)
}
}
- /* PHY disconnect */
- if (ndev->phydev) {
- phy_stop(ndev->phydev);
- phy_disconnect(ndev->phydev);
- if (of_phy_is_fixed_link(np))
- of_phy_deregister_fixed_link(np);
- }
-
cancel_work_sync(&priv->work);
if (info->nc_queues)
--
2.39.2
From: Claudiu Beznea <[email protected]>
Do not apply the RX checksum settings to hardware if the interface is down.
In case runtime PM is enabled, and while the interface is down, the IP will
be in reset mode (as for some platforms disabling the clocks will switch
the IP to reset mode, which will lead to losing registers content) and
applying settings in reset mode is not an option. Instead, cache the RX
checksum settings and apply them in ravb_open() through ravb_emac_init().
This has been solved by introducing pm_runtime_active() check. The device
runtime PM usage counter has been incremented to avoid disabling the device
clocks while the check is in progress (if any).
Commit prepares for the addition of runtime PM.
Signed-off-by: Claudiu Beznea <[email protected]>
---
Changes since [2]:
- use pm_runtime_get_noresume() and pm_runtime_active() and updated the
commit message to describe that
- fixed typos
- s/CSUM/checksum in patch title and description
Changes in v3 of [2]:
- this was patch 20/21 in v2
- fixed typos in patch description
- removed code from ravb_open()
- use ndev->flags & IFF_UP checks instead of netif_running()
Changes in v2 of [2]:
- none; this patch is new
[2] https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/renesas/ravb_main.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 4f8d5c9e9e03..df47d3e057c5 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2385,8 +2385,14 @@ static int ravb_change_mtu(struct net_device *ndev, int new_mtu)
static void ravb_set_rx_csum(struct net_device *ndev, bool enable)
{
struct ravb_private *priv = netdev_priv(ndev);
+ struct device *dev = &priv->pdev->dev;
unsigned long flags;
+ pm_runtime_get_noresume(dev);
+
+ if (!pm_runtime_active(dev))
+ goto out_rpm_put;
+
spin_lock_irqsave(&priv->lock, flags);
/* Disable TX and RX */
@@ -2399,6 +2405,9 @@ static void ravb_set_rx_csum(struct net_device *ndev, bool enable)
ravb_rcv_snd_enable(ndev);
spin_unlock_irqrestore(&priv->lock, flags);
+
+out_rpm_put:
+ pm_runtime_put_noidle(dev);
}
static int ravb_set_features_gbeth(struct net_device *ndev,
--
2.39.2
From: Claudiu Beznea <[email protected]>
Return the cached statistics in case the interface is down. There should be
no drawback to this, as cached statistics are updated in ravb_close().
In order to avoid accessing the IP registers while the IP is runtime
suspended pm_runtime_active() check was introduced. The device runtime
PM usage counter has been incremented to avoid disabling the device clocks
while the check is in progress (if any).
The commit prepares the code for the addition of runtime PM support.
Suggested-by: Sergey Shtylyov <[email protected]>
Signed-off-by: Claudiu Beznea <[email protected]>
---
Changes since [2]:
- use pm_runtime_get_noresume() and pm_runtime_active()
Changes in v3 of [2]:
- this was patch 18/21 in v2
- use ndev->flags & IFF_UP instead of netif_running checks
Changes in v2 of [2]:
- none; this patch is new
[2] https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/renesas/ravb_main.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 0f38e127ad45..4f8d5c9e9e03 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2155,8 +2155,15 @@ static struct net_device_stats *ravb_get_stats(struct net_device *ndev)
struct ravb_private *priv = netdev_priv(ndev);
const struct ravb_hw_info *info = priv->info;
struct net_device_stats *nstats, *stats0, *stats1;
+ struct device *dev = &priv->pdev->dev;
nstats = &ndev->stats;
+
+ pm_runtime_get_noresume(dev);
+
+ if (!pm_runtime_active(dev))
+ goto out_rpm_put;
+
stats0 = &priv->stats[RAVB_BE];
if (info->tx_counters) {
@@ -2198,6 +2205,8 @@ static struct net_device_stats *ravb_get_stats(struct net_device *ndev)
nstats->rx_over_errors += stats1->rx_over_errors;
}
+out_rpm_put:
+ pm_runtime_put_noidle(dev);
return nstats;
}
@@ -2265,6 +2274,9 @@ static int ravb_close(struct net_device *ndev)
if (info->nc_queues)
ravb_ring_free(ndev, RAVB_NC);
+ /* Update statistics. */
+ ravb_get_stats(ndev);
+
/* Set reset mode. */
return ravb_set_opmode(ndev, CCC_OPC_RESET);
}
--
2.39.2
From: Claudiu Beznea <[email protected]>
Add runtime PM support for the ravb driver. As the driver is used by
different IP variants, with different behaviors, to be able to have the
runtime PM support available for all devices, the preparatory commits
moved all the resources parsing and allocations in the driver's probe
function and kept the settings for ravb_open(). This is due to the fact
that on some IP variants-platforms tuples disabling/enabling the clocks
will switch the IP to the reset operation mode where registers' content is
lost and reconfiguration needs to be done. For this the rabv_open()
function enables the clocks, switches the IP to configuration mode, applies
all the registers settings and switches the IP to the operational mode. At
the end of ravb_open() IP is ready to send/receive data.
In ravb_close() necessary reverts are done (compared with ravb_open()), the
IP is switched to reset mode and clocks are disabled.
The ethtool APIs or IOCTLs that might execute while the interface is down
are either cached (and applied in ravb_open()) or rejected (as at that time
the IP is in reset mode). Keeping the IP in the reset mode also increases
the power saved (according to the hardware manual).
Signed-off-by: Claudiu Beznea <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
---
Changes since [2]:
- none
- didn't returned directly the ret code of pm_runtime_put_autosuspend()
as, in theory, it might return 1 in case device is suspended through
this calltrace:
pm_runtime_put_autosuspend() ->
__pm_runtime_suspend() ->
rpm_suspend() ->
rpm_check_suspend_allowed()
Changes in v3 of [2]:
- this was patch 21/21 in v2
- collected tags
- fixed typos in patch description
Changes in v2 of [2]:
- keep RPM support for all platforms
[2] https://lore.kernel.org/all/[email protected]/
drivers/net/ethernet/renesas/ravb_main.c | 54 ++++++++++++++++++++++--
1 file changed, 50 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index df47d3e057c5..a7381a90b739 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1879,16 +1879,21 @@ static int ravb_open(struct net_device *ndev)
{
struct ravb_private *priv = netdev_priv(ndev);
const struct ravb_hw_info *info = priv->info;
+ struct device *dev = &priv->pdev->dev;
int error;
napi_enable(&priv->napi[RAVB_BE]);
if (info->nc_queues)
napi_enable(&priv->napi[RAVB_NC]);
+ error = pm_runtime_resume_and_get(dev);
+ if (error < 0)
+ goto out_napi_off;
+
/* Set AVB config mode */
error = ravb_set_config_mode(ndev);
if (error)
- goto out_napi_off;
+ goto out_rpm_put;
ravb_set_delay_mode(ndev);
ravb_write(ndev, priv->desc_bat_dma, DBAT);
@@ -1922,6 +1927,9 @@ static int ravb_open(struct net_device *ndev)
ravb_stop_dma(ndev);
out_set_reset:
ravb_set_opmode(ndev, CCC_OPC_RESET);
+out_rpm_put:
+ pm_runtime_mark_last_busy(dev);
+ pm_runtime_put_autosuspend(dev);
out_napi_off:
if (info->nc_queues)
napi_disable(&priv->napi[RAVB_NC]);
@@ -2229,6 +2237,8 @@ static int ravb_close(struct net_device *ndev)
struct ravb_private *priv = netdev_priv(ndev);
const struct ravb_hw_info *info = priv->info;
struct ravb_tstamp_skb *ts_skb, *ts_skb2;
+ struct device *dev = &priv->pdev->dev;
+ int error;
netif_tx_stop_all_queues(ndev);
@@ -2278,7 +2288,14 @@ static int ravb_close(struct net_device *ndev)
ravb_get_stats(ndev);
/* Set reset mode. */
- return ravb_set_opmode(ndev, CCC_OPC_RESET);
+ error = ravb_set_opmode(ndev, CCC_OPC_RESET);
+ if (error)
+ return error;
+
+ pm_runtime_mark_last_busy(dev);
+ pm_runtime_put_autosuspend(dev);
+
+ return 0;
}
static int ravb_hwtstamp_get(struct net_device *ndev, struct ifreq *req)
@@ -2779,6 +2796,8 @@ static int ravb_probe(struct platform_device *pdev)
clk_prepare(priv->refclk);
platform_set_drvdata(pdev, ndev);
+ pm_runtime_set_autosuspend_delay(&pdev->dev, 100);
+ pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_enable(&pdev->dev);
error = pm_runtime_resume_and_get(&pdev->dev);
if (error < 0)
@@ -2884,6 +2903,9 @@ static int ravb_probe(struct platform_device *pdev)
netdev_info(ndev, "Base address at %#x, %pM, IRQ %d.\n",
(u32)ndev->base_addr, ndev->dev_addr, ndev->irq);
+ pm_runtime_mark_last_busy(&pdev->dev);
+ pm_runtime_put_autosuspend(&pdev->dev);
+
return 0;
out_napi_del:
@@ -2901,6 +2923,7 @@ static int ravb_probe(struct platform_device *pdev)
pm_runtime_put(&pdev->dev);
out_rpm_disable:
pm_runtime_disable(&pdev->dev);
+ pm_runtime_dont_use_autosuspend(&pdev->dev);
clk_unprepare(priv->refclk);
out_reset_assert:
reset_control_assert(rstc);
@@ -2914,6 +2937,12 @@ static void ravb_remove(struct platform_device *pdev)
struct net_device *ndev = platform_get_drvdata(pdev);
struct ravb_private *priv = netdev_priv(ndev);
const struct ravb_hw_info *info = priv->info;
+ struct device *dev = &priv->pdev->dev;
+ int error;
+
+ error = pm_runtime_resume_and_get(dev);
+ if (error < 0)
+ return;
unregister_netdev(ndev);
if (info->nc_queues)
@@ -2925,8 +2954,9 @@ static void ravb_remove(struct platform_device *pdev)
dma_free_coherent(ndev->dev.parent, priv->desc_bat_size, priv->desc_bat,
priv->desc_bat_dma);
- pm_runtime_put_sync(&pdev->dev);
+ pm_runtime_put_sync_suspend(&pdev->dev);
pm_runtime_disable(&pdev->dev);
+ pm_runtime_dont_use_autosuspend(dev);
clk_unprepare(priv->refclk);
reset_control_assert(priv->rstc);
free_netdev(ndev);
@@ -3008,6 +3038,10 @@ static int ravb_suspend(struct device *dev)
if (ret)
return ret;
+ ret = pm_runtime_force_suspend(&priv->pdev->dev);
+ if (ret)
+ return ret;
+
reset_assert:
return reset_control_assert(priv->rstc);
}
@@ -3030,16 +3064,28 @@ static int ravb_resume(struct device *dev)
ret = ravb_wol_restore(ndev);
if (ret)
return ret;
+ } else {
+ ret = pm_runtime_force_resume(dev);
+ if (ret)
+ return ret;
}
/* Reopening the interface will restore the device to the working state. */
ret = ravb_open(ndev);
if (ret < 0)
- return ret;
+ goto out_rpm_put;
ravb_set_rx_mode(ndev);
netif_device_attach(ndev);
+ return 0;
+
+out_rpm_put:
+ if (!priv->wol_enabled) {
+ pm_runtime_mark_last_busy(dev);
+ pm_runtime_put_autosuspend(dev);
+ }
+
return ret;
}
--
2.39.2
On 2/7/24 3:07 PM, Claudiu wrote:
> From: Claudiu Beznea <[email protected]>
>
> Return the cached statistics in case the interface is down. There should be
> no drawback to this, as cached statistics are updated in ravb_close().
>
> In order to avoid accessing the IP registers while the IP is runtime
> suspended pm_runtime_active() check was introduced. The device runtime
> PM usage counter has been incremented to avoid disabling the device clocks
> while the check is in progress (if any).
>
> The commit prepares the code for the addition of runtime PM support.
>
> Suggested-by: Sergey Shtylyov <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
[...]
MBR, Sergey
On 2/7/24 3:07 PM, Claudiu wrote:
> From: Claudiu Beznea <[email protected]>
>
> Do not apply the RX checksum settings to hardware if the interface is down.
> In case runtime PM is enabled, and while the interface is down, the IP will
> be in reset mode (as for some platforms disabling the clocks will switch
> the IP to reset mode, which will lead to losing registers content) and
The register contents? I thought I'd pointed out all of these...
> applying settings in reset mode is not an option. Instead, cache the RX
> checksum settings and apply them in ravb_open() through ravb_emac_init().
> This has been solved by introducing pm_runtime_active() check. The device
> runtime PM usage counter has been incremented to avoid disabling the device
> clocks while the check is in progress (if any).
>
> Commit prepares for the addition of runtime PM.
>
> Signed-off-by: Claudiu Beznea <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
I'm afraid such check now needs to be added to ravb_set_features_gbeth()
that's populated by Biju Das' checksum patches (which I've already ACKed)...
[...]
MBR, Sergey
Hi Sergey,
> -----Original Message-----
> From: Sergey Shtylyov <[email protected]>
> Sent: Wednesday, February 7, 2024 8:50 PM
> Subject: Re: [PATCH net-next 4/5] net: ravb: Do not apply RX checksum
> settings to hardware if the interface is down
>
> On 2/7/24 3:07 PM, Claudiu wrote:
>
> > From: Claudiu Beznea <[email protected]>
> >
> > Do not apply the RX checksum settings to hardware if the interface is
> down.
> > In case runtime PM is enabled, and while the interface is down, the IP
> > will be in reset mode (as for some platforms disabling the clocks will
> > switch the IP to reset mode, which will lead to losing registers
> > content) and
>
> The register contents? I thought I'd pointed out all of these...
>
> > applying settings in reset mode is not an option. Instead, cache the
> > RX checksum settings and apply them in ravb_open() through
> ravb_emac_init().
> > This has been solved by introducing pm_runtime_active() check. The
> > device runtime PM usage counter has been incremented to avoid
> > disabling the device clocks while the check is in progress (if any).
> >
> > Commit prepares for the addition of runtime PM.
> >
> > Signed-off-by: Claudiu Beznea <[email protected]>
>
> Reviewed-by: Sergey Shtylyov <[email protected]>
>
> I'm afraid such check now needs to be added to
> ravb_set_features_gbeth() that's populated by Biju Das' checksum patches
> (which I've already ACKed)...
You mean this check to be moved to ravb_set_features_rcar() instead of ravb_set_rx_csum()
as ravb_set_rx_csum() is called in receive path as well which is interface up case.
ON reset mode, anyway we don't get any interrupts so there is no rx.
Then possibility is through set_features??
Cheers,
Biju
> -----Original Message-----
> From: Biju Das <[email protected]>
> Sent: Thursday, February 8, 2024 8:09 AM
> Subject: RE: [PATCH net-next 4/5] net: ravb: Do not apply RX checksum
> settings to hardware if the interface is down
>
> Hi Sergey,
>
> > -----Original Message-----
> > From: Sergey Shtylyov <[email protected]>
> > Sent: Wednesday, February 7, 2024 8:50 PM
> > Subject: Re: [PATCH net-next 4/5] net: ravb: Do not apply RX checksum
> > settings to hardware if the interface is down
> >
> > On 2/7/24 3:07 PM, Claudiu wrote:
> >
> > > From: Claudiu Beznea <[email protected]>
> > >
> > > Do not apply the RX checksum settings to hardware if the interface
> > > is
> > down.
> > > In case runtime PM is enabled, and while the interface is down, the
> > > IP will be in reset mode (as for some platforms disabling the clocks
> > > will switch the IP to reset mode, which will lead to losing
> > > registers
> > > content) and
> >
> > The register contents? I thought I'd pointed out all of these...
> >
> > > applying settings in reset mode is not an option. Instead, cache the
> > > RX checksum settings and apply them in ravb_open() through
> > ravb_emac_init().
> > > This has been solved by introducing pm_runtime_active() check. The
> > > device runtime PM usage counter has been incremented to avoid
> > > disabling the device clocks while the check is in progress (if any).
> > >
> > > Commit prepares for the addition of runtime PM.
> > >
> > > Signed-off-by: Claudiu Beznea <[email protected]>
> >
> > Reviewed-by: Sergey Shtylyov <[email protected]>
> >
> > I'm afraid such check now needs to be added to
> > ravb_set_features_gbeth() that's populated by Biju Das' checksum
> > patches (which I've already ACKed)...
>
> You mean this check to be moved to ravb_set_features_rcar() instead of
> ravb_set_rx_csum() as ravb_set_rx_csum() is called in receive path as well
> which is interface up case.
> ON reset mode, anyway we don't get any interrupts so there is no rx.
> Then possibility is through set_features??
Or are you suggesting to have a common code to avoid code duplication?
On interface down case, just cache the feature and return?
Active cases, call the family specific callback()?
Cheers,
Biju
On 2/7/24 3:07 PM, Claudiu wrote:
> From: Claudiu Beznea <[email protected]>
>
> The 4th argument of ravb_setup_irq() is used to save the IRQ number that
> will be further used by the driver code. Not all ravb_setup_irqs() calls
> need to save the IRQ number. The previous code used to pass a dummy
> variable as the 4th argument in case the IRQ is not needed for further
> usage. That is not necessary as the code from ravb_setup_irq() can detect
> by itself if the IRQ needs to be saved. Thus, get rid of the code that is
> not needed.
>
> Reported-by: Sergey Shtylyov <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 9521cd054274..e235342e0827 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -2611,17 +2611,20 @@ static int ravb_setup_irq(struct ravb_private *priv, const char *irq_name,
> if (!dev_name)
> return -ENOMEM;
>
> - *irq = platform_get_irq_byname(pdev, irq_name);
> + error = platform_get_irq_byname(pdev, irq_name);
> flags = 0;
> } else {
> dev_name = ndev->name;
> - *irq = platform_get_irq(pdev, 0);
> + error = platform_get_irq(pdev, 0);
> flags = IRQF_SHARED;
> }
> - if (*irq < 0)
> - return *irq;
> + if (error < 0)
> + return error;
>
> - error = devm_request_irq(dev, *irq, handler, flags, dev_name, ndev);
> + if (irq)
> + *irq = error;
> +
> + error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
> if (error)
> netdev_err(ndev, "cannot request IRQ %s\n", dev_name);
>
Thanks for addressing my IRC comment! Tho the naming seems awful. :-)
I'd suggest to add a local variable (named e.g. irq_num) and use it to
store the result of platform_get_irq[_byname]().
[...]
MBR, Sergey
On 2/7/24 3:07 PM, Claudiu wrote:
> From: Claudiu Beznea <[email protected]>
>
> The 4th argument of ravb_setup_irq() is used to save the IRQ number that
> will be further used by the driver code. Not all ravb_setup_irqs() calls
> need to save the IRQ number. The previous code used to pass a dummy
> variable as the 4th argument in case the IRQ is not needed for further
> usage. That is not necessary as the code from ravb_setup_irq() can detect
> by itself if the IRQ needs to be saved. Thus, get rid of the code that is
> not needed.
>
> Reported-by: Sergey Shtylyov <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 9521cd054274..e235342e0827 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -2611,17 +2611,20 @@ static int ravb_setup_irq(struct ravb_private *priv, const char *irq_name,
> if (!dev_name)
> return -ENOMEM;
>
> - *irq = platform_get_irq_byname(pdev, irq_name);
> + error = platform_get_irq_byname(pdev, irq_name);
> flags = 0;
> } else {
> dev_name = ndev->name;
> - *irq = platform_get_irq(pdev, 0);
> + error = platform_get_irq(pdev, 0);
> flags = IRQF_SHARED;
> }
> - if (*irq < 0)
> - return *irq;
> + if (error < 0)
> + return error;
>
> - error = devm_request_irq(dev, *irq, handler, flags, dev_name, ndev);
> + if (irq)
> + *irq = error;
> +
> + error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
> if (error)
> netdev_err(ndev, "cannot request IRQ %s\n", dev_name);
>
Thanks for addressing my IRC comment! Tho the naming seems awful. :-)
I'd suggest to add a local variable (named e.g, irq_num) and use it to
store the result of platform_get_irq[_byname]().
[...]
MBR, Sergey
On 07.02.2024 22:50, Sergey Shtylyov wrote:
> On 2/7/24 3:07 PM, Claudiu wrote:
>
>> From: Claudiu Beznea <[email protected]>
>>
>> Do not apply the RX checksum settings to hardware if the interface is down.
>> In case runtime PM is enabled, and while the interface is down, the IP will
>> be in reset mode (as for some platforms disabling the clocks will switch
>> the IP to reset mode, which will lead to losing registers content) and
>
> The register contents? I thought I'd pointed out all of these...
>
>> applying settings in reset mode is not an option. Instead, cache the RX
>> checksum settings and apply them in ravb_open() through ravb_emac_init().
>> This has been solved by introducing pm_runtime_active() check. The device
>> runtime PM usage counter has been incremented to avoid disabling the device
>> clocks while the check is in progress (if any).
>>
>> Commit prepares for the addition of runtime PM.
>>
>> Signed-off-by: Claudiu Beznea <[email protected]>
>
> Reviewed-by: Sergey Shtylyov <[email protected]>
>
> I'm afraid such check now needs to be added to ravb_set_features_gbeth()
> that's populated by Biju Das' checksum patches (which I've already ACKed)...
Yes, it's on my radar. I'll check it and update it (if any) in the next
version.
Thank you,
Claudiu Beznea
>
> [...]
>
> MBR, Sergey
On 08.02.2024 22:43, Sergey Shtylyov wrote:
> On 2/7/24 3:07 PM, Claudiu wrote:
>
>> From: Claudiu Beznea <[email protected]>
>>
>> The 4th argument of ravb_setup_irq() is used to save the IRQ number that
>> will be further used by the driver code. Not all ravb_setup_irqs() calls
>> need to save the IRQ number. The previous code used to pass a dummy
>> variable as the 4th argument in case the IRQ is not needed for further
>> usage. That is not necessary as the code from ravb_setup_irq() can detect
>> by itself if the IRQ needs to be saved. Thus, get rid of the code that is
>> not needed.
>>
>> Reported-by: Sergey Shtylyov <[email protected]>
>> Signed-off-by: Claudiu Beznea <[email protected]>
> [...]
>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>> index 9521cd054274..e235342e0827 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -2611,17 +2611,20 @@ static int ravb_setup_irq(struct ravb_private *priv, const char *irq_name,
>> if (!dev_name)
>> return -ENOMEM;
>>
>> - *irq = platform_get_irq_byname(pdev, irq_name);
>> + error = platform_get_irq_byname(pdev, irq_name);
>> flags = 0;
>> } else {
>> dev_name = ndev->name;
>> - *irq = platform_get_irq(pdev, 0);
>> + error = platform_get_irq(pdev, 0);
>> flags = IRQF_SHARED;
>> }
>> - if (*irq < 0)
>> - return *irq;
>> + if (error < 0)
>> + return error;
>>
>> - error = devm_request_irq(dev, *irq, handler, flags, dev_name, ndev);
>> + if (irq)
>> + *irq = error;
>> +
>> + error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
>> if (error)
>> netdev_err(ndev, "cannot request IRQ %s\n", dev_name);
>>
>
> Thanks for addressing my IRC comment! Tho the naming seems awful. :-)
> I'd suggest to add a local variable (named e.g, irq_num) and use it to
I tried to avoid that...
> store the result of platform_get_irq[_byname]().
>
> [...]
>
> MBR, Sergey
On 2/9/24 8:48 AM, claudiu beznea wrote:
[...]
>>> From: Claudiu Beznea <[email protected]>
>>>
>>> The 4th argument of ravb_setup_irq() is used to save the IRQ number that
>>> will be further used by the driver code. Not all ravb_setup_irqs() calls
>>> need to save the IRQ number. The previous code used to pass a dummy
>>> variable as the 4th argument in case the IRQ is not needed for further
>>> usage. That is not necessary as the code from ravb_setup_irq() can detect
>>> by itself if the IRQ needs to be saved. Thus, get rid of the code that is
>>> not needed.
>>>
>>> Reported-by: Sergey Shtylyov <[email protected]>
>>> Signed-off-by: Claudiu Beznea <[email protected]>
>> [...]
>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>>> index 9521cd054274..e235342e0827 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>>> @@ -2611,17 +2611,20 @@ static int ravb_setup_irq(struct ravb_private *priv, const char *irq_name,
>>> if (!dev_name)
>>> return -ENOMEM;
>>>
>>> - *irq = platform_get_irq_byname(pdev, irq_name);
>>> + error = platform_get_irq_byname(pdev, irq_name);
>>> flags = 0;
>>> } else {
>>> dev_name = ndev->name;
>>> - *irq = platform_get_irq(pdev, 0);
>>> + error = platform_get_irq(pdev, 0);
>>> flags = IRQF_SHARED;
>>> }
>>> - if (*irq < 0)
>>> - return *irq;
>>> + if (error < 0)
>>> + return error;
>>>
>>> - error = devm_request_irq(dev, *irq, handler, flags, dev_name, ndev);
>>> + if (irq)
>>> + *irq = error;
>>> +
>>> + error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
>>> if (error)
>>> netdev_err(ndev, "cannot request IRQ %s\n", dev_name);
>>>
>>
>> Thanks for addressing my IRC comment! Tho the naming seems awful. :-)
if (error < 0)
return error;
if (irq)
*irq = error;
error = devm_request_irq(dev, error, handler, flags, dev_name, ndev);
These just don't look right...
>> I'd suggest to add a local variable (named e.g, irq_num) and use it to
>
> I tried to avoid that...
Why? :-)
>> store the result of platform_get_irq[_byname]().
>>
>> [...]
MBR, Sergey