2014-02-25 15:47:10

by Adam Jackson

Subject: [PATCH] i8042: Don't print an error message just because there's no chip

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an
i8042 to initialize. We shouldn't be printing an error message in this
case, since not detecting the chip is the correct behavior.

v2: Downgrade to pr_notice instead of pr_err.

Signed-off-by: Adam Jackson <[email protected]>
---
drivers/input/serio/i8042.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 020053f..05c6285 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
static int i8042_controller_check(void)
{
if (i8042_flush()) {
- pr_err("No controller found\n");
+ pr_notice("No controller found\n");
return -ENODEV;
}

--
1.8.5.3

2014-02-25 16:06:43

by Josh Boyer

Subject: Re: [PATCH] i8042: Don't print an error message just because there's no chip

On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <[email protected]> wrote:
> From: Peter Jones <[email protected]>
>
> Some systems, such as EFI-based Apple systems, won't necessarily have an
> i8042 to initialize. We shouldn't be printing an error message in this
> case, since not detecting the chip is the correct behavior.
>
> v2: Downgrade to pr_notice instead of pr_err.
>
> Signed-off-by: Adam Jackson <[email protected]>

Reviewed-by: Josh Boyer <[email protected]>

> ---
> drivers/input/serio/i8042.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index 020053f..05c6285 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
> static int i8042_controller_check(void)
> {
> if (i8042_flush()) {
> - pr_err("No controller found\n");
> + pr_notice("No controller found\n");
> return -ENODEV;
> }
>

2014-06-03 13:53:59

by Adam Jackson

Subject: Re: [PATCH] i8042: Don't print an error message just because there's no chip

On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote:
> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <[email protected]> wrote:
> > From: Peter Jones <[email protected]>
> >
> > Some systems, such as EFI-based Apple systems, won't necessarily have an
> > i8042 to initialize. We shouldn't be printing an error message in this
> > case, since not detecting the chip is the correct behavior.
> >
> > v2: Downgrade to pr_notice instead of pr_err.
> >
> > Signed-off-by: Adam Jackson <[email protected]>
>
> Reviewed-by: Josh Boyer <[email protected]>

Ping? This patch or something like it has been pending since 2008 [1],
would be nice to see it merged before it's old enough to start first
grade.

[1] - https://lkml.org/lkml/2008/9/29/248

- ajax

2014-06-03 14:00:25

by Benjamin Tissoires

Subject: Re: [PATCH] i8042: Don't print an error message just because there's no chip

On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson <[email protected]> wrote:
> On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote:
>> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <[email protected]> wrote:
>> > From: Peter Jones <[email protected]>
>> >
>> > Some systems, such as EFI-based Apple systems, won't necessarily have an
>> > i8042 to initialize. We shouldn't be printing an error message in this
>> > case, since not detecting the chip is the correct behavior.
>> >
>> > v2: Downgrade to pr_notice instead of pr_err.
>> >
>> > Signed-off-by: Adam Jackson <[email protected]>
>>
>> Reviewed-by: Josh Boyer <[email protected]>
>
> Ping? This patch or something like it has been pending since 2008 [1],
> would be nice to see it merged before it's old enough to start first
> grade.
>
> [1] - https://lkml.org/lkml/2008/9/29/248
>

Hey Ajax,

regarding the input stuff, adding the maintainers always help.
So adding Dmitry in CC.

BTW, the patch looks good enough:
Reviewed-by: Benjamin Tissoires <[email protected]>

Cheers,
Benjamin