2014-06-28 21:47:32

by Rickard Strandqvist

Subject: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused

Removal of a struct that is never used

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/pinctrl/pinctrl-imx27.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c
index 417c992..27ae7ce 100644
--- a/drivers/pinctrl/pinctrl-imx27.c
+++ b/drivers/pinctrl/pinctrl-imx27.c
@@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = {
{ /* sentinel */ }
};

-struct imx27_pinctrl_private {
- int num_gpio_childs;
- struct platform_device **gpio_dev;
- struct mxc_gpio_platform_data *gpio_pdata;
-};
-
static int imx27_pinctrl_probe(struct platform_device *pdev)
{
return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info);
--
1.7.10.4

2014-07-01 07:07:26

by Sascha Hauer

Subject: Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused

On Sat, Jun 28, 2014 at 11:48:40PM +0200, Rickard Strandqvist wrote:
> Removal of a struct that is never used
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

It wasn't even used on the initial commit introducing it.

Acked-by: Sascha Hauer <[email protected]>

Sascha

> ---
> drivers/pinctrl/pinctrl-imx27.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c
> index 417c992..27ae7ce 100644
> --- a/drivers/pinctrl/pinctrl-imx27.c
> +++ b/drivers/pinctrl/pinctrl-imx27.c
> @@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = {
> { /* sentinel */ }
> };
>
> -struct imx27_pinctrl_private {
> - int num_gpio_childs;
> - struct platform_device **gpio_dev;
> - struct mxc_gpio_platform_data *gpio_pdata;
> -};
> -
> static int imx27_pinctrl_probe(struct platform_device *pdev)
> {
> return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2014-07-08 08:29:16

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused

On Sat, Jun 28, 2014 at 11:48 PM, Rickard Strandqvist
<[email protected]> wrote:

> Removal of a struct that is never used
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Already removed in a similar patch from Alexander Shiyan, but thanks
anyway!

Yours,
Linus Walleij