2014-07-05 12:14:09

by Rickard Strandqvist

Subject: [PATCH] video: fbdev: aty: atyfb_base.c: Cleaning up variable that is never used

From: Rickard Strandqvist <[email protected]>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/video/fbdev/aty/atyfb_base.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index c3d0074..46188a4 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -3088,7 +3088,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
if (dp == of_console_device) {
struct fb_var_screeninfo *var = &default_var;
unsigned int N, P, Q, M, T, R;
- u32 v_total, h_total;
struct crtc crtc;
u8 pll_regs[16];
u8 clock_cntl;
@@ -3104,9 +3103,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
aty_crtc_to_var(&crtc, var);

- h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
- v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
-
/*
* Read the PLL to figure actual Refresh Rate.
*/
--
1.7.10.4

2014-07-05 14:42:01

by Mikulas Patocka

Subject: Re: [PATCH] video: fbdev: aty: atyfb_base.c: Cleaning up variable that is never used

On Sat, 5 Jul 2014, Rickard Strandqvist wrote:

> From: Rickard Strandqvist <[email protected]>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Acked-by: Mikulas Patocka <[email protected]>

> ---
> drivers/video/fbdev/aty/atyfb_base.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
> index c3d0074..46188a4 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -3088,7 +3088,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> if (dp == of_console_device) {
> struct fb_var_screeninfo *var = &default_var;
> unsigned int N, P, Q, M, T, R;
> - u32 v_total, h_total;
> struct crtc crtc;
> u8 pll_regs[16];
> u8 clock_cntl;
> @@ -3104,9 +3103,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
> aty_crtc_to_var(&crtc, var);
>
> - h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
> - v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
> -
> /*
> * Read the PLL to figure actual Refresh Rate.
> */
> --
> 1.7.10.4
>