2014-07-20 00:44:12

by Sam Asadi

Subject: [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed

A 'Missing a blank line after declarations' issue fixed and also tested
by 'make M=...'. It seems that after 'unsigned long iobase' declaration
a blank line is desperately needed.

Signed-off-by: Sam Asadi <[email protected]>
---
drivers/staging/comedi/drivers/8255.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
index 46113a3..e591441 100644
--- a/drivers/staging/comedi/drivers/8255.c
+++ b/drivers/staging/comedi/drivers/8255.c
@@ -94,6 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.

struct subdev_8255_private {
unsigned long iobase;
+
int (*io)(int, int, int, unsigned long);
};

--
1.9.1

2014-07-20 01:11:23

by Joe Perches

Subject: Re: [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed

On Sun, 2014-07-20 at 03:43 +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' issue fixed and also tested
> by 'make M=...'. It seems that after 'unsigned long iobase' declaration
> a blank line is desperately needed.
[]
> diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
[]
> @@ -94,6 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
>
> struct subdev_8255_private {
> unsigned long iobase;
> +
> int (*io)(int, int, int, unsigned long);
> };
>

You used an old version of checkpatch without a
modification to the "blank line after declarations"
test that supports function pointers.

Use the latest version from --next instead.