2020-05-11 09:14:11

by Daniel Vetter

Subject: [PATCH 1/3] drm/writeback: don't set fence->ops to default

It's the default.

Signed-off-by: Daniel Vetter <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
---
drivers/gpu/drm/drm_writeback.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index 43d9e3bb3a94..dccf4504f1bb 100644
--- a/drivers/gpu/drm/drm_writeback.c
+++ b/drivers/gpu/drm/drm_writeback.c
@@ -108,7 +108,6 @@ static const struct dma_fence_ops drm_writeback_fence_ops = {
.get_driver_name = drm_writeback_fence_get_driver_name,
.get_timeline_name = drm_writeback_fence_get_timeline_name,
.enable_signaling = drm_writeback_fence_enable_signaling,
- .wait = dma_fence_default_wait,
};

static int create_writeback_properties(struct drm_device *dev)
--
2.26.2

2020-05-11 18:14:18

by Michael J. Ruhl

Subject: RE: [PATCH 1/3] drm/writeback: don't set fence->ops to default

>-----Original Message-----
>From: dri-devel <[email protected]> On Behalf Of
>Daniel Vetter
>Sent: Monday, May 11, 2020 5:12 AM
>To: LKML <[email protected]>
>Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>;
>Intel Graphics Development <[email protected]>; DRI
>Development <[email protected]>; Thomas Zimmermann
><[email protected]>; Vetter, Daniel <[email protected]>
>Subject: [PATCH 1/3] drm/writeback: don't set fence->ops to default
>
>It's the default.

I can get behind that. ????

Reviewed-by: Michael J. Ruhl <[email protected]>

>Signed-off-by: Daniel Vetter <[email protected]>
>Cc: Maarten Lankhorst <[email protected]>
>Cc: Maxime Ripard <[email protected]>
>Cc: Thomas Zimmermann <[email protected]>
>Cc: David Airlie <[email protected]>
>Cc: Daniel Vetter <[email protected]>
>---
> drivers/gpu/drm/drm_writeback.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/drm_writeback.c
>b/drivers/gpu/drm/drm_writeback.c
>index 43d9e3bb3a94..dccf4504f1bb 100644
>--- a/drivers/gpu/drm/drm_writeback.c
>+++ b/drivers/gpu/drm/drm_writeback.c
>@@ -108,7 +108,6 @@ static const struct dma_fence_ops
>drm_writeback_fence_ops = {
> .get_driver_name = drm_writeback_fence_get_driver_name,
> .get_timeline_name = drm_writeback_fence_get_timeline_name,
> .enable_signaling = drm_writeback_fence_enable_signaling,
>- .wait = dma_fence_default_wait,
> };
>
> static int create_writeback_properties(struct drm_device *dev)
>--
>2.26.2
>
>_______________________________________________
>dri-devel mailing list
>[email protected]
>https://lists.freedesktop.org/mailman/listinfo/dri-devel

2020-05-20 18:05:33

by Daniel Vetter

Subject: Re: [PATCH 1/3] drm/writeback: don't set fence->ops to default

On Mon, May 11, 2020 at 06:12:32PM +0000, Ruhl, Michael J wrote:
> >-----Original Message-----
> >From: dri-devel <[email protected]> On Behalf Of
> >Daniel Vetter
> >Sent: Monday, May 11, 2020 5:12 AM
> >To: LKML <[email protected]>
> >Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>;
> >Intel Graphics Development <[email protected]>; DRI
> >Development <[email protected]>; Thomas Zimmermann
> ><[email protected]>; Vetter, Daniel <[email protected]>
> >Subject: [PATCH 1/3] drm/writeback: don't set fence->ops to default
> >
> >It's the default.
>
> I can get behind that. ????
>
> Reviewed-by: Michael J. Ruhl <[email protected]>

Applied to drm-misc-next, thanks for reviewing.
-Daniel

>
> >Signed-off-by: Daniel Vetter <[email protected]>
> >Cc: Maarten Lankhorst <[email protected]>
> >Cc: Maxime Ripard <[email protected]>
> >Cc: Thomas Zimmermann <[email protected]>
> >Cc: David Airlie <[email protected]>
> >Cc: Daniel Vetter <[email protected]>
> >---
> > drivers/gpu/drm/drm_writeback.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/drm_writeback.c
> >b/drivers/gpu/drm/drm_writeback.c
> >index 43d9e3bb3a94..dccf4504f1bb 100644
> >--- a/drivers/gpu/drm/drm_writeback.c
> >+++ b/drivers/gpu/drm/drm_writeback.c
> >@@ -108,7 +108,6 @@ static const struct dma_fence_ops
> >drm_writeback_fence_ops = {
> > .get_driver_name = drm_writeback_fence_get_driver_name,
> > .get_timeline_name = drm_writeback_fence_get_timeline_name,
> > .enable_signaling = drm_writeback_fence_enable_signaling,
> >- .wait = dma_fence_default_wait,
> > };
> >
> > static int create_writeback_properties(struct drm_device *dev)
> >--
> >2.26.2
> >
> >_______________________________________________
> >dri-devel mailing list
> >[email protected]
> >https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch