2014-07-30 16:51:32

by Fernando Apesteguia

Subject: [PATCH] Staging: vt6655: staticfy variable

From: Fernando Apesteguia <[email protected]>

Add static to variable.

Signed-off-by: Fernando Apesteguia <[email protected]>
---
drivers/staging/vt6655/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 65e5933..cc6e47b 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -41,7 +41,7 @@
static int msglevel = MSG_LEVEL_INFO;

#ifdef WPA_SM_Transtatus
-SWPAResult wpa_Result;
+static SWPAResult wpa_Result;
#endif

int private_ioctl(PSDevice pDevice, struct ifreq *rq)
--
1.7.9.5

2014-07-30 19:17:12

by Guillaume Clement

Subject: Re: [PATCH] Staging: vt6655: staticfy variable

Hello,

> Add static to variable.
> Signed-off-by: Fernando Apesteguia <[email protected]>
> ---
> drivers/staging/vt6655/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c
> b/drivers/staging/vt6655/ioctl.c
> index 65e5933..cc6e47b 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -41,7 +41,7 @@
> static int msglevel = MSG_LEVEL_INFO;
>
> #ifdef WPA_SM_Transtatus
> -SWPAResult wpa_Result;
> +static SWPAResult wpa_Result;
> #endif

This changes breaks the compilation (actually the linking). wpa_Result
is actually used in device_main.c in device_open with the following:

> #ifdef WPA_SM_Transtatus
> extern SWPAResult wpa_Result;
> #endif

2014-07-30 21:20:51

by Fernando Apesteguia

Subject: Re: [PATCH] Staging: vt6655: staticfy variable

On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <[email protected]> wrote:
> Hello,
>
>> Add static to variable.
>> Signed-off-by: Fernando Apesteguia <[email protected]>
>> ---
>> drivers/staging/vt6655/ioctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6655/ioctl.c
>> b/drivers/staging/vt6655/ioctl.c
>> index 65e5933..cc6e47b 100644
>> --- a/drivers/staging/vt6655/ioctl.c
>> +++ b/drivers/staging/vt6655/ioctl.c
>> @@ -41,7 +41,7 @@
>> static int msglevel = MSG_LEVEL_INFO;
>>
>> #ifdef WPA_SM_Transtatus
>> -SWPAResult wpa_Result;
>> +static SWPAResult wpa_Result;
>> #endif
>
> This changes breaks the compilation (actually the linking). wpa_Result
> is actually used in device_main.c in device_open with the following:

Argh... sorry, I missed that.

>
>> #ifdef WPA_SM_Transtatus
>> extern SWPAResult wpa_Result;
>> #endif

2014-07-31 00:05:10

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: vt6655: staticfy variable

On Wed, Jul 30, 2014 at 11:20:49PM +0200, Fernando Apestegu?a wrote:
> On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <[email protected]> wrote:
> > Hello,
> >
> >> Add static to variable.
> >> Signed-off-by: Fernando Apesteguia <[email protected]>
> >> ---
> >> drivers/staging/vt6655/ioctl.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6655/ioctl.c
> >> b/drivers/staging/vt6655/ioctl.c
> >> index 65e5933..cc6e47b 100644
> >> --- a/drivers/staging/vt6655/ioctl.c
> >> +++ b/drivers/staging/vt6655/ioctl.c
> >> @@ -41,7 +41,7 @@
> >> static int msglevel = MSG_LEVEL_INFO;
> >>
> >> #ifdef WPA_SM_Transtatus
> >> -SWPAResult wpa_Result;
> >> +static SWPAResult wpa_Result;
> >> #endif
> >
> > This changes breaks the compilation (actually the linking). wpa_Result
> > is actually used in device_main.c in device_open with the following:
>
> Argh... sorry, I missed that.

ALWAYS test-build your patches, don't make me be your first tester...