2014-10-11 18:32:08

by Rahul Bedarkar

Subject: [PATCH] char: misc: use pr_err instead of printk

Signed-off-by: Rahul Bedarkar <[email protected]>
---
drivers/char/misc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 75b6de9..a6b96b1 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -280,12 +280,12 @@ static int __init misc_init(void)

err = -EIO;
if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
- goto fail_printk;
+ goto fail_pr_err;
misc_class->devnode = misc_devnode;
return 0;

-fail_printk:
- printk("unable to get major %d for misc devices\n", MISC_MAJOR);
+fail_pr_err:
+ pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
class_destroy(misc_class);
fail_remove:
remove_proc_entry("misc", NULL);
--
1.8.3.2

2014-10-11 18:35:45

by Joe Perches

Subject: Re: [PATCH] char: misc: use pr_err instead of printk

On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote:
[]
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
[]
> @@ -280,12 +280,12 @@ static int __init misc_init(void)
>
> err = -EIO;
> if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
> - goto fail_printk;
> + goto fail_pr_err;
> misc_class->devnode = misc_devnode;
> return 0;
>
> -fail_printk:
> - printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +fail_pr_err:
> + pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
> class_destroy(misc_class);
> fail_remove:
> remove_proc_entry("misc", NULL);

The printk is not relevant.
Maybe the label should be "fail_destroy:"

2014-10-14 15:22:41

by Rahul Bedarkar

Subject: Re: [PATCH] char: misc: use pr_err instead of printk

On Sun, Oct 12, 2014 at 12:05 AM, Joe Perches <[email protected]> wrote:
> On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote:
> []
>> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> []
>> @@ -280,12 +280,12 @@ static int __init misc_init(void)
>>
>> err = -EIO;
>> if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
>> - goto fail_printk;
>> + goto fail_pr_err;
>> misc_class->devnode = misc_devnode;
>> return 0;
>>
>> -fail_printk:
>> - printk("unable to get major %d for misc devices\n", MISC_MAJOR);
>> +fail_pr_err:
>> + pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
>> class_destroy(misc_class);
>> fail_remove:
>> remove_proc_entry("misc", NULL);
>
> The printk is not relevant.
> Maybe the label should be "fail_destroy:"

Ok. I will split this in two separate patches one renames label first and
other use pr_err instead of printk. I will resend this patch

Thanks,
Rahul

>