2014-10-14 04:47:46

by WANG Chao

[permalink] [raw]
Subject: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

Supress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

Signed-off-by: WANG Chao <[email protected]>
---
arch/x86/purgatory/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
index f52e033..2c835e3 100644
--- a/arch/x86/purgatory/Makefile
+++ b/arch/x86/purgatory/Makefile
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@

$(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
$(call if_changed,bin2c)
+ @:


obj-$(CONFIG_KEXEC_FILE) += kexec-purgatory.o
--
1.9.3


2014-10-14 20:44:29

by Peter Foley

[permalink] [raw]
Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

On Tue, Oct 14, 2014 at 12:46 AM, WANG Chao <[email protected]> wrote:
> Supress this unnecessary message during kernel re-build
> (CONFIG_KEXEC_FILE=y):
>
> make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
>
> Signed-off-by: WANG Chao <[email protected]>

Acked-by: Peter Foley <[email protected]>

2014-10-14 21:53:08

by Vivek Goyal

[permalink] [raw]
Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> Supress this unnecessary message during kernel re-build
> (CONFIG_KEXEC_FILE=y):
>
> make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
>
> Signed-off-by: WANG Chao <[email protected]>
> ---
> arch/x86/purgatory/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> index f52e033..2c835e3 100644
> --- a/arch/x86/purgatory/Makefile
> +++ b/arch/x86/purgatory/Makefile
> @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
>
> $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> $(call if_changed,bin2c)
> + @:

Where can I find the description of "@:" and how does it work?

Thanks
Vivek

2014-10-15 02:14:46

by WANG Chao

[permalink] [raw]
Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > Supress this unnecessary message during kernel re-build
> > (CONFIG_KEXEC_FILE=y):
> >
> > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
> >
> > Signed-off-by: WANG Chao <[email protected]>
> > ---
> > arch/x86/purgatory/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > index f52e033..2c835e3 100644
> > --- a/arch/x86/purgatory/Makefile
> > +++ b/arch/x86/purgatory/Makefile
> > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
> >
> > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> > $(call if_changed,bin2c)
> > + @:
>
> Where can I find the description of "@:" and how does it work?

@ is used to suppress echo'ing. See:
https://www.gnu.org/software/make/manual/html_node/Echoing.html

This is a trick to avoid "... is up to date" message". Check out commit
a9358bc ("x86/build: Supress realmode.bin is up to date message").

Thanks
WANG Chao

2014-10-15 13:09:10

by Vivek Goyal

[permalink] [raw]
Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote:
> On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> > On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > > Supress this unnecessary message during kernel re-build
> > > (CONFIG_KEXEC_FILE=y):
> > >
> > > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
> > >
> > > Signed-off-by: WANG Chao <[email protected]>
> > > ---
> > > arch/x86/purgatory/Makefile | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > > index f52e033..2c835e3 100644
> > > --- a/arch/x86/purgatory/Makefile
> > > +++ b/arch/x86/purgatory/Makefile
> > > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
> > >
> > > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> > > $(call if_changed,bin2c)
> > > + @:
> >
> > Where can I find the description of "@:" and how does it work?
>
> @ is used to suppress echo'ing. See:
> https://www.gnu.org/software/make/manual/html_node/Echoing.html
>
> This is a trick to avoid "... is up to date" message". Check out commit
> a9358bc ("x86/build: Supress realmode.bin is up to date message").

Thanks for the explanations. Looks good to me.

Acked-by: Vivek Goyal <[email protected]>

Vivek

Subject: [tip:x86/build] x86/purgatory, build: Suppress kexec-purgatory.c is up to date message

Commit-ID: 3ea4b8ee2419e21295cabab66c317612c5a55d26
Gitweb: http://git.kernel.org/tip/3ea4b8ee2419e21295cabab66c317612c5a55d26
Author: WANG Chao <[email protected]>
AuthorDate: Tue, 14 Oct 2014 12:46:58 +0800
Committer: H. Peter Anvin <[email protected]>
CommitDate: Wed, 15 Oct 2014 08:31:21 -0700

x86/purgatory, build: Suppress kexec-purgatory.c is up to date message

Suppress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

Signed-off-by: WANG Chao <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: H. Peter Anvin <[email protected]>
---
arch/x86/purgatory/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
index 899dd24..2c41066 100644
--- a/arch/x86/purgatory/Makefile
+++ b/arch/x86/purgatory/Makefile
@@ -23,6 +23,7 @@ quiet_cmd_bin2c = BIN2C $@

$(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
$(call if_changed,bin2c)
+ @:


obj-$(CONFIG_KEXEC_FILE) += kexec-purgatory.o