2014-11-04 19:23:17

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] ipv4: add kernel parameter tcpmhash_entries

Signed-off-by: Fabian Frederick <[email protected]>
---
Documentation/kernel-parameters.txt | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 4c81a86..5f37111 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -3412,6 +3412,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
neutralize any effect of /proc/sys/kernel/sysrq.
Useful for debugging.

+ tcpmhash_entries= [KNL,NET]
+ Set tcp_metrics_hash slot number.
+ Default value is 8192 or 16384 depending on total
+ ram pages.
+
tdfx= [HW,DRM]

test_suspend= [SUSPEND][,N]
--
1.9.3

2014-11-04 19:32:53

by Jonathan Corbet

Subject: Re: [PATCH 1/1 net-next] ipv4: add kernel parameter tcpmhash_entries

On Tue, 4 Nov 2014 20:23:08 +0100
Fabian Frederick <[email protected]> wrote:

> + Set tcp_metrics_hash slot number.

So I'm not entirely clear on what that means. Did you mean "Set the
number of tcp_metrics_hash slots"? If so, that wording should be used.

Even in that case, though, what does this parameter actually *mean*? If
we're going to document the parameter (and I think we should), it would
be good to say why a user might want to change it and what effects they
would expect to see.

Care to redo with that in mind?

Thanks,

jon