2014-11-16 14:45:47

by Antonio Borneo

Subject: [PATCH] HID: i2c-hid: print the correct data in dbg msg

From: Jean-Baptiste Maneyrol <[email protected]>

From: Jean-Baptiste Maneyrol <[email protected]>

Report is received in "buffer"; fix the following i2c_hid_dbg()
to dump data from the correct pointer.

Signed-off-by: Jean-Baptiste Maneyrol <[email protected]>
[Antonio Borneo: cleanup and rebase to v3.17]
Signed-off-by: Antonio Borneo <[email protected]>
---
drivers/hid/i2c-hid/i2c-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 747d544..933bf10 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -437,7 +437,7 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer,
report->id, buffer, size))
return;

- i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
+ i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, buffer);

ret_size = buffer[0] | (buffer[1] << 8);

--
2.1.3

2014-11-17 21:32:36

by Benjamin Tissoires

Subject: Re: [PATCH] HID: i2c-hid: print the correct data in dbg msg

On Nov 16 2014 or thereabouts, Antonio Borneo wrote:
> From: Jean-Baptiste Maneyrol <[email protected]>
>
> From: Jean-Baptiste Maneyrol <[email protected]>
>
> Report is received in "buffer"; fix the following i2c_hid_dbg()
> to dump data from the correct pointer.
>
> Signed-off-by: Jean-Baptiste Maneyrol <[email protected]>
> [Antonio Borneo: cleanup and rebase to v3.17]
> Signed-off-by: Antonio Borneo <[email protected]>
> ---

Good catch.

This one is Reviewed-by: Benjamin Tissoires <[email protected]>

Cheers,
Benjamin

> drivers/hid/i2c-hid/i2c-hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 747d544..933bf10 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -437,7 +437,7 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer,
> report->id, buffer, size))
> return;
>
> - i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
> + i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, buffer);
>
> ret_size = buffer[0] | (buffer[1] << 8);
>
> --
> 2.1.3
>

2014-11-18 21:11:09

by Jiri Kosina

Subject: Re: [PATCH] HID: i2c-hid: print the correct data in dbg msg

On Sun, 16 Nov 2014, Antonio Borneo wrote:

> From: Jean-Baptiste Maneyrol <[email protected]>
>
> Report is received in "buffer"; fix the following i2c_hid_dbg()
> to dump data from the correct pointer.
>
> Signed-off-by: Jean-Baptiste Maneyrol <[email protected]>
> [Antonio Borneo: cleanup and rebase to v3.17]
> Signed-off-by: Antonio Borneo <[email protected]>

Added Benjamin's Reviewed-by and applied, thanks.

--
Jiri Kosina
SUSE Labs