2014-12-05 12:59:01

by Athira Lekshmi

Subject: [PATCH] Drivers:watchdog: Fixed missing blank line warning

Fixed the checkpatch warning:
Missing a blank line after declarations

Signed-off-by: Athira Lekshmi <[email protected]>
---
drivers/watchdog/mixcomwd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
index be86ea3..03b7612e 100644
--- a/drivers/watchdog/mixcomwd.c
+++ b/drivers/watchdog/mixcomwd.c
@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,

for (i = 0; i != len; i++) {
char c;
+
if (get_user(c, data + i))
return -EFAULT;
if (c == 'V')
--
1.7.9.5

2014-12-05 13:27:31

by Jeremiah Mahler

Subject: Re: [PATCH] Drivers:watchdog: Fixed missing blank line warning

Athira,

On Fri, Dec 05, 2014 at 06:29:00PM +0530, Athira Lekshmi wrote:
> Fixed the checkpatch warning:
> Missing a blank line after declarations
>
> Signed-off-by: Athira Lekshmi <[email protected]>
> ---
> drivers/watchdog/mixcomwd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
> index be86ea3..03b7612e 100644
> --- a/drivers/watchdog/mixcomwd.c
> +++ b/drivers/watchdog/mixcomwd.c
> @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,
>
> for (i = 0; i != len; i++) {
> char c;
> +
> if (get_user(c, data + i))
> return -EFAULT;
> if (c == 'V')
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

There should be spaces between the tags in your subject line. For
example, instead of "Drivers:watchdog:" use "Drivers: watchdog:".
And the tags should be useful, I am not sure if "Drivers" adds much.
I would probably just use "watchdog:" in this case.

--
- Jeremiah Mahler