2015-02-04 17:15:15

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] udf: use bool for done

variable 'done' is only used for true/false in loop.

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/udf/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/udf/super.c b/fs/udf/super.c
index 3d35a75..f169411 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1599,7 +1599,7 @@ static noinline int udf_process_sequence(
struct udf_vds_record *curr;
struct generic_desc *gd;
struct volDescPtr *vdp;
- int done = 0;
+ bool done = false;
uint32_t vdsn;
uint16_t ident;
long next_s = 0, next_e = 0;
@@ -1680,7 +1680,7 @@ static noinline int udf_process_sequence(
lastblock = next_e;
next_s = next_e = 0;
} else
- done = 1;
+ done = true;
break;
}
brelse(bh);
--
1.9.3

2015-02-05 15:37:06

by Jan Kara

Subject: Re: [PATCH 1/1 linux-next] udf: use bool for done

On Wed 04-02-15 18:15:04, Fabian Frederick wrote:
> variable 'done' is only used for true/false in loop.
OK, looks good. Merged.

Honza

>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/udf/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 3d35a75..f169411 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -1599,7 +1599,7 @@ static noinline int udf_process_sequence(
> struct udf_vds_record *curr;
> struct generic_desc *gd;
> struct volDescPtr *vdp;
> - int done = 0;
> + bool done = false;
> uint32_t vdsn;
> uint16_t ident;
> long next_s = 0, next_e = 0;
> @@ -1680,7 +1680,7 @@ static noinline int udf_process_sequence(
> lastblock = next_e;
> next_s = next_e = 0;
> } else
> - done = 1;
> + done = true;
> break;
> }
> brelse(bh);
> --
> 1.9.3
>
--
Jan Kara <[email protected]>
SUSE Labs, CR