2015-02-03 13:51:09

by Stanimir Varbanov

Subject: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

This enables pmic arbiter driver to be build on arm64
platforms.

Signed-off-by: Stanimir Varbanov <[email protected]>
---
drivers/spmi/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
index bf1295e..115348c 100644
--- a/drivers/spmi/Kconfig
+++ b/drivers/spmi/Kconfig
@@ -12,7 +12,7 @@ if SPMI

config SPMI_MSM_PMIC_ARB
tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
- depends on ARM
+ depends on ARM || ARM64
depends on IRQ_DOMAIN
depends on ARCH_QCOM || COMPILE_TEST
default ARCH_QCOM
--
1.7.0.4

2015-02-03 20:42:41

by Paul Bolle

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> This enables pmic arbiter driver to be build on arm64
> platforms.
>
> Signed-off-by: Stanimir Varbanov <[email protected]>
> ---
> drivers/spmi/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> index bf1295e..115348c 100644
> --- a/drivers/spmi/Kconfig
> +++ b/drivers/spmi/Kconfig
> @@ -12,7 +12,7 @@ if SPMI
>
> config SPMI_MSM_PMIC_ARB
> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> - depends on ARM
> + depends on ARM || ARM64
> depends on IRQ_DOMAIN
> depends on ARCH_QCOM || COMPILE_TEST
> default ARCH_QCOM

But only if COMPILE_TEST is set too, isn't it? Is that intended?


Paul Bolle

2015-02-04 15:05:21

by Stanimir Varbanov

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On 02/03/2015 10:42 PM, Paul Bolle wrote:
> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>> This enables pmic arbiter driver to be build on arm64
>> platforms.
>>
>> Signed-off-by: Stanimir Varbanov <[email protected]>
>> ---
>> drivers/spmi/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>> index bf1295e..115348c 100644
>> --- a/drivers/spmi/Kconfig
>> +++ b/drivers/spmi/Kconfig
>> @@ -12,7 +12,7 @@ if SPMI
>>
>> config SPMI_MSM_PMIC_ARB
>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>> - depends on ARM
>> + depends on ARM || ARM64
>> depends on IRQ_DOMAIN
>> depends on ARCH_QCOM || COMPILE_TEST
>> default ARCH_QCOM
>
> But only if COMPILE_TEST is set too, isn't it? Is that intended?

No, the driver will be used on arm64 qcom platforms, also.

--
regards,
Stan

2015-02-04 15:15:01

by Paul Bolle

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> On 02/03/2015 10:42 PM, Paul Bolle wrote:
> > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> >> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> >> index bf1295e..115348c 100644
> >> --- a/drivers/spmi/Kconfig
> >> +++ b/drivers/spmi/Kconfig
> >> @@ -12,7 +12,7 @@ if SPMI
> >>
> >> config SPMI_MSM_PMIC_ARB
> >> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> >> - depends on ARM
> >> + depends on ARM || ARM64
> >> depends on IRQ_DOMAIN
> >> depends on ARCH_QCOM || COMPILE_TEST
> >> default ARCH_QCOM
> >
> > But only if COMPILE_TEST is set too, isn't it? Is that intended?
>
> No, the driver will be used on arm64 qcom platforms, also.

But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?


Paul Bolle

2015-02-04 15:27:12

by Stanimir Varbanov

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On 02/04/2015 05:14 PM, Paul Bolle wrote:
> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
>> On 02/03/2015 10:42 PM, Paul Bolle wrote:
>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>>>> index bf1295e..115348c 100644
>>>> --- a/drivers/spmi/Kconfig
>>>> +++ b/drivers/spmi/Kconfig
>>>> @@ -12,7 +12,7 @@ if SPMI
>>>>
>>>> config SPMI_MSM_PMIC_ARB
>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>>>> - depends on ARM
>>>> + depends on ARM || ARM64
>>>> depends on IRQ_DOMAIN
>>>> depends on ARCH_QCOM || COMPILE_TEST
>>>> default ARCH_QCOM
>>>
>>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
>>
>> No, the driver will be used on arm64 qcom platforms, also.
>
> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?

Currently yes, but we want to be prepared to support PMIC's which will
be used on arm64 platforms, although they are not upstream yet.

--
regards,
Stan

2015-02-04 18:46:18

by Paul Bolle

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
> On 02/04/2015 05:14 PM, Paul Bolle wrote:
> > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> >> On 02/03/2015 10:42 PM, Paul Bolle wrote:
> >>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> >>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> >>>> index bf1295e..115348c 100644
> >>>> --- a/drivers/spmi/Kconfig
> >>>> +++ b/drivers/spmi/Kconfig
> >>>> @@ -12,7 +12,7 @@ if SPMI
> >>>>
> >>>> config SPMI_MSM_PMIC_ARB
> >>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> >>>> - depends on ARM
> >>>> + depends on ARM || ARM64
> >>>> depends on IRQ_DOMAIN
> >>>> depends on ARCH_QCOM || COMPILE_TEST
> >>>> default ARCH_QCOM
> >>>
> >>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
> >>
> >> No, the driver will be used on arm64 qcom platforms, also.
> >
> > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
>
> Currently yes, but we want to be prepared to support PMIC's which will
> be used on arm64 platforms, although they are not upstream yet.

Please make the commit summary reflect that, as in:
"spmi: pmic_arb: enable test build on arm64"

Commit explanation likewise.


Paul Bolle

2015-02-23 12:57:16

by Ivan T. Ivanov

Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote:
> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
> > On 02/04/2015 05:14 PM, Paul Bolle wrote:
> > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> > > > On 02/03/2015 10:42 PM, Paul Bolle wrote:
> > > > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> > > > > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> > > > > > index bf1295e..115348c 100644
> > > > > > --- a/drivers/spmi/Kconfig
> > > > > > +++ b/drivers/spmi/Kconfig
> > > > > > @@ -12,7 +12,7 @@ if SPMI
> > > > > >
> > > > > > config SPMI_MSM_PMIC_ARB
> > > > > > tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> > > > > > - depends on ARM
> > > > > > + depends on ARM || ARM64
> > > > > > depends on IRQ_DOMAIN
> > > > > > depends on ARCH_QCOM || COMPILE_TEST
> > > > > > default ARCH_QCOM
> > > > >
> > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended?
> > > >
> > > > No, the driver will be used on arm64 qcom platforms, also.
> > >
> > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
> >
> > Currently yes, but we want to be prepared to support PMIC's which will
> > be used on arm64 platforms, although they are not upstream yet.
>
> Please make the commit summary reflect that, as in:
> "spmi: pmic_arb: enable test build on arm64"
>
> Commit explanation likewise.

What if we just drop ARM dependency?

Regards,
Ivan