2015-02-17 21:57:46

by Davidlohr Bueso

Subject: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err

As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
we no longer call get_user_pages(), thus update the warning.

Signed-off-by: Davidlohr Bueso <[email protected]>
---
drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index 35f19a6..1d80c56 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
produce_q->kernel_if->num_pages, 1,
produce_q->kernel_if->u.h.header_page);
if (retval < produce_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
+ pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
+ retval);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
retval, false);
err = VMCI_ERROR_NO_MEM;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
consume_q->kernel_if->num_pages, 1,
consume_q->kernel_if->u.h.header_page);
if (retval < consume_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(consume) failed (retval=%d)", retval);
+ pr_warn("get_user_pages_fast(consume) failed (retval=%d)",
+ retval);
qp_release_pages(consume_q->kernel_if->u.h.header_page,
retval, false);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
--
2.1.4

2015-02-17 22:03:08

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err

On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> we no longer call get_user_pages(), thus update the warning.
>
> Signed-off-by: Davidlohr Bueso <[email protected]>
> ---
> drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index 35f19a6..1d80c56 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> produce_q->kernel_if->num_pages, 1,
> produce_q->kernel_if->u.h.header_page);
> if (retval < produce_q->kernel_if->num_pages) {
> - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> + retval);

What can a user do with this message? Shouldn't it be a debug message?

thanks,

greg k-h

2015-02-17 22:09:26

by Davidlohr Bueso

Subject: Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err

On Tue, 2015-02-17 at 14:02 -0800, Greg Kroah-Hartman wrote:
> On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> > As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> > we no longer call get_user_pages(), thus update the warning.
> >
> > Signed-off-by: Davidlohr Bueso <[email protected]>
> > ---
> > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > index 35f19a6..1d80c56 100644
> > --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> > produce_q->kernel_if->num_pages, 1,
> > produce_q->kernel_if->u.h.header_page);
> > if (retval < produce_q->kernel_if->num_pages) {
> > - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> > + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> > + retval);
>
> What can a user do with this message? Shouldn't it be a debug message?

I was trying to be as least invasive as possible, as I zero knowledge of
this thingie. But yes, such a message does seem more appropriate as
pr_debug(). Do you want me to respin?

2015-02-17 22:20:49

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err

On Tue, Feb 17, 2015 at 02:09:19PM -0800, Davidlohr Bueso wrote:
> On Tue, 2015-02-17 at 14:02 -0800, Greg Kroah-Hartman wrote:
> > On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> > > As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> > > we no longer call get_user_pages(), thus update the warning.
> > >
> > > Signed-off-by: Davidlohr Bueso <[email protected]>
> > > ---
> > > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > index 35f19a6..1d80c56 100644
> > > --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> > > produce_q->kernel_if->num_pages, 1,
> > > produce_q->kernel_if->u.h.header_page);
> > > if (retval < produce_q->kernel_if->num_pages) {
> > > - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> > > + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> > > + retval);
> >
> > What can a user do with this message? Shouldn't it be a debug message?
>
> I was trying to be as least invasive as possible, as I zero knowledge of
> this thingie. But yes, such a message does seem more appropriate as
> pr_debug(). Do you want me to respin?

Please do.

thanks,

greg k-h

2015-02-17 22:29:28

by Davidlohr Bueso

Subject: [PATCH v2] drivers/vmw_vmci: Show correct get_user_pages_fast upon failure

As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
we no longer user get_user_pages(), thus update the warning.

Also convert to pr_debug, which is a more appropriate level of logging.

Signed-off-by: Davidlohr Bueso <[email protected]>
---
drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index 35f19a6..c384945 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
produce_q->kernel_if->num_pages, 1,
produce_q->kernel_if->u.h.header_page);
if (retval < produce_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
+ pr_debug("get_user_pages_fast(produce) failed (retval=%d)",
+ retval);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
retval, false);
err = VMCI_ERROR_NO_MEM;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
consume_q->kernel_if->num_pages, 1,
consume_q->kernel_if->u.h.header_page);
if (retval < consume_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(consume) failed (retval=%d)", retval);
+ pr_debug("get_user_pages_fast(consume) failed (retval=%d)",
+ retval);
qp_release_pages(consume_q->kernel_if->u.h.header_page,
retval, false);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
--
2.1.4