2015-02-24 18:53:39

by Shuah Khan

[permalink] [raw]
Subject: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug

Replace printk KERN_DEBUG with pr_debug in dprintk macro
defined in au0828.h

Signed-off-by: Shuah Khan <[email protected]>
---
drivers/media/usb/au0828/au0828.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
index eb15187..e3e90ea 100644
--- a/drivers/media/usb/au0828/au0828.h
+++ b/drivers/media/usb/au0828/au0828.h
@@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;

#define dprintk(level, fmt, arg...)\
do { if (au0828_debug & level)\
- printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
+ pr_debug(pr_fmt(fmt), ## arg);\
} while (0)

/* au0828-input.c */
--
2.1.0


2015-02-24 22:03:52

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug

Em Tue, 24 Feb 2015 11:53:34 -0700
Shuah Khan <[email protected]> escreveu:

> Replace printk KERN_DEBUG with pr_debug in dprintk macro
> defined in au0828.h
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> drivers/media/usb/au0828/au0828.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
> index eb15187..e3e90ea 100644
> --- a/drivers/media/usb/au0828/au0828.h
> +++ b/drivers/media/usb/au0828/au0828.h
> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>
> #define dprintk(level, fmt, arg...)\
> do { if (au0828_debug & level)\
> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
> + pr_debug(pr_fmt(fmt), ## arg);\

NACK.

This is the worse of two words, as it would require both to enable
each debug line via dynamic printk setting and to enable au0828_debug.

Regards,
Mauro


> } while (0)
>
> /* au0828-input.c */

2015-02-24 23:41:52

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug

On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Feb 2015 11:53:34 -0700
> Shuah Khan <[email protected]> escreveu:
>
>> Replace printk KERN_DEBUG with pr_debug in dprintk macro
>> defined in au0828.h
>>
>> Signed-off-by: Shuah Khan <[email protected]>
>> ---
>> drivers/media/usb/au0828/au0828.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
>> index eb15187..e3e90ea 100644
>> --- a/drivers/media/usb/au0828/au0828.h
>> +++ b/drivers/media/usb/au0828/au0828.h
>> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>>
>> #define dprintk(level, fmt, arg...)\
>> do { if (au0828_debug & level)\
>> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
>> + pr_debug(pr_fmt(fmt), ## arg);\
>
> NACK.
>
> This is the worse of two words, as it would require both to enable
> each debug line via dynamic printk setting and to enable au0828_debug.
>
> Regards,
> Mauro


Ah. I missed that. Sorry for the noise.

-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978