2015-02-24 21:00:44

by Ameen

Subject: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404.

Signed-off-by : Ameen Ali <[email protected]>
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index 3c651d5..944cf7b 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
pRaInfo->PTModeSS = 3;
else if (pRaInfo->HighestRate > 0x0b)
pRaInfo->PTModeSS = 2;
- else if (pRaInfo->HighestRate > 0x0b)
+ else if (pRaInfo->HighestRate > 0x5)
pRaInfo->PTModeSS = 1;
else
pRaInfo->PTModeSS = 0;
--
2.1.0

2015-02-24 22:10:43

by Dan Carpenter

Subject: Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

On Tue, Feb 24, 2015 at 11:00:31PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
>

The changelog should really say why you think 0x5 is correct. Could you
update and resend?

regards,
dan carpenter