2015-02-26 18:42:59

by Tal Shorer

Subject: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value

Signed-off-by: Tal Shorer <[email protected]>
---
drivers/usb/gadget/function/f_mass_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index 811929c..6d5ca2b 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
if (!curlun) { /* Unsupported LUNs are okay */
common->bad_lun_okay = 1;
memset(buf, 0, 36);
- buf[0] = 0x7f; /* Unsupported, no device-type */
+ buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
buf[4] = 31; /* Additional length */
return 36;
}
--
2.2.2

2015-02-27 12:22:52

by Michal Nazarewicz

Subject: Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value

On Thu, Feb 26 2015, Tal Shorer <[email protected]> wrote:
> Signed-off-by: Tal Shorer <[email protected]>

Acked-by: Michal Nazarewicz <[email protected]>

> ---
> drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 811929c..6d5ca2b 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
> if (!curlun) { /* Unsupported LUNs are okay */
> common->bad_lun_okay = 1;
> memset(buf, 0, 36);
> - buf[0] = 0x7f; /* Unsupported, no device-type */
> + buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
> buf[4] = 31; /* Additional length */
> return 36;
> }
> --
> 2.2.2
>

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<[email protected]>--<xmpp:[email protected]>--ooO--(_)--Ooo--