Hi,
Here are two patches to bring support for a new hardware based on SAM9G25 SoC.
The first one adds the PIN controller definition for PWM0.
The second defines the new board.
Best regards,
Gaël PORTAY (2):
ARM: at91/dt: sam9x5: add pinctrl for pwm0
ARM: at91/dt: add support for kizboxmini.
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-kizboxmini.dts | 129 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/at91sam9x5.dtsi | 46 ++++++++++++
3 files changed, 176 insertions(+)
create mode 100644 arch/arm/boot/dts/at91-kizboxmini.dts
--
1.9.1
Defines the pinctrl configurations for PWM0.
Signed-off-by: Gaël PORTAY <[email protected]>
---
arch/arm/boot/dts/at91sam9x5.dtsi | 46 +++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index d221179..08ed53d 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -463,6 +463,52 @@
};
};
+ pwm0 {
+ pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 {
+ atmel,pins =
+ <AT91_PIOB 11 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB11 periph B */
+ };
+ pinctrl_pwm0_pwm0_1: pwm0_pwm0-1 {
+ atmel,pins =
+ <AT91_PIOC 10 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC10 periph C */
+ };
+ pinctrl_pwm0_pwm0_2: pwm0_pwm0-2 {
+ atmel,pins =
+ <AT91_PIOC 18 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC18 periph C */
+ };
+
+ pinctrl_pwm0_pwm1_0: pwm0_pwm1-0 {
+ atmel,pins =
+ <AT91_PIOB 12 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB12 periph B */
+ };
+ pinctrl_pwm0_pwm1_1: pwm0_pwm1-1 {
+ atmel,pins =
+ <AT91_PIOC 11 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC11 periph C */
+ };
+ pinctrl_pwm0_pwm1_2: pwm0_pwm1-2 {
+ atmel,pins =
+ <AT91_PIOC 19 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC19 periph C */
+ };
+
+ pinctrl_pwm0_pwm2_0: pwm0_pwm2-0 {
+ atmel,pins =
+ <AT91_PIOB 13 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB13 periph B */
+ };
+ pinctrl_pwm0_pwm2_1: pwm0_pwm2-1 {
+ atmel,pins =
+ <AT91_PIOC 20 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC20 periph C */
+ };
+
+ pinctrl_pwm0_pwm3_0: pwm0_pwm3-0 {
+ atmel,pins =
+ <AT91_PIOB 14 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB14 periph B */
+ };
+ pinctrl_pwm0_pwm3_1: pwm0_pwm3-1 {
+ atmel,pins =
+ <AT91_PIOC 21 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC21 periph C */
+ };
+ };
+
usart0 {
pinctrl_usart0: usart0-0 {
atmel,pins =
--
1.9.1
Add DT file for Kizbox mini board.
This board is based on Atmel's AT91SAM9G25 SoC.
Signed-off-by: Gaël PORTAY <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-kizboxmini.dts | 129 ++++++++++++++++++++++++++++++++++
2 files changed, 130 insertions(+)
create mode 100644 arch/arm/boot/dts/at91-kizboxmini.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b..9c11888 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -30,6 +30,7 @@ dtb-$(CONFIG_SOC_SAM_V4_V5) += \
at91sam9rlek.dtb \
at91-ariag25.dtb \
at91-cosino_mega2560.dtb \
+ at91-kizboxmini.dtb \
at91sam9g15ek.dtb \
at91sam9g25ek.dtb \
at91sam9g35ek.dtb \
diff --git a/arch/arm/boot/dts/at91-kizboxmini.dts b/arch/arm/boot/dts/at91-kizboxmini.dts
new file mode 100644
index 0000000..191576c
--- /dev/null
+++ b/arch/arm/boot/dts/at91-kizboxmini.dts
@@ -0,0 +1,129 @@
+/*
+ * at91-kizboxmini.dts - Device Tree file for Overkiz Kizbox mini board
+ *
+ * Copyright (C) 2014 Gaël PORTAY <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+#include "at91sam9g25.dtsi"
+#include "at91sam9x5.dtsi"
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+ model = "Overkiz Kizbox mini";
+ compatible = "overkiz,kizboxmini", "atmel,at91sam9g25ek", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";
+
+ chosen {
+ bootargs = "ubi.mtd=ubi";
+ linux,stdout-path = &dbgu;
+ };
+
+ memory {
+ reg = <0x20000000 0x8000000>;
+ };
+
+ clocks {
+ slow_xtal {
+ clock-frequency = <32768>;
+ };
+
+ main_xtal {
+ clock-frequency = <12000000>;
+ };
+ };
+
+ ahb {
+ apb {
+ usart0: serial@f801c000 {
+ status = "okay";
+ };
+
+ macb0: ethernet@f802c000 {
+ phy-mode = "rmii";
+ status = "okay";
+ };
+
+ pwm0: pwm@f8034000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0_pwm0_1
+ &pinctrl_pwm0_pwm1_1>;
+ status = "okay";
+ };
+
+ dbgu: serial@fffff200 {
+ status = "okay";
+ };
+
+ watchdog@fffffe40 {
+ status = "okay";
+ };
+ };
+
+ usb0: ohci@00600000 {
+ status = "okay";
+ };
+
+ usb1: ehci@00700000 {
+ status = "okay";
+ };
+
+ nand0: nand@40000000 {
+ nand-bus-width = <8>;
+ nand-ecc-mode = "hw";
+ atmel,has-pmecc;
+ atmel,pmecc-cap = <4>;
+ atmel,pmecc-sector-size = <512>;
+ nand-on-flash-bbt;
+ status = "okay";
+
+ bootstrap@0 {
+ label = "bootstrap";
+ reg = <0x0 0x20000>;
+ };
+
+ ubi@20000 {
+ label = "ubi";
+ reg = <0x20000 0x7fe0000>;
+ };
+ };
+ };
+
+ pwm_leds {
+ compatible = "pwm-leds";
+
+ green {
+ label = "pwm:green:user";
+ pwms = <&pwm0 0 10000000 0>;
+ max-brightness = <255>;
+ linux,default-trigger = "default-on";
+ };
+
+ red {
+ label = "pwm:red:user";
+ pwms = <&pwm0 1 10000000 0>;
+ max-brightness = <255>;
+ linux,default-trigger = "default-on";
+ };
+ };
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ prog {
+ label = "PB_PROG";
+ gpios = <&pioC 17 GPIO_ACTIVE_LOW>;
+ linux,code = <0x102>;
+ gpio-key,wakeup;
+ };
+
+ reset {
+ label = "PB_RST";
+ gpios = <&pioC 16 GPIO_ACTIVE_LOW>;
+ linux,code = <0x100>;
+ gpio-key,wakeup;
+ };
+ };
+};
--
1.9.1
Hi Ga?l,
On 07/04/2015 at 16:11:23 +0200, Ga?l PORTAY wrote :
> Defines the pinctrl configurations for PWM0.
>
> Signed-off-by: Ga?l PORTAY <[email protected]>
> ---
> arch/arm/boot/dts/at91sam9x5.dtsi | 46 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index d221179..08ed53d 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -463,6 +463,52 @@
> };
> };
>
> + pwm0 {
> + pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 {
> + atmel,pins =
> + <AT91_PIOB 11 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB11 periph B */
please drop those useless comments --^
Else, I'm fine with that patch.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Hi,
On 07/04/2015 at 16:11:24 +0200, Ga?l PORTAY wrote :
> Add DT file for Kizbox mini board.
> This board is based on Atmel's AT91SAM9G25 SoC.
>
> Signed-off-by: Ga?l PORTAY <[email protected]>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-kizboxmini.dts | 129 ++++++++++++++++++++++++++++++++++
> 2 files changed, 130 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-kizboxmini.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a1c776b..9c11888 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -30,6 +30,7 @@ dtb-$(CONFIG_SOC_SAM_V4_V5) += \
> at91sam9rlek.dtb \
> at91-ariag25.dtb \
> at91-cosino_mega2560.dtb \
> + at91-kizboxmini.dtb \
> at91sam9g15ek.dtb \
> at91sam9g25ek.dtb \
> at91sam9g35ek.dtb \
> diff --git a/arch/arm/boot/dts/at91-kizboxmini.dts b/arch/arm/boot/dts/at91-kizboxmini.dts
> new file mode 100644
> index 0000000..191576c
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-kizboxmini.dts
> @@ -0,0 +1,129 @@
> +/*
> + * at91-kizboxmini.dts - Device Tree file for Overkiz Kizbox mini board
> + *
> + * Copyright (C) 2014 Ga?l PORTAY <[email protected]>
> + *
> + * Licensed under GPLv2 or later.
> + */
> +/dts-v1/;
> +#include "at91sam9g25.dtsi"
> +#include "at91sam9x5.dtsi"
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Overkiz Kizbox mini";
> + compatible = "overkiz,kizboxmini", "atmel,at91sam9g25ek", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";
I would remove "atmel,at91sam9g25ek" and "atmel,at91sam9x5ek". However,
you could use "atmel,at91sam9g25".
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
On 2015-04-07 21:22, Alexandre Belloni wrote:
> Hi Gaël,
>
> On 07/04/2015 at 16:11:23 +0200, Gaël PORTAY wrote :
>> Defines the pinctrl configurations for PWM0.
>>
>> Signed-off-by: Gaël PORTAY <[email protected]>
>> ---
>> arch/arm/boot/dts/at91sam9x5.dtsi | 46
>> +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi
>> b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index d221179..08ed53d 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -463,6 +463,52 @@
>> };
>> };
>>
>> + pwm0 {
>> + pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 {
>> + atmel,pins =
>> + <AT91_PIOB 11 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB11 periph
>> B */
> please drop those useless
> comments --^
>
> Else, I'm fine with that patch.
I do think so... I added them for consistency only... I will drop them
in v2.
Do you want I drop all those kind of comments (of the whole file) as
well ?
Thanks for your review.
On 2015-04-07 21:32, Alexandre Belloni wrote:
> Hi,
>
> On 07/04/2015 at 16:11:24 +0200, Gaël PORTAY wrote :
>> Add DT file for Kizbox mini board.
>> This board is based on Atmel's AT91SAM9G25 SoC.
>>
>> Signed-off-by: Gaël PORTAY <[email protected]>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/at91-kizboxmini.dts | 129
>> ++++++++++++++++++++++++++++++++++
>> 2 files changed, 130 insertions(+)
>> create mode 100644 arch/arm/boot/dts/at91-kizboxmini.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index a1c776b..9c11888 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -30,6 +30,7 @@ dtb-$(CONFIG_SOC_SAM_V4_V5) += \
>> at91sam9rlek.dtb \
>> at91-ariag25.dtb \
>> at91-cosino_mega2560.dtb \
>> + at91-kizboxmini.dtb \
>> at91sam9g15ek.dtb \
>> at91sam9g25ek.dtb \
>> at91sam9g35ek.dtb \
>> diff --git a/arch/arm/boot/dts/at91-kizboxmini.dts
>> b/arch/arm/boot/dts/at91-kizboxmini.dts
>> new file mode 100644
>> index 0000000..191576c
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/at91-kizboxmini.dts
>> @@ -0,0 +1,129 @@
>> +/*
>> + * at91-kizboxmini.dts - Device Tree file for Overkiz Kizbox mini
>> board
>> + *
>> + * Copyright (C) 2014 Gaël PORTAY <[email protected]>
>> + *
>> + * Licensed under GPLv2 or later.
>> + */
>> +/dts-v1/;
>> +#include "at91sam9g25.dtsi"
>> +#include "at91sam9x5.dtsi"
>> +#include <dt-bindings/pwm/pwm.h>
>> +
>> +/ {
>> + model = "Overkiz Kizbox mini";
>> + compatible = "overkiz,kizboxmini", "atmel,at91sam9g25ek",
>> "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";
>
> I would remove "atmel,at91sam9g25ek" and "atmel,at91sam9x5ek". However,
> you could use "atmel,at91sam9g25".
I guess your right...
On 07/04/2015 at 21:40:56 +0200, [email protected] wrote :
> >
> >Else, I'm fine with that patch.
>
> I do think so... I added them for consistency only... I will drop them in
> v2.
>
> Do you want I drop all those kind of comments (of the whole file) as well ?
>
I don't think it is necessary to do that change for the whole file yet,
let's just avoid adding more.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com