2015-04-08 02:14:54

by Wang Nan

Subject: [PATCH -tip] perf probe: fix ARM 32 building error.

Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
handle aliased symbols in glibc") uses an absolute format '%lx' to
print u64 argument, which causes compiling error on ARM 32.

This patch replaces it with PRIx64.

Signed-off-by: Wang Nan <[email protected]>
---
tools/perf/util/probe-event.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 8feac07..3dacec9 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
ret = -ENOENT;
goto out;
}
- pr_debug("Symbol %s address found : %lx\n", pp->function, address);
+ pr_debug("Symbol %s address found : %" PRIx64 "\n",
+ pp->function, address);

ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
result);
--
1.8.3.4

2015-04-08 02:36:42

by 平松雅巳 / HIRAMATU，MASAMI

Subject: Re: [PATCH -tip] perf probe: fix ARM 32 building error.

(2015/04/08 11:14), Wang Nan wrote:
> Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
> handle aliased symbols in glibc") uses an absolute format '%lx' to
> print u64 argument, which causes compiling error on ARM 32.
>
> This patch replaces it with PRIx64.

Good catch! :)

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

>
> Signed-off-by: Wang Nan <[email protected]>
> ---
> tools/perf/util/probe-event.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 8feac07..3dacec9 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
> ret = -ENOENT;
> goto out;
> }
> - pr_debug("Symbol %s address found : %lx\n", pp->function, address);
> + pr_debug("Symbol %s address found : %" PRIx64 "\n",
> + pp->function, address);
>
> ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
> result);
>


--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: [email protected]

2015-04-08 15:15:14

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf probe: Fix ARM 32 building error

Commit-ID: f6c15621f04b97ce882c66e5055f0ac325fb8eb8
Gitweb: http://git.kernel.org/tip/f6c15621f04b97ce882c66e5055f0ac325fb8eb8
Author: Wang Nan <[email protected]>
AuthorDate: Wed, 8 Apr 2015 02:14:34 +0000
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 8 Apr 2015 10:49:48 -0300

perf probe: Fix ARM 32 building error

Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
handle aliased symbols in glibc") uses an absolute format '%lx' to
print u64 argument, which causes compiling error on ARM 32.

This patch replaces it with PRIx64.

Signed-off-by: Wang Nan <[email protected]>
Acked-by: Masami Hiramatsu <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Zefan Li <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/probe-event.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 4fd49f0..b788517 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -322,7 +322,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
ret = -ENOENT;
goto out;
}
- pr_debug("Symbol %s address found : %lx\n", pp->function, address);
+ pr_debug("Symbol %s address found : %" PRIx64 "\n",
+ pp->function, address);

ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
result);