2015-04-16 10:58:35

by Shreyas B. Prabhu

[permalink] [raw]
Subject: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error

kvm_no_guest function calls power7_wakeup_loss to put the thread into
the deepest supported idle state. power7_wakeup_loss is defined in
arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
And PPC_P7_NAP is selected when PPC_POWERNV=y.
Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
following error:

arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'

Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.

Signed-off-by: Shreyas B. Prabhu <[email protected]>
---
arch/powerpc/kvm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index 11850f3..b3b3d9f 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -75,7 +75,7 @@ config KVM_BOOK3S_64

config KVM_BOOK3S_64_HV
tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
- depends on KVM_BOOK3S_64
+ depends on KVM_BOOK3S_64 && PPC_POWERNV
select KVM_BOOK3S_HV_POSSIBLE
select MMU_NOTIFIER
select CMA
--
1.9.3


2015-04-23 04:42:37

by Shreyas B. Prabhu

[permalink] [raw]
Subject: Re: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error

Any suggestions on this?

On Thursday 16 April 2015 04:28 PM, Shreyas B. Prabhu wrote:
> kvm_no_guest function calls power7_wakeup_loss to put the thread into
> the deepest supported idle state. power7_wakeup_loss is defined in
> arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
> And PPC_P7_NAP is selected when PPC_POWERNV=y.
> Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
> following error:
>
> arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
> arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'
>
> Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.
>
> Signed-off-by: Shreyas B. Prabhu <[email protected]>
> ---
> arch/powerpc/kvm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index 11850f3..b3b3d9f 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -75,7 +75,7 @@ config KVM_BOOK3S_64
>
> config KVM_BOOK3S_64_HV
> tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
> - depends on KVM_BOOK3S_64
> + depends on KVM_BOOK3S_64 && PPC_POWERNV
> select KVM_BOOK3S_HV_POSSIBLE
> select MMU_NOTIFIER
> select CMA
>

2015-04-23 07:24:43

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error

On Thu, 2015-04-23 at 10:11 +0530, Shreyas B Prabhu wrote:
> Any suggestions on this?

It's in:

https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=fixes

cheers