2015-04-18 20:16:15

by Yorick Rommers

Subject: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

From: Yorick <[email protected]>

This is a patch that fixes errors regarding whitespaces and split strings.

Signed-off-by: Yorick Rommers <[email protected]>
---
drivers/staging/i2o/i2o_block.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/i2o/i2o_block.c b/drivers/staging/i2o/i2o_block.c
index 406758f..206d9c4 100644
--- a/drivers/staging/i2o/i2o_block.c
+++ b/drivers/staging/i2o/i2o_block.c
@@ -36,7 +36,7 @@
* Independent queues per IOP
* Support for dynamic device creation/deletion
* Code cleanup
- * Support for larger I/Os through merge* functions
+ * Support for larger I/Os through merge* functions
* (taken from DAC960 driver)
* Boji T Kannanthanam:
* Set the I2O Block devices to be detected in increasing
@@ -315,7 +315,7 @@ static inline void i2o_block_request_free(struct i2o_block_request *ireq)
*/
static inline int i2o_block_sglist_alloc(struct i2o_controller *c,
struct i2o_block_request *ireq,
- u32 ** mptr)
+ u32 **mptr)
{
int nents;
enum dma_data_direction direction;
@@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
* Don't stick a supertrak100 into cache aggressive modes
*/

- osm_err("TID %03x error status: 0x%02x, detailed status: "
- "0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
+ osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n",
+ (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
status >> 24, status & 0xffff);

req->errors++;
@@ -505,6 +505,7 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
static void i2o_block_event(struct work_struct *work)
{
struct i2o_event *evt = container_of(work, struct i2o_event, work);
+
osm_debug("event received\n");
kfree(evt);
};
--
2.3.5

2015-04-20 08:02:23

by Dan Carpenter

Subject: Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote:
> From: Yorick <[email protected]>

Don't include a From: unless you are sending a patch someone else wrote.
Otherwise we prefer to get it from your email From. Also you forgot
your last name.

> @@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
> * Don't stick a supertrak100 into cache aggressive modes
> */
>
> - osm_err("TID %03x error status: 0x%02x, detailed status: "
> - "0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> + osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n",
> + (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> status >> 24, status & 0xffff);

The new indenting is wrong.

regards,
dan carpenter

2015-04-20 09:06:55

by Alan

Subject: Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

On Sat, 2015-04-18 at 22:12 +0200, Yorick Rommers wrote:
> From: Yorick <[email protected]>
>
> This is a patch that fixes errors regarding whitespaces and split strings.

Wouldn't worry. The i2o layer is in staging because it is about to be
dropped from the kernel unless someone steps up to maintain it. Given
its unlikely anyone even has hardware I doubt that will happen.

Alan