2015-04-24 11:36:49

by Vince Bridgers

Subject: [PATCH] net: eth: altera: Resolve false errors from MSGDMA to TSE

From: Chee Nouk Phoon <[email protected]>

This patch resolves false errors from MSGDMA in TX mSGDMA MM to ST
mode, and is a continuation of the patch recently submitted by Andrea
Oetken. The MSGDMA had a logic bug that masked detection of this issue
prior to Quartus 14.1/Build 164. When the MSGDMA logic bug was addressed
in Quartus 14.1/Build 164, the driver problem was exposed.

The problem is corrected by making sure MSGDMA_DESC_CTL_TR_ERR_IRQ is not
set for any of the transmit DMA descriptors, and only used for receive
descriptors.

Fixes: 71cd26e altera tse: Error-Bit on tx-avalon-stream always set.

Signed-off-by: Chee Nouk Phoon <[email protected]>
Signed-off-by: Vince Bridgers <[email protected]>a
Cc: Andreas Oetken <[email protected]>
---
drivers/net/ethernet/altera/altera_msgdmahw.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/altera/altera_msgdmahw.h b/drivers/net/ethernet/altera/altera_msgdmahw.h
index eba070f..89cd11d 100644
--- a/drivers/net/ethernet/altera/altera_msgdmahw.h
+++ b/drivers/net/ethernet/altera/altera_msgdmahw.h
@@ -58,15 +58,12 @@ struct msgdma_extended_desc {
/* Tx buffer control flags
*/
#define MSGDMA_DESC_CTL_TX_FIRST (MSGDMA_DESC_CTL_GEN_SOP | \
- MSGDMA_DESC_CTL_TR_ERR_IRQ | \
MSGDMA_DESC_CTL_GO)

-#define MSGDMA_DESC_CTL_TX_MIDDLE (MSGDMA_DESC_CTL_TR_ERR_IRQ | \
- MSGDMA_DESC_CTL_GO)
+#define MSGDMA_DESC_CTL_TX_MIDDLE (MSGDMA_DESC_CTL_GO)

#define MSGDMA_DESC_CTL_TX_LAST (MSGDMA_DESC_CTL_GEN_EOP | \
MSGDMA_DESC_CTL_TR_COMP_IRQ | \
- MSGDMA_DESC_CTL_TR_ERR_IRQ | \
MSGDMA_DESC_CTL_GO)

#define MSGDMA_DESC_CTL_TX_SINGLE (MSGDMA_DESC_CTL_GEN_SOP | \
--
1.9.1

2015-04-25 18:44:04

by David Miller

Subject: Re: [PATCH] net: eth: altera: Resolve false errors from MSGDMA to TSE

From: Vince Bridgers <[email protected]>
Date: Fri, 24 Apr 2015 02:32:07 -0500

> From: Chee Nouk Phoon <[email protected]>
>
> This patch resolves false errors from MSGDMA in TX mSGDMA MM to ST
> mode, and is a continuation of the patch recently submitted by Andrea
> Oetken. The MSGDMA had a logic bug that masked detection of this issue
> prior to Quartus 14.1/Build 164. When the MSGDMA logic bug was addressed
> in Quartus 14.1/Build 164, the driver problem was exposed.
>
> The problem is corrected by making sure MSGDMA_DESC_CTL_TR_ERR_IRQ is not
> set for any of the transmit DMA descriptors, and only used for receive
> descriptors.
>
> Fixes: 71cd26e altera tse: Error-Bit on tx-avalon-stream always set.
>
> Signed-off-by: Chee Nouk Phoon <[email protected]>
> Signed-off-by: Vince Bridgers <[email protected]>a
> Cc: Andreas Oetken <[email protected]>

Applied.